From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3mQuIpJ69mItviUAWB0awg (envelope-from ) for ; Fri, 12 Aug 2022 12:06:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 7A92B1E5EA; Fri, 12 Aug 2022 12:06:42 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=v81VQt+0; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 16B251E21F for ; Fri, 12 Aug 2022 12:06:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 46AA13858415 for ; Fri, 12 Aug 2022 16:06:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46AA13858415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1660320401; bh=T6kiD6zo676afCIPSGKeD2C/bJhDIr1qcKLpnR2MA00=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=v81VQt+0b7/63vw6LgURTqgWtZ6F3wazTUyN5H8IoEqbO9drhvMc504/qHoLD6QDn BLWNT7JRaFw4cwppQvFC9u3K/WmEy52jsKH7vh0G/SreOun461OukfktddrP0XZ8Yr 6+ViU29Ys9iO1Efv3HZDWke4ZbUAp1WnQ92xOe88= Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 01B733858D28 for ; Fri, 12 Aug 2022 16:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01B733858D28 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27CFmloA004080 for ; Fri, 12 Aug 2022 16:06:20 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hwsu4gh5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 16:06:20 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27CG54XM029402 for ; Fri, 12 Aug 2022 16:06:19 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma02dal.us.ibm.com with ESMTP id 3hvkjhec63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 16:06:19 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27CG6Hed918048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Aug 2022 16:06:17 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 98662C6055; Fri, 12 Aug 2022 16:06:17 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64063C6057; Fri, 12 Aug 2022 16:06:17 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.56.41]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 12 Aug 2022 16:06:17 +0000 (GMT) Message-ID: Subject: Re: [PATCH ver 3] Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp To: Ulrich Weigand , "gdb-patches@sourceware.org" Date: Fri, 12 Aug 2022 09:06:16 -0700 In-Reply-To: References: <3783e7e44fe188af5ca1f2ddcfa4c7f5cb7a818e.camel@us.ibm.com> <47fd087cd94544b980aab5eed9f6113ab5a183f9.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: YKQoY9_gie05TUNYBRK_CH2X366OYarZ X-Proofpoint-ORIG-GUID: YKQoY9_gie05TUNYBRK_CH2X366OYarZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-12_10,2022-08-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=805 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208120043 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" GDB maintainers: I have updated the patch to use the skip_hw_watchpoint_tests check instead of the skip_hw_watchpoint_access_tests. Also, I changed the patch to use the same coding style as used in break-idempotent.exp per Ulrich's comments. The gdb.base/watchpoint-reuse-slot.exp uses the check: if { ![target_info exists gdb,no_hardware_watchpoints]} to determine if the test should be run with HW watchpoints. The target_info exists check for HW watchpoints is TRUE on Power 9. However HW watchpoints are disabled on Power 9 due to a HW bug. The skip_hw_watchpoint_tests check needs to be used to properly determine if HW watchpoints are supported by the processor. If the processor is PowerPC, the skip_hw_watchpoint_access_tests will run a small gdb test if the processor supports HW watchpoints. On other platforms, the skip_hw_watchpoint_tests checks the list of processors that support HW watchpoints. This patch replaces the [target_info exists gdb, no_hardware_watchpoints] with the skip_hw_watchpoint_tests check to properly determine if the processor supports HW watchpoints. The fix disables the HW watchpoint tests on Power 9 thus eliminating 48 testsuite failures. The patch has been tested on Power 9, Power 10 and x86-64 Please let me know if this patch is acceptable for mainline. Thanks. Carl Love ------------------------------------------------------------- Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp This test generates 48 failures on Power 9 when testing with HW watchpoints enabled. Note HW watchpoint support is disabled on Power 9 due to a HW bug. The skip_hw_watchpoint_tests proc must be used to correctly determine if the processor supports HW watchpoints. This patch replaces the [target_info exists gdb,no_hardware_watchpoints] with the skip_hw_watchpoint_tests check. This patch was tested on Power 9, Power 10 and X86-64 with no regressions. --- gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp index e2ea137424b..607d0f8053c 100644 --- a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp +++ b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp @@ -22,6 +22,16 @@ # operation. (Note that we don't have any of these watchpoints # trigger.) +# The skip_hw_watchpoint_tests checks if watchpoints are supported by the +# processor. On PowerPC, the check runs a small test program under gdb +# to determine if the Power processor supports HW watchpoints. The check +# must be done before starting the test so as to not disrupt the execution +# of the actual test. + +set skip_hw_watchpoint_tests_p [skip_hw_watchpoint_tests] + +# starting the test. + standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { @@ -285,7 +295,7 @@ proc setup_and_run_watchpoints_tests { hw_wp_p } { # Run tests with hardware watchpoints disabled, then again with them # enabled (if this target supports hardware watchpoints). -if { ![target_info exists gdb,no_hardware_watchpoints]} { +if { ![skip_hw_breakpoint_tests] } { # Run test with H/W enabled. setup_and_run_watchpoints_tests 1 } -- 2.31.1