From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L5yJN2WUOGnngSkAWB0awg (envelope-from ) for ; Tue, 09 Dec 2025 16:28:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765315685; bh=k0yzGsgcKmbM0siTdSot7osZb2iOG5fkyk1tncRESGk=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JBOy0p82YOoYJGpgrsNtcIekYecZoTvdeH+CWlZR4lb/QYbcQ3nc4ylkhv55fbeo0 opjFwVSUQwrulDw1GmLF03oJGpxbUTteA+d6zCHXR+Z+X5neBWzvzDE7rw6j2td1mF ISMJ23+OeLzlkMgnhXf2d2V4Z/jy1DlnEG4t3pQw= Received: by simark.ca (Postfix, from userid 112) id CFADB1E0B3; Tue, 09 Dec 2025 16:28:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=A3ZaXE89; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 040AC1E08D for ; Tue, 09 Dec 2025 16:28:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 83D054BA2E04 for ; Tue, 9 Dec 2025 21:28:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 83D054BA2E04 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=A3ZaXE89 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 96E544BA540C for ; Tue, 9 Dec 2025 21:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 96E544BA540C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 96E544BA540C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765315661; cv=none; b=x4M7t3IOoJ3GlZwVbnuVSPv0gol0gvtlCaD10O6i+yDoaVnCR1KAhGv/umHJTwyJQL8FwDs2o52xcXv+d5ZF/R1qaBdIR35QmuWJDqC+z2X8taiXQntLaABgK+AcLoGgk+9OAxuhV7vjMq8Rm35KJ3XUxbYuWb/CzjhXA5lEyMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1765315661; c=relaxed/simple; bh=k0yzGsgcKmbM0siTdSot7osZb2iOG5fkyk1tncRESGk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rUR9ljIJJrWn7EuuGu4fJJCMH8fpXS5Btt39VgeK5VNfW3d2618/12hdq3vCM956gMfry9D7uSBf7TmZlQ2QVt6SmDu3wg9SLuY1I4A5tNqvh/2L9m33u6QepURwd/Sxtrj8KJHmj116m4VEwSRTu7acJq6KpHzd/1JrZdAfxHo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96E544BA540C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1765315661; bh=k0yzGsgcKmbM0siTdSot7osZb2iOG5fkyk1tncRESGk=; h=Date:Subject:To:References:From:In-Reply-To:From; b=A3ZaXE89NN3xgRHStIh0avVzfogOgFnaUYLV91+pqfvck7sYOuWz4zgjtSCK5WjuJ N33GaYFT2p0AaYkqPLUoqmV+TaEcyuEGcn6beNDt5zk0fabuHJc7boiwbhrXA3ytw5 ea54P6aQcl9MHNE6qf3BKn2Z9nUUr1UoXYkuZCxA= Received: by simark.ca (Postfix) id 23EDE1E08D; Tue, 09 Dec 2025 16:27:41 -0500 (EST) Message-ID: Date: Tue, 9 Dec 2025 16:27:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/44] gdb, gdbserver, gdbsupport: add 'device' tag to XML target description To: Tankut Baris Aktemur , gdb-patches@sourceware.org, Markus Metzger References: <20250801-upstream-intelgt-mvp-v3-0-59ce0f87075b@intel.com> <20250801-upstream-intelgt-mvp-v3-5-59ce0f87075b@intel.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20250801-upstream-intelgt-mvp-v3-5-59ce0f87075b@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/1/25 5:37 AM, Tankut Baris Aktemur wrote: > From: Nils-Christian Kempke > > Add tag to the XML target description. The tag is a list of > device attributes. The extension enables passing device information > within the target description XML sent from gdbserver to gdb. The dtd change allows a single in the target description. When (and if) you do multi-device debugging, you connect one inferior per device? >From the ROCm perspective: if we ever want to support remote debugging (no concrete plans, but we want to keep the door open to it in the design) and we end up using this attribute, I suppose we'll want to be able to use multiple tags, since we do everything in a single inferior. If so, it would be easier to support that possibility from the start. I think that the concept of "device" here corresponds to the concept of "agent" on our side: https://rocm.docs.amd.com/projects/ROCdbgapi/en/latest/doxygen/html/group__agent__group.html I don't think the naming in the remote protocol matters that much, as long as it's clear and consistent (and the right concepts are present). I don't have comments on the code itself, seems fine to me. Simon