From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SXqyK6vWfGqbNiEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 16:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1786566315; bh=AA255Rf4+Sx/svIEjSRcrDZjunQz1dWY3PJBxKY8+Ro=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IozWGJQKg5XtyfN86BYVt9AnbezoONqWDnFk2mZLinNljSNEazkjyHfql8KegWK9Q ThVw05OO1kkG86Mc/5eKZKKMivKHGjwRNeA6GoJfCRfp9DmWqCubPN2YJ9/UaA0Bya bhDqITfIJ6Ukd60nMBwNGxYnMWSJQ6Vewy9JZ+L0= Received: by simark.ca (Postfix, from userid 112) id AEB341E166; Wed, 12 Aug 2026 16:25:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=fauUSP8x; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2D7121E09B for ; Wed, 12 Aug 2026 16:25:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DB374BB3B80 for ; Wed, 12 Aug 2026 20:25:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DB374BB3B80 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=fauUSP8x Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D4A9A4BB24EB for ; Wed, 12 Aug 2026 20:24:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4A9A4BB24EB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4A9A4BB24EB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786566288; cv=none; b=XUCEgSc09yFeTHYjW2UDJUsjMHtcEz/foLBsLGsr6SidJt8b1SbH27QpRQOS8hZROh6bZIPX5HmwHXCUE0RvqYxOPTK3IWpsT6uL88Y1lJEEelWRpaRk/UiOlPq9sy9o3E/vzrGctukqcEQOsNl5uM1X/xMuP1U3GC0hISrl2qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786566288; c=relaxed/simple; bh=AA255Rf4+Sx/svIEjSRcrDZjunQz1dWY3PJBxKY8+Ro=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=pC3/tWDPkbPdvDgLI4O5gcK554BA+lIRIKwfBRh+IAGg1BwrbdJXQvqlTL1PUo09Jlj2FT+MLZCWtjqtKUPMkRgCAjdC/m8L5WYNsPWiC4ku3PQqaMlKIBQxRJpt9H/UoKYeQgljHDYWwj7VvlLE685Tlm/kOI9LwwDOFqDzIy8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=fauUSP8x DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4A9A4BB24EB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1786566288; bh=AA255Rf4+Sx/svIEjSRcrDZjunQz1dWY3PJBxKY8+Ro=; h=Date:Subject:To:References:From:In-Reply-To:From; b=fauUSP8xPpEQ21nC914u+RMbo7cEA64v1MJAVSYfdq7GvXLmyo4XLouSENbTmupdW x4wdPm1F3GSmapyiVyR1TxwMfs/R5KeHqErLK+hHEp/tu/qtLbwc4k+GHRQvW5Cqc9 vqTebvsncgnvJiKIRbBNSR48/IWUHHL7YIpKyvg4= Received: by simark.ca (Postfix) id F11921E09B; Wed, 12 Aug 2026 16:24:47 -0400 (EDT) Message-ID: Date: Wed, 12 Aug 2026 16:24:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix double apropos output when both alias name and command name match the pattern To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20260531163756.781643-1-philippe.waroquiers@skynet.be> <20260531163756.781643-2-philippe.waroquiers@skynet.be> Content-Language: fr From: Simon Marchi In-Reply-To: <20260531163756.781643-2-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/31/26 12:37 PM, Philippe Waroquiers wrote: > diff --git a/gdb/testsuite/gdb.base/help.exp b/gdb/testsuite/gdb.base/help.exp > index a8c55721ef2..6a88c8d4db2 100644 > --- a/gdb/testsuite/gdb.base/help.exp > +++ b/gdb/testsuite/gdb.base/help.exp > @@ -135,6 +135,14 @@ gdb_test_no_output "alias mybt10 = backtrace 10" "define mybt10 alias" > gdb_test "apropos Print backtrace of all stack frames, or innermost COUNT frames\." \ > "backtrace, mybt10, mybt, where, bt -- Print backtrace of all stack frames, or innermost COUNT frames\.\[\r\n\]+ alias mybt10 = backtrace 10" > > +# Test apropos when both the alias name and the aliased command match the pattern. > +gdb_test_no_output "alias ter-exec = interpreter-exec" "define ter-exec alias" > +gdb_test_multiple "apropos er-exe" "check we have a single output line when alias and command name match" { > + -re "^apropos er-exe\r\ninterpreter-exec, ter-exec -- Execute a command in an interpreter\.\r\n$gdb_prompt $" { > + pass $gdb_test_name > + } Is there a reason why you can't use gdb_test here? With an unpatched gdb, we get the bug with "backtrace": (gdb) apropos backtrace ... backtrace, where, bt -- Print backtrace of all stack frames, or innermost COUNT frames. backtrace, where, bt -- Print backtrace of all stack frames, or innermost COUNT frames. ... You could perhaps add a test using the backtrace command as well? In any case: Approved-By: Simon Marchi Simon