From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sE9QLVUtUmVmhAUAWB0awg (envelope-from ) for ; Mon, 13 Nov 2023 09:06:13 -0500 Received: by simark.ca (Postfix, from userid 112) id B63B41E0C1; Mon, 13 Nov 2023 09:06:13 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A93BD1E091 for ; Mon, 13 Nov 2023 09:06:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 432BB383BCD2 for ; Mon, 13 Nov 2023 14:06:11 +0000 (GMT) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 27A8A38582B7 for ; Mon, 13 Nov 2023 14:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27A8A38582B7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27A8A38582B7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884360; cv=none; b=hP7/F45BsDFAuO7QY1CheR6lJ2YfDqrtwDLcNBoMeUknihD5WL4Kpy8SLclLQKrKf6y14dho1/jq/y1GjCo2Or4JzieCLxekJdv1IE3JpREn0h9rP/B1Q/uztP1gliyEaQG8rl1BrkqdkI5yYPvn8/avOc8vKJmJT7QSmCBPt4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884360; c=relaxed/simple; bh=VhABdvb+PAPWJBTTPHPrBCmF5iAElD1KjPXiSBMKzfc=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=JX+EkkcgM+9S9sZhAS+iOGK49FYpiLI0WA218kG2cdtfc8NTynof+5smj9KzZlTndBTP5MjZMFVPmOwRcPRIptlqjwiuk810QEboEfk4zEU+D02X4NU2gWEOpvseeolSA6yEH2R1YUtW5RvT6S66IeQYynwRJqnS404kFOUouU8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40790b0a224so35263265e9.0 for ; Mon, 13 Nov 2023 06:05:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884355; x=1700489155; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+qZWFY8YhcVB6aea6KfGOXTOUsskW0zE0falugrRi6c=; b=wQEkNbX/roPn+WxGtN1jMdKP2bGDHI3g5UqHrQyO/c3pKaaW3cnzmQscB27T/GwKmD ZHto3/fDCoCiWo2ag5HahWAV/YkT6Kq7iCVxWtfg7UE/lC19EUIOIV4qVE2Y/POyUHqv qr3rpowclRByXmnhLnKmEuJ55iFUoD3qvZiHPbPcZT72lET5FJ393AqE60gDTe42AelZ axmJYBHEK/+BP3PRWb1pSavcCgD9tqZXHuUM67YDOAnVt+9wuBM5gElQ6kSkZZlBoUqo QmISS4QwV6rzSiaFzOOeWYmFJsGpEZdpFIqpOcCXZegXaIizU0gtbG0B+G2umjezAmcb igOg== X-Gm-Message-State: AOJu0YxQszrkWjZCii95q+o65U29m4NafQZ77IkceYvtagXvh0R6RM4s mZo9JwVnBCR49j8bhmtTd0SCR+iV4JQ= X-Google-Smtp-Source: AGHT+IGMiSR+uJsCB3SIjBsldt1V7Gkyv90j7v9gzuWJeetSLli9KrQR0fapEsDqKxb7fBnT3uMxqA== X-Received: by 2002:a05:6000:18ae:b0:32f:78dc:ecd7 with SMTP id b14-20020a05600018ae00b0032f78dcecd7mr4633733wri.48.1699884353712; Mon, 13 Nov 2023 06:05:53 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id w7-20020adff9c7000000b0032fbd0c7d04sm5525593wrr.55.2023.11.13.06.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:05:53 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:05:52 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/31] Support clone events in the remote protocol Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-6-pedro@palves.net> <87cz50dc1y.fsf@redhat.com> From: Pedro Alves In-Reply-To: <87cz50dc1y.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2023-03-22 15:46, Andrew Burgess wrote: > Pedro Alves writes: >> @@ -2579,9 +2580,10 @@ remote_target::remote_add_thread (ptid_t ptid, bool running, bool executing, >> else >> thread = add_thread (this, ptid); >> >> - /* We start by assuming threads are resumed. That state then gets updated >> - when we process a matching stop reply. */ >> - get_remote_thread_info (thread)->set_resumed (); >> + /* We start by assuming threads are resumed. That state then gets >> + updated when we process a matching stop reply. */ > > If feels like that comment is now out of date. We surely aren't > assuming anything anymore, rather marking the thread as resumed when its > executing. > > Otherwise, this commit looks good. > You're right. I removed the comment. Tweaking the comment would just end up with the comment duplicating what the code is doing in words. > Reviewed-By: Andrew Burgess Thanks!