From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5475 invoked by alias); 8 Jul 2018 16:37:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5456 invoked by uid 89); 8 Jul 2018 16:37:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:503, letter X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:37:40 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 20BF71E059; Sun, 8 Jul 2018 12:37:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531067859; bh=i7A/PhYlRW+LRun7DfNZBFA1Ingf0DVuc1C2HRa9u70=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=mcyzqhBXlP/VO05/hJFZ+pkORjh2sma5A15tz45/H7IRmjovRR87vV6ecfEhzZwMi KKcu1x7wOdUX6b8IdDM4OPC05iWyZwQZkQczP5xzsV7V27RnujIyMfmWm4PZ3tDMlt QIbMox42ZPff1KD2EgULtLcB+amwmNb2Sw7De084= Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com> <87a7r1662j.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 08 Jul 2018 16:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87a7r1662j.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00190.txt.bz2 On 2018-07-08 12:33 PM, Tom Tromey wrote: > All the data members are private by the end of the series, but I didn't > generally try to do that at each step along the way. This is one of > those compromises I mentioned in the cover letter -- where a bigger > reordering of the series might have yielded a prettier series, but > didn't seem worth the effort. Ok, no problem then. You can ignore other similar comments I've already sent. Simon