From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96919 invoked by alias); 21 Jun 2017 10:11:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93776 invoked by uid 89); 21 Jun 2017 10:10:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1347 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 10:10:55 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F40E23D956; Wed, 21 Jun 2017 10:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F40E23D956 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F40E23D956 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C68761F4C; Wed, 21 Jun 2017 10:10:52 +0000 (UTC) Subject: Re: [PATCH v2] gdb: ADI support To: Yao Qi , Wei-min Pan References: <1497655802-111684-1-git-send-email-weimin.pan@oracle.com> <86o9ti4wa1.fsf@gmail.com> <59496067.5040008@oracle.com> <86d19xhdv0.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 21 Jun 2017 10:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86d19xhdv0.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00587.txt.bz2 On 06/21/2017 10:46 AM, Yao Qi wrote: > Wei-min Pan writes: > > >>> >>> You can't access /proc in *-tdep.c file, because it is also compiled for >>> cross-debugger. The rule in general is to move it to sparc64-linux-nat.c. >>> >> It's nice to know. Will look into it. BTW is there any document that >> specifies/defines these rules for >> *-tdep.c and *-nat.c files? > > I was puzzled by this for several years when I started on GDB :) The > most relevant one is > https://sourceware.org/gdb/wiki/Internals%20Native-Debugging In short, > anything required in native debugging (gdb and program are running on > the same machine) should be put in *-nat.c. The rest of things related > to this arch should be put into *-tdep.c. Note some ports have > *-linux-nat.c and *-linux-tdep.c, the former is about anything required > in Linux native debugging (gdb and the program is running on the same Linux > machine), while the latter is about debugging a program running on Linux > of that arch. > There's also: https://sourceware.org/gdb/wiki/Internals/Source%20Tree%20Structure I've extended the tdep section a bit now, and added something about unit tests too, while at it: https://sourceware.org/gdb/wiki/Internals/Source%20Tree%20Structure?action=diff&rev1=7&rev2=8 Thanks, Pedro Alves