From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OFZnLc73CmhgRwQAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 22:47:42 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=mMen4BrH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B6B911E0C3; Thu, 24 Apr 2025 22:47:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C40F1E089 for ; Thu, 24 Apr 2025 22:47:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC1F93858C42 for ; Fri, 25 Apr 2025 02:47:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC1F93858C42 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=mMen4BrH Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id B88AB3858D21 for ; Fri, 25 Apr 2025 02:47:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B88AB3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B88AB3858D21 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1745549227; cv=pass; b=bn6sH4be2nrs2Wul6Ub1/0tKf/mGy+OQ2UoJWYQ+l3RdcL/ckJCn7YktfFDINjWROFufeU/S/IftOxdBhx7iWo/v+5KDm1RpbHqOqBBGthjofY6+R/zeVVu0Ok9WTdl/egEaLpFnwYsq2ZqC33V4JTyPnx6eS4mDcKoWUo3jxLg= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1745549227; c=relaxed/simple; bh=x+kBR8pQQMmUs3Hm0zZj1bFiadHxYxfiTDs+5aSl3sE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=K/LD9ZRQTQaDRmLGmE/a1g0TmxOldlYruSD1GQ0vTzRX3POaaGQScFUrwD3r+Au3/9AUM7pY6lycGHGMsI8Zvl/Hnqwe0sGJAa9WzeAqapABLbMdT3ccwTINYhOdm418IMFXOLxqmTRhu40FAECP31zwIqNiFQd/bPHHZPAtC+4= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B88AB3858D21 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wsYt3qIcjFnVRKx3u2MyLX3oTJvdCoZr6rZSJzE9YiqnpNYwUU5mcMiAKkN/KXmZwGlB5Rf0Nt6nztIy43SAW35aEaUibhjXKkEeEwXKyl2sKkz2e9BcAovErqqQyaNmNzcRFlRJ43P5+zUHhoxfKjK4EjktTF0oLZZI2Iufeg4bA2RyzephqujT2+Yk9EePIok2znJfZ3Xqc7uCzLuRGUJiMGmw9dGKp9kvkP3wwmU7UCl/Z5Cygd8BUgssNQfrgzB8sIPuBTCwI0Ux+8wRfdGtH4cfS/yY2jajQ7db4H3jUqUflujK+L3zXNLhRXTn+0xf76EgzpoJGQDGlPwbww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wAgYrYkmXbG6zAxwsNmnE0/u059xqwySxizciN3vIbI=; b=E7PZbKB5Wtk5iEK61u70do9UDWgKAKnB4TaOEzsQJp8tXRRUhkmdQYBRLTD4uQ21lMIWM1h3zdv9QP7tDphQpyHkiDXdxlX35aqrMeTu98aufBPySXyIlre2Lw14Jn7KTJCnpBPF86FsGR/R3pb6lAXC7APzsJHu3sN+f00qbX8umGyV4xzxOLS+/Ua9NjNFX/0YN8jL/bhhYf+ADNGHFCop1+b8VM7VkJ3LZO6iySal3zK5dddE6KsFIsbSm8q/VwOkX2zSPTU7M0ja/Dm7EilKM3kNQWl/x8eVl26DpT9Gv1ANmCJdcLl6dndzPYHuUm0m6feD0IsKTupzJI+u+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAgYrYkmXbG6zAxwsNmnE0/u059xqwySxizciN3vIbI=; b=mMen4BrH5Tz8vlh/nrKQs0506peYAZiw5HZ2L77pMNC2t3fvPDGhzSo00jz2vF1Ni0vI+cLMSZ+NiRXDDNMUFmei5Z6GCaS3DMCvRVsZUBUEI5hUH07P3U0bRIA4rRcEj5OFXk51vo0/aVD/ndRq8EDFjmJu8dDNkxIPkmMwu83Gi00g+yfrNPhpzwLS9ela4Oi6F6Rn9lkcwKigAD6/vQkeSYQSr6MfyuMB4Fl92KdD7bXHKMmchlEZRckpRllf/QY6SO4xzYqR7OUdU1IPwxnp9TYTiohmlBRsbRzMw4cDaF1x+NAzOcnHfAsiUpVTJZNLSCp/s72+VJakpxF7iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::517) by YT1PR01MB8826.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.23; Fri, 25 Apr 2025 02:46:59 +0000 Received: from YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM ([fe80::691c:6ba8:4bb0:d9d]) by YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM ([fe80::691c:6ba8:4bb0:d9d%4]) with mapi id 15.20.8678.025; Fri, 25 Apr 2025 02:46:58 +0000 Message-ID: Date: Thu, 24 Apr 2025 22:46:57 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: add dwarf2_cu::find_die method To: Kevin Buettner , simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org References: <20250424203604.2351201-1-simon.marchi@polymtl.ca> <20250424144239.1499ceeb@f41-zbm-amd> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250424144239.1499ceeb@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0071.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:1::48) To YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::517) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PPF2C4930805:EE_|YT1PR01MB8826:EE_ X-MS-Office365-Filtering-Correlation-Id: 70bcce88-97e0-4f85-55aa-08dd83a372c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cEE4ZkpVYTdtKy9wVlFEVlZmYjA0R2s4OFcvSysvSmlVWFEvR0I3RFlKRmNC?= =?utf-8?B?NkQrUW1zK1FCL2V2MlMvZjNwekRIUXFWRnZPZWhITTVmY21taGhMdE5DMDFW?= =?utf-8?B?RkRXZ2dvUGFRN09INGxFOVdJYm9Ub1RmVkNwakV0TmNyQmt2VDFCOXlJblpy?= =?utf-8?B?THFnOHkvSkRwSVhQRkgxa3cxaENIcVhhVzVLYWt0MThmVjlDdDZZQzBnYWRp?= =?utf-8?B?SVJLOEJQOElTcjJrODkzSXVzZThtMzNaM1FnZVJlZ3RqTmF6SEg1eDRBa2JS?= =?utf-8?B?K1BDdXhid0UxNWlGVmlaQ1hkZmFFSUpmbTA5QlFsanhOU3JCSWd3bDcvZkhs?= =?utf-8?B?bjN3SXI2MnlaMnkxUXdKY3pSVVpiS2h0MHRLY3lka3o2YVlVajdYc2RoVm9J?= =?utf-8?B?OFBETTM5SEZwMUpBYUtvNks4ZzNhejBiSzVMOHE3TXVtUXBvdVI3UzlmM3Qx?= =?utf-8?B?d3lJTHk1enRGZFhzL0N2UFhtZGhJaHc4aDM5UnhjWmV0ZXZyamR1VFpDMzFq?= =?utf-8?B?cnAwdzlEajh5QitYVk1PbENqMW96TEdDek5PQzhUZmhJWFdhOEI4Tk14ZkUv?= =?utf-8?B?Y1ZOblVIVjIvUUVCQ3RVeCs3ZUFwYUYxZXFOd2VKTm9FZ2lBeUVROWxzWGFO?= =?utf-8?B?ckJCTEtpNWg3cVBmS2p3V056U3NjUEJiWmJSeDJYSVB3OEZ5TjlnQjZYejBn?= =?utf-8?B?ZlArSitleHJjUHpZUDdOTFRqR2tvWHBRak94VUVRTGtneWFMMlRobWJJL1pq?= =?utf-8?B?NDFRUXUvbTQ1aUgyWnh5MmMyWmFVQWpucU0rK1loaUthQkJqNTJiTkNsOFFE?= =?utf-8?B?VktpNlhMNTkrZ2hTeHNRc0l0OTl2bXlGU2hjSW1HS1o0TnZkN3lwNXJVSFh3?= =?utf-8?B?a1Z3YXVnOHNtcmhOQzFYTmg4N1BqVHNBRzV0ejNhdnZvRmxGcXJlRGJPVlFG?= =?utf-8?B?SGRPeURGbEpqWURmak5rNlpXaGRtZzdUaXhyWVNVa1dybHpURE82SFlIRkds?= =?utf-8?B?RUNLNzQ1eHJMU0VsczBrUVpueXhRc3o0U21CN25raWdjanN2RXg4SG5ZeEZK?= =?utf-8?B?M2xyNHNqMjFrRzkvYmo5djg5UUlkYzkzWHRaL0JwSlhIU1lEZUlRYi9wR0Ji?= =?utf-8?B?TkFmdHI3cmdXYUtnMkt4aXRsV3Y3RlgrMjI5YitTYWlMc2NGNGZYWUhycm1v?= =?utf-8?B?QVJtQUVLVmFqSFYwMmhxelNzV2V0UXhXSWJNTjFqNlVBellzT3NjeXVNUzd1?= =?utf-8?B?d1M1NktNUHhBL2IwaU8xUHVsdXY0SXpYZFFmZXNqbjZCN0pyRXVPbkRaaGFK?= =?utf-8?B?cUNZTHcybGUyNnpkSGZjRXpYUjFYNjFROGkxUzBmcENGclNmT0w1MS9TRDJT?= =?utf-8?B?U2oyMkpyTmpIOUxLKzNCdnNSNXNLWmNreFlsc29oSGkwclRXRG90RnloVzQ3?= =?utf-8?B?aGczekY5eE1LMDVNMjBzZmU0ZlpkbVFvTzFPd3BQWHJZdEM1OGdYYW5iMnB3?= =?utf-8?B?SXllcENVZVJ0UUp1bmJ3Z3daSVdPUjlYbUdlaGpYVUpmQS8rUFZubHZwR0Nm?= =?utf-8?B?ZStqcXkzTlVNM3VydHFhTFhJNEpscGQ3Q3plajlGdmFDSGlEbmpDYTIyd3ds?= =?utf-8?B?ZG5WSitqaDMxNGhtSks5TDBpQnlZOWd6ZjhkUnl1ZHZtdWY3cHJiemhOOFFj?= =?utf-8?B?U3FuQ0ZJUjZGK29iZ1FGQVNyM2lUa2tic1dVbGsvcTh5cFBveDNHdHIrbHNo?= =?utf-8?B?YWsxSU1Sd2JDeUttdExXb05YMHRTSmVreFQwUnJzTjJMa3U2V3hZaTNTaXJa?= =?utf-8?B?Nk5xSTBudTIrU2x0VTF5V29OMndWdm9ZSS9ManZyOU82R0xqcEZkcWV0TmJy?= =?utf-8?B?Nnh2Yk9Jck9kTDlJaGM0NytkclZ4STNEOTdCNy9QSUNteXh0RkFiTnVoREUr?= =?utf-8?Q?xrHOLdP+MK8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJvdURJQjZCUXJpQ3ZXY1NFMzhoSmltSWdEOVhtWGNoTVpUUGcwWFJpRmYv?= =?utf-8?B?NnB3Q3M0c2tJcFdPSDFJa0oxbEl6aDVuUURwM3k0dEpVZXBEeVhXNFNsaURZ?= =?utf-8?B?dEptODFPQzFxb0xLWmFocGRIVGlaRHdpQk1nd2grYjNTSG1HblBBdUhBTW9t?= =?utf-8?B?TSs3bGxtajhFdkU2aXZ5ZWJBWjBBQ09NbjJVN2cvbENodDlNNEJ3SmtETzFZ?= =?utf-8?B?RTkwN0tHc2w4dHoyK3dMdkJWNzRZTm9qWUJKU0JvTVkvY0NFMXoyMmcrbk84?= =?utf-8?B?UDZpdVVlRm40U01IZ0t3VTc0YjVPcmFWM2dhYmlCV1JFMEJiMkd5K3d6TWxk?= =?utf-8?B?ckRuSnQzaERBYUhaeDZCSUxFT1MyNnQzSS9OSkRyd0hpWGsrOXNsK3VOYjFm?= =?utf-8?B?SkRxN0ZWNmtCMS9NektOOEFOMmZDVDZpTVVFYkpMbDZMekZ6NlU0Y2tEN2NW?= =?utf-8?B?SVZUMDIvM0x5NkRIZlluOWRIbmtIcVlvWjJLa1c2V2dMRlVEZkU2VWFheERS?= =?utf-8?B?OHZlZ21vb3E4SExuMW5rZlFacEhSMjlWRk1oeHFRYkUxVy83NXhIdnNqRVk0?= =?utf-8?B?NzRLZk5ub0dKUTJmc1MwS3BGMUdqUVdmL3RySVVmZC9sbzZCblkvUkR6dWNr?= =?utf-8?B?ZzdnYTJ5bGNxME4xZEFLZ2gwUkYrcVEyMGl5R3VNTThiUlVTL0t1TFVaNmIw?= =?utf-8?B?SDUvbk1rNjVmYkdYSkc4dDU3Z1BtdUYxVmlCT3BycWd3aHNEdU9xQUh4ejNC?= =?utf-8?B?UTRGVitqVHg2Y3BEbjAybHpJYUc4cnFUYmlmNzl5VWgxMDNiZGVIMWpNWGh5?= =?utf-8?B?VFFIWVV3L2E1SWZsMGJYQ21zSmNhUGt5Mnh2VU9XNjUxdWQvZjYwSXQ1dTNz?= =?utf-8?B?SkkyTXdTeTVBN0NIeVNUUjVHci8vUFBzUDVYdUYvWEhhdG8wNlRpS3RMWGE5?= =?utf-8?B?UzZOSmlBOHZGLzVBWkQzMzVKR1VmUjNPOWFMUTlZMnRTdHF0bXREK0c1OXRk?= =?utf-8?B?dXNhdVNXT0k4Nms5MHBqLzFKRTBVMlpzTmhEdzNULzR2TUpraE9PeXNoZWMw?= =?utf-8?B?cWVrUjlvZEpVY1NJZzJldS9BWWdESlU0NnAvay94RnJETDNsbmljSnAvVUpt?= =?utf-8?B?L1JpaW1sdzFWc0c1VUVyZGp4RjJ6VkhQS09aYnpQbWJqVmxFWklzWHRhT3hN?= =?utf-8?B?b0x1UkF5NktteU5saFZIZ1g0OGNaNVVOb1hCQ0pxTEtCMGVJNGE1MFVGSC9H?= =?utf-8?B?eUhYYmVvMm1jck1kSG50djlvb05VSVZSMXpiaUJtd29xU1k1OUhtTFBpNWhl?= =?utf-8?B?OGF6Q3FHSVdXZGNCL0VyeW9rUEI2MGIvemY3UlhCbDBlUnJUVXFPNWRxZ3k0?= =?utf-8?B?Wmd4Q2Q3UktFaU45b21vVHBkZDNKaFpJbncwNmpOTSs4Z0xzbDEyZXM3SWdC?= =?utf-8?B?TVp1R0FrV1BmaUsray8zYm1WLzgzQ2tIMGtPZlpsWmFoZFErSDdhOGxyb1M0?= =?utf-8?B?bEp4b2EyeHhDOWJzbzBOdEVjMkF2M1dzcjYyNVpOSVhKVStQKzA4K2dxNDNZ?= =?utf-8?B?cWVNNloyT0hQVU1OOVNOblVoaEY0WlhvbGljaUJBekU2Qmo3WFRvNzRPSVBu?= =?utf-8?B?d21wcEd5WUt5U0lOSW9Famx3K3lUKy9XSTJxYm82cGhUZGladEYxMDN3Z3ph?= =?utf-8?B?MkVnT3A4TS9aM3JWbmJ2aFRRNEpieTVhc0VkR2pBUVp3SmdvRGNLajRvOUNl?= =?utf-8?B?L2FBd2tGaXRqcWhLWExUZmVpaFRpR2Z3MU9nZy9ISjhqZmlMTHUyNkVoUHVz?= =?utf-8?B?RnhsQk5JK1NPcG9sZVBJNTNBVHE4clEvWUpkZStJMHdQQ0p4SnNiRXJJSUlH?= =?utf-8?B?NGRkTHlUUTFBU3A3MWdpSEhwbXdPR3F5TFlJcUVOOG8rdVFJTkFRTGc0dFdQ?= =?utf-8?B?bDlQdnZVZUZNdlR4aEFOa0pnY2tWeFhaZTFXYzdyOGt4SEUxU050d0xueGRO?= =?utf-8?B?aFdtQVI4MlB4bDVHejNxNjYxMTVNdERSVXdjdVRkK1FEWWtVUmxteklSaERU?= =?utf-8?B?dm5vMi8rWGlPSEQzOGFiYmoxKy9CcHFrZisxVStUTnpLZkxDQkN1UHNwQU1h?= =?utf-8?Q?aL4e/8q7/k/oK52ShuPqJReJD?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70bcce88-97e0-4f85-55aa-08dd83a372c4 X-MS-Exchange-CrossTenant-AuthSource: YT1PPF2C4930805.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2025 02:46:58.7032 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aC9O/FOTng65jNyzQYT0ocn3quQd1U6flX4kLmasyBgYq+tFegokJwcjQFp9lZzPn2y7g6cvFlNDgutrEMbrLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8826 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-04-24 17:42, Kevin Buettner wrote: > On Thu, 24 Apr 2025 16:36:02 -0400 > simon.marchi@polymtl.ca wrote: > >> I added this small helper method in the series I'm writing, to make >> finding a DIE by section offset a bit nicer than using the unordered_set >> methods. It doesn't have any dependencies, so I thought I would submit >> it on its own. > > LGTM. > > Approved-by: Kevin Buettner > Thanks, pushed. Simon