From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ItpnJ9qTFWTSIBMAWB0awg (envelope-from ) for ; Sat, 18 Mar 2023 06:35:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 91C751E223; Sat, 18 Mar 2023 06:35:06 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mJdHTyda; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 310B81E110 for ; Sat, 18 Mar 2023 06:35:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 749623850872 for ; Sat, 18 Mar 2023 10:35:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 749623850872 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679135705; bh=v2T8+5slwZfWT5onKuBZeNQybRn8bzStOrdJQTj+YtQ=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mJdHTydamcUNTW0nOnhQQUspbJm50X7c8Ct6wvBRc+E9+jOIp26zpXKE4av3lOuUr aYJNR/5kltgTTqTd/4h+96TpA5g7WfwaTyZEsKdv2QDcDQIEgJPvcPB51k0bKam4fj YjQZg9mUBgpQHCrCGIYmO6maXH48u05qiuIJYDpU= Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id CDFF83858C50 for ; Sat, 18 Mar 2023 10:34:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDFF83858C50 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D258E1FE53; Sat, 18 Mar 2023 10:34:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BBF7513443; Sat, 18 Mar 2023 10:34:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Z8ejLMSTFWQnbwAAMHmgww (envelope-from ); Sat, 18 Mar 2023 10:34:44 +0000 Message-ID: Date: Sat, 18 Mar 2023 11:34:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [pushed] [gdb/testsuite] Handle attributes.h for remote host Content-Language: en-US To: Andreas Schwab , Tom de Vries via Gdb-patches References: <20230318091730.19754-1-tdevries@suse.de> <87lejuz7uq.fsf@igel.home> In-Reply-To: <87lejuz7uq.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 3/18/23 11:12, Andreas Schwab wrote: > On Mär 18 2023, Tom de Vries via Gdb-patches wrote: > >> +set flags {} >> +lappend flags debug > > aka set flags debug > Hi, yes, though I prefer the form I'm using, for instance because it allows me to do: ... set flags {} -lappend flags debug +#lappend flags debug ... while this: ... -set flags debug +#set flags debug ... breaks the test-case because flags is no longer set. Besides, for readability I prefer that each flag is added individually, and in the same way, so not: ... set flags {opt-a opt-b opt-c} ... and not: ... set flags opt-a lappend flags opt-b lappend flags opt-c ... but: ... set flags {} lappend flags opt-a lappend flags opt-b lappend flags opt-c ... Thanks, - Tom