From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89410 invoked by alias); 24 Feb 2020 16:00:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89277 invoked by uid 89); 24 Feb 2020 16:00:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=1600, H*MI:sk:a433aa5, H*f:sk:a433aa5, H*i:sk:a433aa5 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 16:00:04 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 22956ABCF; Mon, 24 Feb 2020 16:00:02 +0000 (UTC) Subject: Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles From: Tom de Vries To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20200215165444.32653-1-tom@tromey.com> <87y2ss5019.fsf@tromey.com> <8b11c5f6-771f-69b5-c98c-94ced592132f@simark.ca> <87r1ykn0o7.fsf@tromey.com> <87lfosmzy4.fsf@tromey.com> Message-ID: Date: Mon, 24 Feb 2020 16:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00924.txt.bz2 On 24-02-2020 14:42, Tom de Vries wrote: > On 24-02-2020 04:22, Tom Tromey wrote: >> Tom> Take a look at my branch, t/reorganize-dwarf-code-sharing-3. > > FWIW, I tried to build this earlier today and ran into a build error. [ > Sorry, don't have the specifics available right now, my laptop is tied > up building a series of commits. ] > Here it is: ... src/gdb/dwarf2/read.c:10967:41: error: macro "XOBNEWVEC" requires 3 arguments, but only 2 given line_header->file_names_size ()); ^ src/gdb/dwarf2/read.c: In member function 'void dwarf2_cu::setup_type_unit_groups(die_info*)': /data/gdb_versions/devel/src/gdb/dwarf2/read.c:10966:17: error: 'struct type_unit_group' has no member named 'symtabs' tu_group->symtabs = XOBNEWVEC (struct symtab *, ^~~~~~~ src/gdb/dwarf2/read.c:10966:27: error: 'XOBNEWVEC' was not declared in this scope tu_group->symtabs = XOBNEWVEC (struct symtab *, ^~~~~~~~~ make[1]: *** [Makefile:1600: dwarf2/read.o] Error 1 ... Thanks, - Tom