From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HjwFHvVRqGoxywwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 15:58:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789415925; bh=AIrYAQWieu9ov8KaDa/Ket1VY62oYyDsh2iaprs/JKc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vBGMy5f1sDMUq1y7ygDvLm/4WV+UYn6qozJOUO/FhNZEJDSBYKK0yEPu1WWzrQusv HTeIJMTjf07KfaMTfjfBFUUnqzfxE8Vo662wn2wj/ic7T5LlHl2GeQF5vezci0Ef+4 3NeTZ3hSNwVYFeW5xuInGozILhvx2YcqN4C1W8kw= Received: by simark.ca (Postfix, from userid 112) id 670041E06B; Mon, 14 Sep 2026 15:58:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=EydA8iD8; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A7521E051 for ; Mon, 14 Sep 2026 15:58:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0FD04B99F6E for ; Mon, 14 Sep 2026 19:58:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0FD04B99F6E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=EydA8iD8 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7817B4BA9030 for ; Mon, 14 Sep 2026 19:58:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7817B4BA9030 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7817B4BA9030 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789415901; cv=none; b=yFGMMGhT4iRoXxQI7p009sLD+FB+iRpSmf+WiljjT1MaUdwvngHdk9c4LV5wyGQKA74XAtcZYdYjh37NXT1/21q3aQYIV+2ocD++GdfIx9ThncojNIoptBKizG7YHswraWfw3JNhFEDAUyWR1WOQgC75M5WSwB7ixizrcDdWPQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789415901; c=relaxed/simple; bh=AIrYAQWieu9ov8KaDa/Ket1VY62oYyDsh2iaprs/JKc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rUqX8kwY2F5L+Pu1lFCFwoa6o1pJvz9Tw9uaYC6wn9IBaH+7b8sWaSQZoBC6fAjRytPIaUqp4UoyNUzK1VoATGReQHqaI4GVrPZm8YIAMp/H8D0bYlfAaC/xfVvn1dtQfN4+m+RU+jth5WWm+k4O2TSe+m4XRHblFGpTtJdj1Fc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=EydA8iD8 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7817B4BA9030 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789415900; bh=AIrYAQWieu9ov8KaDa/Ket1VY62oYyDsh2iaprs/JKc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EydA8iD834Hrbs34ZmIWuzXws1UERDgD8wbp6LinPpTELi22bn17k7hKBeZrMucml CkjMnutBccY8PMOVCPFrbENtdN38A1VBa+d2LWd5g+lqrqkF9vDhUmAKIl9FekCrMs mPFRpCLeMNQKFV+fhr/L4L4Wnzts/6U1Cn8vx3W0= Received: by simark.ca (Postfix) id 4ABC31E051; Mon, 14 Sep 2026 15:58:20 -0400 (EDT) Message-ID: Date: Mon, 14 Sep 2026 15:58:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] Change evpy_emit_event to accept a gdbpy_opt_borrowed_ref To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260808-python-safety-events-simple-v1-0-132aea40c801@tromey.com> <20260808-python-safety-events-simple-v1-1-132aea40c801@tromey.com> <8c6dadb8-d305-4df8-b5ac-42c15a34b734@simark.ca> <87y0d36a5u.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87y0d36a5u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/14/26 12:59 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Unrelated, but those two if could be collapsed into one with &&. > > Yeah, I normally don't care about this kind of thing. > > Simon> Also unrelated: I would change evregpy_no_listeners_p to > Simon> evregpy_has_listeners_p, because double-negative is confusing. > > Simon> I can make following patches to change those. > > Alright. > > Simon> Copying a review comment from Claude that seems important: > [...] > > Yeah. I think there's a longstanding GCC bug about not warning about > this. > > Anyway I fixed it. > > Simon> Otherwise, it also noted: > > Simon> - gdb/python/py-breakpoint.c:1309 and :1340: both calls now fit on one line. > > I don't know which lines these are but the obvious-to-me choices end up > at 81/82 characters and so can't be changed. Sorry, I shouldn't have copy pasted this comment without checking it first, my bad. I did trust it blindly because I did see some spots in the series where some lines could be unwrapped, so I assumed it was talking about this spots. For instance, the return statement in this function, although it's in patch 3, not patch 1: static gdbpy_ref<> create_continue_event_object (ptid_t ptid) { gdbpy_ref<> py_thr = py_get_event_thread (ptid); if (py_thr == nullptr) return nullptr; return create_thread_event_object (&continue_event_object_type, py_thr); } Anyway, I'll be more careful in the future. Simon