Re: [PATCH] Add a string_view version of startswith

[Pedro Alves <palves@redhat.com>]

On 10/1/19 7:44 PM, Christian Biesinger via gdb-patches wrote:

> diff --git a/gdb/gdbsupport/common-utils.h b/gdb/gdbsupport/common-utils.h
> index a5312cb0c4..c21c5e9603 100644
> --- a/gdb/gdbsupport/common-utils.h
> +++ b/gdb/gdbsupport/common-utils.h
> @@ -23,6 +23,7 @@
>  #include <string>
>  #include <vector>
>  
> +#include "gdb_string_view.h"
>  #include "poison.h"
>  
>  /* If possible, define FUNCTION_NAME, a macro containing the name of
> @@ -113,12 +114,22 @@ extern char *safe_strerror (int);
>  /* Return non-zero if the start of STRING matches PATTERN, zero
>     otherwise.  */

non-zero -> true
zero -> false

>  
> -static inline int
> +static inline bool
>  startswith (const char *string, const char *pattern)
>  {
>    return strncmp (string, pattern, strlen (pattern)) == 0;
>  }
>  
> +/* Version of startswith that takes string_view arguments.  See comment
> +   above.  */
> +
> +static inline bool
> +startswith (gdb::string_view string, gdb::string_view pattern)
> +{
> +  return string.length() >= pattern.length () &&
> +    strncmp (string.data (), pattern.data (), pattern.length ()) == 0;

&& goes on next line.  And then you need to wrap the multiline expression
with (), so that emacs auto-tab-indents the && under "string".  Like this:

  return (string.length() >= pattern.length ()
          && strncmp (string.data (), pattern.data (), pattern.length ()) == 0);

Otherwise OK.

Thanks,
Pedro Alves