From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33237 invoked by alias); 24 Jun 2019 16:05:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33228 invoked by uid 89); 24 Jun 2019 16:05:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 16:05:25 +0000 Received: by mail-wm1-f67.google.com with SMTP id v19so13929988wmj.5 for ; Mon, 24 Jun 2019 09:05:25 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a7sm11608356wrs.94.2019.06.24.09.05.22 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 09:05:22 -0700 (PDT) Subject: Re: [PATCH 08/66] Remove tui_list To: Ruslan Kabatsayev References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-9-tom@tromey.com> <43b9d2dc-1e03-80f0-da9e-60ea202d3db7@redhat.com> Cc: Tom Tromey , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 24 Jun 2019 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00533.txt.bz2 On 6/24/19 4:11 PM, Ruslan Kabatsayev wrote: > BTW, if you compile a declaration like "struct > std::vector source_windows;" with clang++ (with -Wall > option), you'll get a warning "struct 'vector' was previously declared > as a class [-Wmismatched-tags]", so it's better to either drop the > "struct" or change it to "class". GDB actually disables that warning explicitly, with -Wno-mismatched-tags (gdb/warning.m4). The mismatch is only important for MS's Visual Studio, since although the C++ standard says struct and class are the same, IIRC Visual Studio mangles struct vs class differently. But, AFAIK, no one ever builds GDB with Visual Studio. At least, I've not heard of anyone attempting it, though I guess it might be possible nowadays, with Visual Studio offering much better standard C++ compliance than it used to. Thanks, Pedro Alves