From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76632 invoked by alias); 8 Jul 2018 16:55:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76609 invoked by uid 89); 8 Jul 2018 16:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=internal_error X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:55:54 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 639D81E059; Sun, 8 Jul 2018 12:55:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531068953; bh=xM/1vo1s4Kg37Hss80A8kBcWUY/e2vzpUROpLJIDllk=; h=Subject:To:References:From:Date:In-Reply-To:From; b=jXYspL3l4e7ZaAfxjJ551UOfRbmjdWoldFWqVCdvoPA9506gb//yowb2cO0lUK/uW lDaT/65505rhVDw04qowVs3b8a3+su+TH2AlPphSBGhNp5K5bPfV6epuh2ZVsS+B4g 2dTMjGcS2Xo5k4U3PoZlV0NlH9SyIMx8fLBtgpMI= Subject: Re: [RFA 16/42] Use gdb_assert in two places in buildsym.c To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-17-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 08 Jul 2018 16:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-17-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00200.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > This changes buildsym.c to use gdb_assert rather than internal_error > in a couple of spots. Just a nit, but I think inverting the condition would be more readable gdb_assert (current_subfile != NULL && current_subfile->name != NULL); LGTM either way. Simon