From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FUCSI8HV52lVujAAWB0awg (envelope-from ) for ; Tue, 21 Apr 2026 15:53:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776801217; bh=RErhVpo3SvQtdiFwsOrQ1kSGM3wDwjkd+rfleClBcmc=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZGoVUtjtO0abu80nQ/4yQVLzVkjzXhI9nDhbZ974+FUCH1WYRiPQJXp21+JaXd0Yl 3KL6wd8ZxMY8C+7XzV4qv8hkKmfXypoht8iwlAPTDiP1weDl0lV+7kW/vZw2lnGaqK 0NWTACByYjQvYZJrgjNk3MKacHf8XT+TotTRMdnc= Received: by simark.ca (Postfix, from userid 112) id 818C31E0C3; Tue, 21 Apr 2026 15:53:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Yu/fb2bg; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5D331E093 for ; Tue, 21 Apr 2026 15:53:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4C14A4BA902B for ; Tue, 21 Apr 2026 19:53:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4C14A4BA902B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Yu/fb2bg Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A0C724BA902D for ; Tue, 21 Apr 2026 19:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0C724BA902D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0C724BA902D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776801190; cv=none; b=iu+z61ur6TQhanCRunyl1n71Eigv5BaDW5bqNwU1fJGBch2awOcPNFoZnrMV4Zu803QoqNsLB9+6ECU0nXVx/XrU0OlixFjZQ9uBCiIum2DYIF2T1nUSqXTiDsUzbbZELfM8vVsjhX4wOoyR6vFn/qbSfO/gVCTAcFRKJ8Gv3nQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776801190; c=relaxed/simple; bh=RErhVpo3SvQtdiFwsOrQ1kSGM3wDwjkd+rfleClBcmc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=P6wLFV4Vpf41Ft1HL443t2SFl+6bz4CAbzqKIkXVj/zbE+S/1M/rD6TzMD6zHAe+2DpLZHQTOd+vhgcrih5IqcOhU/YkvqgKSb7ywdGqgun6eEbxvEwoIRgC1ILQcWxOfuJxNfar37/9wh3IJQQ7dJD0kIBHTaSqxB12q3pKreE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0C724BA902D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776801190; bh=RErhVpo3SvQtdiFwsOrQ1kSGM3wDwjkd+rfleClBcmc=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Yu/fb2bgHDT7284+A882j9NmT2EGHCfxoUjY0mpzwt4Zx/6nYhv4m/bM4GSxfn0JZ rbV3hu2Ak5aUWHN9GdRwLCJTx7xGRqZHx/4ox/iJmOjMw+ymSCdZgboTsi7zb2y0xv OQ2wFqsZQLHzCV8eACuPhRD+/yEQ81jym8mW0YKc= Received: by simark.ca (Postfix) id 4193F1E093; Tue, 21 Apr 2026 15:53:10 -0400 (EDT) Message-ID: Date: Tue, 21 Apr 2026 15:53:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb] Remove unnecessary defs.h/common-defs.h includes To: Tom de Vries , gdb-patches@sourceware.org References: <20260421194011.1982212-1-tdevries@suse.de> From: Simon Marchi Content-Language: fr In-Reply-To: <20260421194011.1982212-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/21/26 3:40 PM, Tom de Vries wrote: > I asked an AI to review a patch that added a new file, and it mentioned I > should add an include of defs.h as first include. > > That used to be true, but since commit 18d2988e5da ("gdb, gdbserver, > gdbsupport: remove includes of early headers") that's not the case anymore. Btw, this is the kind of details that we could put in an AGENTS.md file (or similar), if it doesn't offend too many people. AIs are much more efficient if they know the conventions of the project ahead of time. Approved-By: Simon Marchi Simon