From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mmUOM+CG5mjzOSQAWB0awg (envelope-from ) for ; Wed, 08 Oct 2025 11:44:32 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nZMVr7CS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hAbOwPCN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nZMVr7CS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hAbOwPCN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C24151E047; Wed, 08 Oct 2025 11:44:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B9C571E047 for ; Wed, 08 Oct 2025 11:44:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 473AC3857356 for ; Wed, 8 Oct 2025 15:44:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 473AC3857356 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nZMVr7CS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hAbOwPCN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=nZMVr7CS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hAbOwPCN Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id F15383858D33 for ; Wed, 8 Oct 2025 15:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F15383858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F15383858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759938213; cv=none; b=N6BfwHyUhScGqORsuinrv32UvZNTUJKES+yPMviDgOEknM0XsKsVP6PyH2muwL5Blh4henJAlMXPgNrmWoc1DBnPqqM+GE4FhgOyv6GXXXRYhfsBuiFok+FdlkHhjm9EccQN/wmrRJFqm0kOs08SS0kDSNLdKzFXnJMOsN02r2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759938213; c=relaxed/simple; bh=Vbct/JDRTX13A4bBYkuMtlAVQNn7my4cSSGIXjZZX3I=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=urQvDngm/wSQM4LRp966vuMy2qXPEgAfPvUsLEpiG3V457E1+BG+uYxfomdHPyDZizlRqOg/mIUlFTJiO+f/sQrwX3leqToFPFe90Mx9DxDUdKiaoMazmElkXbVe5v7y9IhN1p5T5JnnTH3fdQg8EE8xAu5mxE8VbtA8CxFT4Qo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F15383858D33 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 78E0F1F391; Wed, 8 Oct 2025 15:43:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759938211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffe65MCLOGYMopl5pL+QB6/pFx5+qDLJwnoozxcOnjA=; b=nZMVr7CSfU5vP9UG/kVBOQFFz4l9Ybiyu4YWEi3ranTiI0AtSitFKLMmdLHWLZ+RJvE574 LQpHD2+kG6brbfLof8Kh68Mo5uuPgNhs9wEiXLoWJpAxI75KaWKmN/IXm9hKgkAFJgFXsu 5mYavwAqezkb9FL8mJVlzhLm2zENYGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759938211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffe65MCLOGYMopl5pL+QB6/pFx5+qDLJwnoozxcOnjA=; b=hAbOwPCNse0ZwnuLSXEI2ksePMeSxDa5ND8gRkt0dFPCt6vg0FLqwhcm2GFshkLJiQMfjH hkRU39QcSjuEz5Dg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=nZMVr7CS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hAbOwPCN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759938211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffe65MCLOGYMopl5pL+QB6/pFx5+qDLJwnoozxcOnjA=; b=nZMVr7CSfU5vP9UG/kVBOQFFz4l9Ybiyu4YWEi3ranTiI0AtSitFKLMmdLHWLZ+RJvE574 LQpHD2+kG6brbfLof8Kh68Mo5uuPgNhs9wEiXLoWJpAxI75KaWKmN/IXm9hKgkAFJgFXsu 5mYavwAqezkb9FL8mJVlzhLm2zENYGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759938211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ffe65MCLOGYMopl5pL+QB6/pFx5+qDLJwnoozxcOnjA=; b=hAbOwPCNse0ZwnuLSXEI2ksePMeSxDa5ND8gRkt0dFPCt6vg0FLqwhcm2GFshkLJiQMfjH hkRU39QcSjuEz5Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 562B013A3D; Wed, 8 Oct 2025 15:43:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CANLE6OG5mikAQAAD6G6ig (envelope-from ); Wed, 08 Oct 2025 15:43:31 +0000 Message-ID: Date: Wed, 8 Oct 2025 17:43:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 3/3] gdb/python: add Corefile.mapped_files method To: Andrew Burgess , Tom Tromey Cc: gdb-patches@sourceware.org References: <9ab589510f784da2752b72d0b1385afa33aca406.1758634958.git.aburgess@redhat.com> <87cy737q50.fsf@tromey.com> <87zfa26gxp.fsf@redhat.com> <87o6qi6dwn.fsf@redhat.com> <87jz166al5.fsf@redhat.com> <3996ddc9-2cb4-4ead-8895-5d6b27b5a72c@suse.de> <87bjmi65h4.fsf@redhat.com> <874is968sb.fsf@redhat.com> <871pnd5vm0.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <871pnd5vm0.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 78E0F1F391 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/8/25 16:14, Andrew Burgess wrote: > Let me know what you think. Hi Andrew, thanks, this LGTM. Please apply this as well: ... diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 5dfcfefd7c1..ef6a8f859ef 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -11635,7 +11635,7 @@ proc expect_build_id_in_core_file { filename } { } # Convert OFFSET to decimal. - set offset [expr 0x$offset + 0] + set offset [expr {[subst 0x$offset]}] # Now figure out the page size. This should be fine for Linux # hosts, see the istarget check above. @@ -11650,7 +11650,7 @@ proc expect_build_id_in_core_file { filename } { # but the default behaviour is to include the first page of the # ELF, so for now, we just assume this is on. verbose -log "Page size is $page_size, Offset is $offset" - return [expr $offset < $page_size] + return [expr {$offset < $page_size}] } # Return 1 if the compiler supports __builtin_trap, else return 0. ... to fix tclint warnings. Thanks, - Tom