Re: [PATCH] Fix inline frame unwinding breakage

Luis Machado
2020-04-23T17:51:53Z

On 4/22/20 8:22 AM, Luis Machado wrote:
> Hi Andrew,
>
> On 4/22/20 6:37 AM, Andrew Burgess wrote:
>> * Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
>> [2020-04-14 18:38:36 -0300]:
>>
>>> *** re-sending due to the poor choice of characters for the backtrace
>>> annotations. GIT swallowed parts of it.
>>>
>>> There has been some breakage for aarch64-linux, arm-linux and
>>> s390-linux in
>>> terms of inline frame unwinding. There may be other targets, but
>>> these are
>>> the ones i'm aware of.
>>>
>>> The following testcases started to show numerous failures and trigger
>>> internal
>>> errors in GDB after commit 1009d92fc621bc4d017029b90a5bfab16e17fde5,
>>> "Find tailcall frames before inline frames".
>>>
>>> gdb.opt/inline-break.exp
>>> gdb.opt/inline-cmds.exp
>>> gdb.python/py-frame-inline.exp
>>> gdb.reverse/insn-reverse.exp
>>>
>>> The internal errors were of this kind:
>>>
>>> binutils-gdb/gdb/frame.c:579: internal-error: frame_id
>>> get_frame_id(frame_info*): Assertion `fi->level == 0' failed.
>>
>> I have also started seeing this assert on RISC-V, and your patch
>> resolves this issue for me, so I'm keen to see this merged.
>
> Great.
>
>>
>> I took a look through and it all looks good to me - is there anything
>> holding this back from being merged?
>
> Not really. I was waiting for an OK before pushing it.
>
>>
>> Thanks,
>> Andrew

I've pushed this now. Tromey and Andrew OK-ed it on IRC.