From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21079 invoked by alias); 16 Jun 2019 17:22:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21070 invoked by uid 89); 16 Jun 2019 17:22:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:Sendmail, H*RU:Sendmail X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Jun 2019 17:22:40 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x5GHMWLw001427 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 16 Jun 2019 13:22:37 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x5GHMWLw001427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1560705758; bh=73oWhAYn4o+swcVeB9UjFD0rMuc/dMzieA6y3foj+pQ=; h=Subject:To:References:From:Date:In-Reply-To:From; b=cgaCUiuLLQGOiLRT6yrlqhbqNp7cGd3EZZcPhrusLkO2Z/RFL7nbbM9u4KSyZ60dK zKTee5EUX2I6ODzU+pDw7WR9FLPxfEr+CVBrBplOPLzKU+Y4v0/MUslZMAJM0V6lVn lroNvUWLtBUzWaXybKmhHjA43OX6LL4wY15mA+z8= Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 869DE1E4C2; Sun, 16 Jun 2019 13:22:31 -0400 (EDT) Subject: Re: [PING][PATCH][gdb] Write index for dwz -m file To: Tom de Vries , gdb-patches@sourceware.org References: <20190507144207.GA17626@delia> <90892dae-b6b9-6a89-7cee-bbed859c207b@polymtl.ca> <6cb63aac-2375-18ee-adaf-2bb9f7a0b355@suse.de> <4c7917b3-cdf0-0f17-ab6c-e76d891dfd3b@polymtl.ca> <0428a4a6-3ed8-17ee-0161-52ee12a4d941@suse.de> From: Simon Marchi Message-ID: Date: Sun, 16 Jun 2019 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <0428a4a6-3ed8-17ee-0161-52ee12a4d941@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00291.txt.bz2 On 2019-06-16 6:43 a.m., Tom de Vries wrote: > On 13-05-19 15:56, Simon Marchi wrote: >> On 2019-05-13 8:22 a.m., Tom de Vries wrote: >>> On 11-05-19 04:36, Simon Marchi wrote: >>>> @@ -122,12 +144,13 @@ index_cache::store (struct dwarf2_per_objfile *dwarf2_per_objfile) >>>> >>>> if (debug_index_cache) >>>> printf_unfiltered ("index cache: writing index cache for objfile %s\n", >>>> - objfile_name (obj)); >>>> + objfile_name (obj)); >>>> >>>> /* Write the index itself to the directory, using the build id as the >>>> filename. */ >>> >>> LGTM. >>> >>> [ I'm not sure if this white-space-only change should be included though. ] >>> >>> Thanks, >>> - Tom >> >> Hmm probably not, but I am tempted to leave it in, since I am touching the lines around it (and it >> fixes the wrong indentation). >> >> I will leave this patch up for review for a week or so, to give the others a chance to comment. >> > > Ping. > > Thanks, > - Tom Ah, thanks for reminding me. I don't have so much time to spend on GDB these days, so things easily get forgotten. I'll give it a last look and push it. Simon