From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mryoEMp0C2hs/QQAWB0awg (envelope-from ) for ; Fri, 25 Apr 2025 07:40:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R/7139cz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 313691E10E; Fri, 25 Apr 2025 07:40:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D3941E0C0 for ; Fri, 25 Apr 2025 07:40:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 189133857B9F for ; Fri, 25 Apr 2025 11:40:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 189133857B9F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R/7139cz Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B37013858D38 for ; Fri, 25 Apr 2025 11:40:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B37013858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B37013858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745581209; cv=none; b=eHORNC+3r3MqXSoLVDCPw3El2485uZ+mTNW6Tcomg6Wpdtx9yMLp00vH3vU+ltZy8wDvojpiLmitrG7wclpUJLSyB/hvelQtccddXoyIJORWscYDCWD5ZpSTYHrvs9osj3q4YyLlWoFrvdGhl3LAfw2O83FDffAg9A5G8YhCn7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745581209; c=relaxed/simple; bh=MV1vpzV4ISpFAVjT65z7YVMqJTJXtq91n7W0Exme+Lw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bU7CoIn6puic2TQWA6aanRMzPkr9cTz9jtd4bsez5+NfLtiNPfZDB2kyemb3AVEPd+kIozveQgHhlUNebKfNHNDwQGTFnL7TzkEQ7YdG78luMrPAWyFakxixT3erSpEXTiJ4gElGo3EIw3J4HKZQMaQri2wDmCTusyLvnyNMx3s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B37013858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745581209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pLonITDan5Y8skOuDJw5aUqbfeUSYAWwbmb6v97rii4=; b=R/7139cz/7v+9TJbjr2dgY8fmdq0m273g9fIh9PTmoxE7CuqU3Q6H76yFrr2WgNegpFiQH 31qGpf731ArUs6SmIl6cpr0rvqOcMBpszczRtHfF892qyb1Iq7d7m+a8Iq5F+Fm89LDUYp LHDTnWzAxvchZ4XyYjdGH+cVUfSB92A= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-DPe1DJx1MM2H5WPmeGmOeQ-1; Fri, 25 Apr 2025 07:40:08 -0400 X-MC-Unique: DPe1DJx1MM2H5WPmeGmOeQ-1 X-Mimecast-MFC-AGG-ID: DPe1DJx1MM2H5WPmeGmOeQ_1745581207 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2264e5b2b7cso20418415ad.2 for ; Fri, 25 Apr 2025 04:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745581207; x=1746186007; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pLonITDan5Y8skOuDJw5aUqbfeUSYAWwbmb6v97rii4=; b=MeIxeeVYdPp/e74cODsFDlcFBc34y3idFAtwLBHzylPgSIt3iFgMgTZ4DyCKACO6uO 7k9RNol7jYhIfoJWc5UeLSQ5ZFjMV5cVt2rqTbgBxb+bC4pV8TFmd25H+A+j0xxpv7zs y3WLFlP9uwfLl5AxHF/+HwL9cPtxm+dFFmZ+ao6AOePabkhPTHR+x9v+m8K3FOYgqzB4 TfsnRcQgvc1831AH7WHxPACAhSau3UfqFiYMg/WYJID6ztAMFL/ANWXCqitx89Hxqrv/ 86YBrL4uWiVDkHgYFxJawuGbXo7BtCGRwAVPAXAIsiHvlEM7TcNnP/lCOyv+FLwFA7ag 6c6Q== X-Forwarded-Encrypted: i=1; AJvYcCVcl4L3WegRpUPV37qjUtb45RpE6X2mvycni6g2MII/fE3ES/i7WDNr8vShEZPb8LQQEj7ql3hUM05eoA==@sourceware.org X-Gm-Message-State: AOJu0Yz5hutk5+6HeGSEmR8vkCOHLSiCeOX3/iwuwEosxkuYjJFGo3Pj gbbLNN0AH8Qo2Q6Q/w8QcV7TQlVskHOagBf8ouDmtf3BGfh0i11wK7D08Rly70qhkEBGjbwlLAF GHE6Hw7UUcFCaPDZrIJSPIxLDyloeaLmWHjmLiQZ9f5pSczWfkyF+VCwt8Vk= X-Gm-Gg: ASbGncttTU4cI7VEkHho2XJDZowMr3Xq7KUjzExv8AZdIhfLLUyhssYh+aDG8rSY/rL wSzt9HGmMkQBM3JN+4WySCkhHc0+sH++Sb7JGJK8Uswa3KaHXD+vWXOFvHMo2QlNnvAmgCfiP9O Lii9paywt+ugS++jGMxnAbxIdd+EGSlDm6hZgpgvzBRzlejZHTLptDCFbM4rbj9DG6saAASjFM5 0SWidMOOCR34uJ/zSJHZoiKquDzdzT9EXAvVUH+EY4KEJ0gn0vb7+90RXH9zQW8hss6wbF46y41 p6IcwLhPvazJXewurSkvUis= X-Received: by 2002:a17:902:fc50:b0:224:1781:a950 with SMTP id d9443c01a7336-22dbf5ebe7amr31908785ad.14.1745581206962; Fri, 25 Apr 2025 04:40:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGF6Rh8M+K13ZUvQ0x3ulAXDsaJgh8PynyRlybePWsy9ZZRxy807eBQ/4q65nWdL4jDs4ZbOA== X-Received: by 2002:a17:902:fc50:b0:224:1781:a950 with SMTP id d9443c01a7336-22dbf5ebe7amr31908505ad.14.1745581206597; Fri, 25 Apr 2025 04:40:06 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d76bdfsm30153855ad.31.2025.04.25.04.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 04:40:06 -0700 (PDT) Message-ID: Date: Fri, 25 Apr 2025 08:40:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix 32 bit build To: Luis Machado , gdb-patches@sourceware.org References: <20250424114743.1776473-1-guinevere@redhat.com> <4ddb13a5-00cf-48fd-ab53-39a5f837beb6@arm.com> <7c9e42f6-a28a-4730-ac5d-5407d523d6a4@arm.com> From: Guinevere Larsen In-Reply-To: <7c9e42f6-a28a-4730-ac5d-5407d523d6a4@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7EGOkiV7dmvHgMDfir9syScSLo8Me6gzsPHQk210we8_1745581207 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/25/25 8:05 AM, Luis Machado wrote: > On 4/24/25 19:50, Guinevere Larsen wrote: >> On 4/24/25 10:21 AM, Luis Machado wrote: >>> On 4/24/25 12:48, Guinevere Larsen wrote: >>>> On 4/24/25 8:47 AM, Guinevere Larsen wrote: >>>>> The recent commit dbbb9cfd3708a5b09b449c6cbc4d74dfec13904d added a >>>>> message using %ld to print an std::vector::size, which is of size_t >>>>> type. on 64 bit machines, size_t will be an unsigned long int, making >>>>> %ld work just fine, but on 32 bit ones, size_t will be unsigned int, >>>>> which causes build to fail. >>> Pedantically... >>> >>> s/build/the build >>> >>>>> This commit fixes that by using %zu instead. >>>> After sending the email I realized I forgot the bug trailer. I'll add >>>> >>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32901 >>>> >>>> locally >>>> >>>>> --- >>>>>    gdb/solib.c | 2 +- >>>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/gdb/solib.c b/gdb/solib.c >>>>> index 5c5cfbdd9b9..85ec6bb2f1e 100644 >>>>> --- a/gdb/solib.c >>>>> +++ b/gdb/solib.c >>>>> @@ -1230,7 +1230,7 @@ info_linker_namespace_command (const char *pattern, int from_tty) >>>>>          break; >>>>>        } >>>>>          uiout->message >>>>> -    (_ ("There are %ld libraries loaded in linker namespace [[%d]]\n"), >>>>> +    (_ ("There are %zu libraries loaded in linker namespace [[%d]]\n"), >>>>>         solibs_to_print.size (), ns); >>>>>          uiout->message >>>>>        (_ ("Displaying libraries for linker namespace [[%d]]:\n"), ns); >>>>> >>>>> base-commit: 8c8e5b1f1abfbce913783da0f1cd1f85c60bd445 >>> Thanks for the quick patch. This is OK. >>> >>> Tested-By: Luis Machado >>> Approved-By: Luis Machado >>> >> thanks for the quick review, I've pushed the patch! >> > Just checking, was this pushed? I noticed the bug wasn't updated. And then I > couldn't find it with git log. > Hi Luis, I was sure that this was pushed, but what happened instead was that I juggled my branches incorrectly, and instead pushed this (unapproved) patch instead: https://inbox.sourceware.org/gdb-patches/20250424120553.1783279-1-guinevere@redhat.com/T/#u I'll revert that and push this one instead. I shouldn't git when I'm that tired, it seems... -- Cheers, Guinevere Larsen She/Her/Hers