From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8481 invoked by alias); 11 Apr 2016 23:14:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8472 invoked by uid 89); 11 Apr 2016 23:14:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*UA:Roundcube, H*u:Roundcube, H*r:112, H*u:1.1.3 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 23:14:49 +0000 Received: by simark.ca (Postfix, from userid 112) id 419FF1E89F; Mon, 11 Apr 2016 19:14:47 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 85A9A1E03B; Mon, 11 Apr 2016 19:14:46 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Apr 2016 23:14:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] native-gdbserver: Clear isremote flag in board info In-Reply-To: <570C171F.7040603@redhat.com> References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <570BEF8B.70203@redhat.com> <570BF79F.2070409@ericsson.com> <570C171F.7040603@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.1.3 X-SW-Source: 2016-04/txt/msg00233.txt.bz2 On 2016-04-11 17:29, Pedro Alves wrote: > On 04/11/2016 08:14 PM, Simon Marchi wrote: >> On 16-04-11 02:40 PM, Pedro Alves wrote: >>> On 04/06/2016 04:15 AM, Simon Marchi wrote: > >>> OOC, don't we need the "global" declarations as >>> in native-extended-gdbserver.exp? >> >> Apparently not, since it works :) >> > > :-) > >> I'm not familiar enough with TCL to know that. Are we executing in >> the body >> of a procedure at this point? This file is sourced from some proc in >> DejaGnu, >> so I'd say yes, but this example may suggest otherwise. > > Hmm, that's probably search_and_load_file, which does > "uplevel #0 source ...", meaning top-level global variables are visible > in the sourced file. > >>> You're probably already thinking of doing this, but I'll state it >>> explicitly anyway: it'd be nice to move this isremote frobbing to >>> a shared .exp file, so that boards that need it can just >>> source the file. >> >> I wasn't, but it's a good idea. isremote is also handled in an >> unintuitive way, >> since the testsuite only checks if it's defined. So when you set >> isremote to 0, >> it's still considered as "true". > > Hmm, that sounds like a bug. If that were generally true, then > native-gdbserver.exp's isremote hacks in ${board}_spawn / > ${board}_exec > wouldn't work? Where are you seeing that? > > Thanks, > Pedro Alves Huh nevermind, I was thinking about use_gdb_stub.