From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 734DA386F457 for ; Fri, 15 May 2020 10:17:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 734DA386F457 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 42436AB89; Fri, 15 May 2020 10:17:56 +0000 (UTC) Subject: Re: [PATCH v8 6/6] gdb/infrun: handle already-exited threads when attempting to stop To: Pedro Alves , "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <20200513205338.14233-1-palves@redhat.com> <20200513205338.14233-7-palves@redhat.com> <0d00b418-3c5f-4a8c-12dd-eeee8ad12b6b@suse.de> <4ade3da1-a8cd-ba29-80da-f5e742f7b52a@palves.net> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Fri, 15 May 2020 12:17:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <4ade3da1-a8cd-ba29-80da-f5e742f7b52a@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-18.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 10:17:56 -0000 On 14-05-2020 20:58, Pedro Alves wrote: > On 5/14/20 7:54 PM, Aktemur, Tankut Baris wrote: >> On Thursday, May 14, 2020 8:00 PM, Tom de Vries wrote: >>> On 13-05-2020 22:53, Pedro Alves via Gdb-patches wrote: >>>> + set testpid($num) [get_integer_valueof "pid" -1] >>> >>> I'm running into: >>> ... >>> ERROR: tcl error sourcing >>> /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-kill.exp. >>> ERROR: can't set "testpid(1)": variable isn't array >>> while executing >>> "set testpid($num) [get_integer_valueof "pid" -1]" >> >> I'm not able to reproduce this problem. The test runs fine on my system >> with 58 expected passes and no failures. Could it be related to the tcl >> version? > > It's related to testcase run order, and the fact that global variables > can leak between testcases. > >> >> As a rough guess, could you try the patch below to initialize the array >> variable? >> >> diff --git a/gdb/testsuite/gdb.multi/multi-kill.exp b/gdb/testsuite/gdb.multi/multi-kill.exp >> index ce6075045fc..a21f8a78b0d 100644 >> --- a/gdb/testsuite/gdb.multi/multi-kill.exp >> +++ b/gdb/testsuite/gdb.multi/multi-kill.exp >> @@ -70,6 +70,7 @@ proc start_inferior {num} { >> # Sufficient inferiors to make sure that at least some other inferior >> # is killed while we're handling a killed event. >> set NUM_INFS 10 >> +array set testpid {} > > That's not sufficient, because the variable can leak to other tests. > For example: > > $ runtest gdb.threads/check-libthread-db.exp gdb.multi/multi-kill.exp > > Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.multi/multi-kill.exp ... > Running /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.threads/check-libthread-db.exp ... > ERROR: tcl error sourcing /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.threads/check-libthread-db.exp. > ERROR: can't set "testpid": variable is array > while executing > "set testpid [spawn_id_get_pid $test_spawn_id]" > ("uplevel" body line 8) > > This works for me. > > From 96aa00638e9a1201874e316ad53c38614da8cc04 Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Thu, 14 May 2020 19:07:35 +0100 > Subject: [PATCH] Fix global variable collision in gdb.multi/multi-kill.exp > > gdb/testsuite/ChangeLog: > 2020-05-14 Pedro Alves > > * gdb.multi/multi-kill.exp: Wrap in namespace. > (start_inferior): Add TESTPID parameter. Use it instead of the > testpid global. > (top level): Define empty TESTPID array, and pass it down to > start_inferior. > --- > gdb/testsuite/gdb.multi/multi-kill.exp | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.multi/multi-kill.exp b/gdb/testsuite/gdb.multi/multi-kill.exp > index ce6075045fc..03bf8449cf8 100644 > --- a/gdb/testsuite/gdb.multi/multi-kill.exp > +++ b/gdb/testsuite/gdb.multi/multi-kill.exp > @@ -39,11 +39,15 @@ save_vars { GDBFLAGS } { > clean_restart ${binfile} > } > > +# Wrap the entire test in a namespace to avoid contaminating other tests. > +namespace eval $testfile { > + > # Start inferior NUM and record its PID in the TESTPID array. > > -proc start_inferior {num} { > +proc start_inferior {num testpid} { > with_test_prefix "start_inferior $num" { > - global testpid binfile srcfile > + upvar $testpid tpid > + global binfile srcfile > > if {$num != 1} { > gdb_test "add-inferior" "Added inferior .*" \ > @@ -58,8 +62,8 @@ proc start_inferior {num} { > gdb_run_cmd > gdb_test "" ".*reakpoint .*, initialized .*${srcfile}.*" "run" > > - set testpid($num) [get_integer_valueof "pid" -1] > - if {$testpid($num) == -1} { > + set tpid($num) [get_integer_valueof "pid" -1] > + if {$tpid($num) == -1} { > return -1 > } > > @@ -71,8 +75,11 @@ proc start_inferior {num} { > # is killed while we're handling a killed event. > set NUM_INFS 10 > > +# The array holding each inferior's PID, indexed by inferior number. > +array set testpid {} > + Actually, we still need to declare the variable as a namespace variable using: ... variable testpid array set testpid {} ... otherwise we run into: ... ERROR: tcl error sourcing /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-kill.exp. ERROR: can't array set "testpid": variable isn't array while executing "array set testpid {}" (in namespace eval "::multi-kill" script line 36) invoked from within "namespace eval $testfile { ... Thanks, - Tom