From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EC5F93858D35 for ; Sat, 1 Aug 2020 23:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EC5F93858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 902C21EAB8; Sat, 1 Aug 2020 19:16:10 -0400 (EDT) Subject: Re: [PATCH V5 0/3] eBPF support To: "Jose E. Marchesi" , gdb-patches@sourceware.org References: <20200713122458.21339-1-jose.marchesi@oracle.com> From: Simon Marchi Message-ID: Date: Sat, 1 Aug 2020 19:16:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200713122458.21339-1-jose.marchesi@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2020 23:16:12 -0000 On 2020-07-13 8:24 a.m., Jose E. Marchesi via Gdb-patches wrote: > [Changes from V4: > - Rebased to today's master. > - Remove bpf-tdep.h. > - Clarify in bpf_frame_this_id why this_id is not set. > - Make the GDB patch independent from the sim patch. > - Indentation/style fixes. > - Copyright year fixed in sim/bpf/Makefile.in > - CGEN_MAIN -> CGEN_MAINT typo fixed in sim/bpf/Makefile.in > - Removed XXX comments from sim/bpf/Makefile.in > - Removed spurious comment from sim/bpf/sim-if.c] > > Hi good peoples! > > This patch series adds support for the eBPF virtual architecture to > GDB [1]. > > The first patch contains the basic bits to GDB in order to support the > bpf-unknown-none target. Breakpointing and instruction > single-stepping works, but the debugging support in eBPF is still very > minimal. This is mainly due to the many limitations imposed by the > architecture (disjoint stack, maximum stack size, etc). We are > working to overcome these limitations, by introducing a variant called > xbpf, already supported in GCC with the -mxbpf option, whose purpose > is to ease debugging and to be used in other contexts different than > the Linux kernel, less restrictive. > > The second patch adds a basic CGEN-based instruction simulator for > eBPF. It can run many eBPF programs and works well with GDB. A > testsuite covering the supported instructions is also included. We > will be expanding it in order to emulate the several kernel contexts > in which eBPF programs can run, so eBPF developers can use GDB to > debug their programs without having to load them in a running kernel. > Currently the only kernel helper implemented in the simulator is > printk, which is used by the tests. > > We of course commit to maintain and evolve this stuff :) > > [1] Support for eBPF has been already added to both binutils and GCC. While git-am'ing the patches, I got: Applying: gdb: support for eBPF Applying: sim: eBPF simulator Using index info to reconstruct a base tree... M sim/testsuite/configure .git/rebase-apply/patch:145: trailing whitespace. @CGEN_MAINT@CGEN_MAINT = .git/rebase-apply/patch:474: trailing whitespace. .git/rebase-apply/patch:482: trailing whitespace. { .git/rebase-apply/patch:493: trailing whitespace. .git/rebase-apply/patch:513: trailing whitespace. warning: squelched 13 whitespace errors warning: 18 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging sim/testsuite/configure Applying: sim: generated files for the eBPF simulator Can you please track and fix those? Simon