From: Michael Eager <eager@eagerm.com>
To: Pedro Alves <palves@redhat.com>,
Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [pushed] microblaze-tdep: Add ATTRIBUTE_PRINTF to microblaze_debug
Date: Mon, 25 Sep 2017 16:43:00 -0000 [thread overview]
Message-ID: <d864a1f2-758f-d0d6-2793-63adc728d27e@eagerm.com> (raw)
In-Reply-To: <441bab33-67b9-be36-e4b7-c22e6936a7bf@redhat.com>
On 09/25/2017 09:06 AM, Pedro Alves wrote:
>> but the better fix
>> seems to me to
>> be to turn off the obviously inappropriate -Wformat-nonliteral option in
>> microblaze_debug() using
>> #pragma GCC diagnostic ignored "-Wformat-nonliteral"
> That doesn't make sense to me.
The argument passed to vprintf_unformatted in microblaze_debug is not a string
literal. The diagnostic message is correct. If you don't want the diagnostic,
turning it off seems correct.
This is somewhat moot. All uses of microblaze_debug use literal string formats,
so adding ATTRIBUTE_PRINTF is OK.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2017-09-25 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 12:11 Simon Marchi
2017-09-25 14:14 ` Michael Eager
2017-09-25 16:06 ` Pedro Alves
2017-09-25 16:43 ` Michael Eager [this message]
2017-09-25 17:09 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d864a1f2-758f-d0d6-2793-63adc728d27e@eagerm.com \
--to=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox