From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47632 invoked by alias); 10 Jan 2020 21:46:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47624 invoked by uid 89); 10 Jan 2020 21:46:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 21:46:50 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9FF0B1E10B; Fri, 10 Jan 2020 16:46:48 -0500 (EST) Subject: Re: [PATCH 01/15] Add back declarations for _initialize functions To: Tom Tromey , Simon Marchi Cc: John Baldwin , gdb-patches@sourceware.org References: <20191125052655.22696-1-simon.marchi@efficios.com> <20191125052655.22696-2-simon.marchi@efficios.com> <87a76wxntd.fsf@tromey.com> <23b12f35-00ab-cf51-7aee-994652a688d1@efficios.com> <87zhevtao5.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Fri, 10 Jan 2020 21:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <87zhevtao5.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00271.txt.bz2 On 2020-01-10 1:43 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I have just uploaded it to the "missing-declarations" branch on my github: > Simon> https://github.com/simark/binutils-gdb/tree/missing-declarations > > Thanks. > > Simon> I have updated the patches slightly to account for the new unittests. So if you > Simon> try to build, you'll stumble directly on the build error that made me give up: > > I think just adding a few seemingly-redundant declarations is enough. > At least, the appended made it compile for me. > > "IP_AGENT_EXPORT_FUNC" takes care of the static/extern distinction already. Thanks, that's really not bad indeed. I've integrated your suggestion, and will send a v2 right now. Simon