From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32655 invoked by alias); 28 Feb 2020 15:19:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32644 invoked by uid 89); 28 Feb 2020 15:19:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*MI:sk:8736aun, H*i:sk:8736aun, H*f:sk:8736aun X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 15:19:00 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2B254B1EC; Fri, 28 Feb 2020 15:18:58 +0000 (UTC) Subject: Re: [PATCH][gdb] Don't set initial language using previous language To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200228063315.GA16995@delia> <8736aun46o.fsf@tromey.com> From: Tom de Vries Message-ID: Date: Fri, 28 Feb 2020 15:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <8736aun46o.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01054.txt.bz2 On 28-02-2020 16:04, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> It seems like a bad idea to have the previous language play a role > Tom> in determining the executable language. > > Does it make a difference in practice? > I don't know of a concrete case where it does. > Tom> Fix this by using lookup_symbol_in_language in set_initial_language with the > Tom> default language c as argument. > > Tom> Tested on x86_64-linux. > > Tom> OK for trunk? > > Yes, it seems fine to me. Thank you. Ack, committed. Thanks, - Tom