From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110169 invoked by alias); 27 Jun 2017 21:35:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110160 invoked by uid 89); 27 Jun 2017 21:35:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 21:35:33 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id F1FE6A483AA17; Tue, 27 Jun 2017 22:35:26 +0100 (IST) Received: from BAMAIL02.ba.imgtec.org (10.20.40.28) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 27 Jun 2017 22:35:31 +0100 Received: from [10.20.2.42] (10.20.2.42) by bamail02.ba.imgtec.org (10.20.40.28) with Microsoft SMTP Server id 14.3.266.1; Tue, 27 Jun 2017 14:35:28 -0700 Subject: Re: [PATCH] Fix PR 21337 (v4): segfault when re-reading symbols with remote debugging. To: Simon Marchi , "Maciej W. Rozycki" References: <20511c76-c816-d31d-5144-749eac9fc470@imgtec.com> <3c5ce0a0-72e5-4460-5555-ad2214866260@imgtec.com> <5c494cc147f71dd8246572aa0b815c9f@polymtl.ca> <7e9595026acbfd2f1a7bff321fa255e1@polymtl.ca> <5b5cc0a61e434a3406cbb25c16b8a550@polymtl.ca> <28fcce08-cab6-1e63-80d7-1d61c688cc10@imgtec.com> <09492e58ce0daf1efee14636bc5312cc@polymtl.ca> <5c33519c-6345-3cc8-2fa8-054a3b80bfb6@imgtec.com> <1314dbb1177c39791e5f7a5d51c13089@polymtl.ca> <3abdfadd-9ec1-0f2c-45ed-de2184340320@imgtec.com> CC: Luis Machado , From: Doug Gilmore Message-ID: Date: Tue, 27 Jun 2017 21:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3abdfadd-9ec1-0f2c-45ed-de2184340320@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00751.txt.bz2 On 06/27/2017 10:28 AM, Doug Gilmore wrote: > On 06/25/2017 04:24 AM, Simon Marchi wrote: >> Hi Doug, >> >> Good thing you pinged, I had completely missed it, sorry for the wait. >> >> +gdb_test "source $gdbfile" ".*source-command-completed.*" \ >> + "source $testfile.gdb" >> +# Sometimes the failure only occurs on the second invocation. >> +gdb_test "source $gdbfile" ".*source-command-completed.*" \ >> + "source $testfile.gdb" >> >> Tests should have unique names, so that when one fails, you know easily which one. So, perhaps "source $testfile.gdb 1" and "source $testfile.gdb 2"? >> >> The patch is ok with this fixed. >> >> Thanks, >> >> Simon > Hi Simon and Maciej, > > Simon: I updated the tests per your request. When I asked Maciej to > commit the patch for me, he noticed that the comment extended over the > soft 72 column limit of, so I reformatted it. Also I corrected a typo > and format issues in the changelog entries that he noticed. > > Thanks, > > Doug Also I forgot to mention per Maciej's request, that my work is covered by a copyright assignment to FSF. Doug