From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71221 invoked by alias); 29 Jun 2016 10:44:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71116 invoked by uid 89); 29 Jun 2016 10:44:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 10:44:33 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C88E65422; Wed, 29 Jun 2016 10:44:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5TAiU5L028992; Wed, 29 Jun 2016 06:44:31 -0400 Subject: Re: [PATCH] Use strtok_r instead of strsep in rust_get_disr_info To: Manish Goregaokar References: <7ab96fcb-ffcd-c1ec-187d-f8ec05e43923@redhat.com> Cc: gdb-patches@sourceware.org, Tom Tromey From: Pedro Alves Message-ID: Date: Wed, 29 Jun 2016 10:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00504.txt.bz2 On 06/29/2016 11:38 AM, Manish Goregaokar wrote: > strsep moves the pointer to the end of the string. We want to ensure > the early break happens, since we need token to contain the name of > the variant at this stage. > > strtok doesn't do this. However, strtok does make it NULL, which we > don't want either. I added a check for it in my most recent email, > tests still pass. Right, that one is OK. Please push. Thanks, Pedro Alves