From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138239-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 111506 invoked by alias); 12 Apr 2017 11:16:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111476 invoked by uid 89); 12 Apr 2017 11:16:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 11:16:18 +0000
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 7832AC05490A;	Wed, 12 Apr 2017 11:16:18 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7832AC05490A
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7832AC05490A
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id BBDAB53C38;	Wed, 12 Apr 2017 11:16:17 +0000 (UTC)
Subject: Re: [RFA v2 05/17] Change increment_reading_symtab to return a scoped_restore
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-6-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <d7e42d5c-21bc-0ea0-6eca-c3bae7218f54@redhat.com>
Date: Wed, 12 Apr 2017 11:16:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170411150112.23207-6-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-04/txt/msg00323.txt.bz2

On 04/11/2017 04:01 PM, Tom Tromey wrote:
> -struct cleanup *
> +scoped_restore_tmpl<int>
>  increment_reading_symtab (void)
>  {
> -  ++currently_reading_symtab;
> +  return make_scoped_restore (&currently_reading_symtab,
> +			      currently_reading_symtab + 1);
>    gdb_assert (currently_reading_symtab > 0);
> -  return make_cleanup (decrement_reading_symtab, NULL);
>  }

I noticed that this makes the gdb_assert unreachable.

Thanks,
Pedro Alves