From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 138063857C5B for ; Thu, 13 Aug 2020 17:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 138063857C5B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597339071; bh=EQj0mi006xCDecmyhkLlusLLgMYHaX/MBpXJ1PjGX2U=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=M5/PlEudAQ3bkoBFmgyz6DwPCFtREmmRRtnjrvq3iMFj8dwrSICJhLFad5FY28yjD z76GweoT1VWAKiOh0bkLmzF83GsVFZfZKihnjCgGjOjHTeIPFZ3nluj1tFI7/HP/Nh cj/k5umFy+b6AJQThwso8SwVSXW5FXVpn2+HuMik= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mjj87-1kZFwa2fbX-00lIHm; Thu, 13 Aug 2020 19:17:51 +0200 Subject: Re: [PATCH v2 1/2] gdb: Implement native dumpcore function To: Tom Tromey Cc: gdb-patches@sourceware.org, jhb@FreeBSD.org References: <20200727144338.7033-1-n54@gmx.com> <20200728154602.3824-1-n54@gmx.com> <87mu39njs9.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Thu, 13 Aug 2020 19:15:20 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87mu39njs9.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Awjjba59iZoTPQnPiI5XiihhSG93h+zSF5PUDHQoPegjuaWU8YZ 25U/r/laXWlhpigb2B1Rq9Fe9whtB2QHdm7yqlDFhKoqY63VohVL9eXIpu0Sh/TvIKgjVnb QxP2D2SFuN/aoXrlyhaWsDVL0GJmsXNxDTkuUkJwLn/oeErvNs2kMMNHFBQ7PjQUMRaeDDG yWW3pUp2AFyaiiC9CVwkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:O5y9/05F/QY=:JOkNWP0Ur+pVnpM1H+OC4D dmvdPv3qYh5T9I/oqp4nvcTYGeS7XsnNSgDVBaZYv0oP/mv9aHQXYoIbvVB4duH+IXBP2NRuL uGax89mhoKvMxGK0+jCu8plT8qoXQwm1LJulvBcvTURIkDDO8aBxd4uNjUk5QKwf2d6hZkLLr TmwB+ol1gTJuE/2j2nHQwjf2zWb8kn6WRMiHhQo5FYAMmbtMrKm3TAeWb8E4Gl/M1SxwGW1Mk yl86Qga4Mspn7pzUUV10F96h9UNccqno+lnALOEVWVA41dxSiGaQwoI9aQImN9HnZrZpfrxMb DBk6gc9360TOEIHspASsODPjgdF3lPobgkpgDiktOF3w0zUiq7eG593znWNC/F1qWkZmCpZGU OdqOJggOJMvjmuG7drsqclvuMCEvApVR5M6LoMAxmLBVYw5fPGfVgTiKaZZyQrhmnwvu8e5w5 zVvzFeZdpnviu0ll1BFJhCQ7RDkTlABTCcTOnGulCh6AeMUjzVDjtd+AAn8K7Kn/mO6GT+jvY tiTP3dlfI6iR3KiZii5FBGvFZhmb7dCN6yRK6wnzxO5xQ24uKFQY+hR7tPKHw4WPpQWqHnnc/ GBlQ/y5zRmVnNgkruCvKly8/7sDf0kOzsT9ulx6TjL3SUAK4p5vGWPPmKWWLd+axbOu8kE9N0 jtKVyuanQGYrCwL0vBJzs4GoS28uHahIv9NVz/6aLPr3n61WWywhJyNjJNBEXvsBtTNX2E7Jo m4PdJk77pW0/2+gikQYvdxMS9LaO2kH5ZlSCdRqJEpHeAMCp9QI4yTixLeYw8cerx3iVWhZq1 +mj9aBwBfAhm5nRRRrDq9KcdDeBJZg2pC451BMEdgdLwbHHz1r47o8dFBsyLHQOvEc+ruwaJb CwIbHa2AXAn/EHsnSGqA4jGnk6NoMHRM2HGBywndq1derlQ8JW9u6aWdQC7+7f+40hwdM+mP6 5e4IjkZYhnGVI2yRtOfGRxaa8L0aXOdFTOcDPyOWtJVze5hPfhl1RpDwPsJP93KEoLlylX0GY Yg9fk+jrWIvYMlLjN7swGuDzzaZd65PloH9s7CD0nzNcxy6Zs5T0PlPT0sfsRxjPF7ZfwgKFu KJSx7yMHK2uNH0EvFAkvRFDGHl1McwFTW5FXlQoE2yjhJ6zMR/PqeLtcuvoI9y9qdjsKCb3iQ dvVmtzYP+bcTO+6hyqhshW7p26zQDJCkelVo1eNkMWCj2mFnSTkQlXLp5ODffWkgpWp0B+BoO l5QTMsuyD4DrXRlyS X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 17:18:12 -0000 On 05.08.2020 18:23, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: > > Kamil> Add new API for systems with native kernel support for dumping > Kamil> a process on demand. Wire it into the gdb's gcore functionality. > > Kamil> gdb/ChangeLog: > > Kamil> * target.h (supports_native_dumpcore, native_dumpcore): Ne= w > Kamil> function declarations. > Kamil> * target.c (supports_native_dumpcore, native_dumpcore): Ne= w > Kamil> functions. > Kamil> * target-delegates.c: Rebuild. > Kamil> * gcore.c (gcore_command): Use target_supports_native_dump= core () > Kamil> and target_native_dumpcore (). > > Thank you for the patch. > > Kamil> + /* Generate the core file with native target API. */ > Kamil> + virtual bool dumpcore (const char *filename) > Kamil> + TARGET_DEFAULT_RETURN (false); > > There doesn't seem to be a reason to have a bool return here. > The value isn't documented or used. > I've decided to remove the value in the follow up patchset. > Tom >