From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Lm/dIuNTMWrVQwoAWB0awg (envelope-from ) for ; Tue, 16 Jun 2026 09:47:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1781617635; bh=40Crv9Mhuk9JZ+7KNg17RtxCnHpoo/3vOWNP6MJQHAE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AphKLA2Zezrp8MNkSMGd0wQRiWyhV6lwNpqln6xhSxYT4noEzfWTUl37XiGqiniPh m4WqMiTWKm1tzWtlyvzBSKysyhHhHdkihH1ycLXKyuKq+UwVzaLXhh6g68n2JkrTJh KdP7K0vUg+4Ml2lSimMd2OlH3oKfmwbgsBiOcmPo= Received: by simark.ca (Postfix, from userid 112) id 7DDF21E024; Tue, 16 Jun 2026 09:47:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=j2UgpQx5; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D2A3B1E024 for ; Tue, 16 Jun 2026 09:47:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0519848F66C9 for ; Tue, 16 Jun 2026 13:47:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0519848F66C9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=j2UgpQx5 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8D2424B920DC for ; Tue, 16 Jun 2026 13:46:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D2424B920DC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D2424B920DC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781617609; cv=none; b=oLYZMDW0xu2AQTxso3z4wxdoUMFrL7do7IDjczZM7BJY1du44/9k2dg447Dh9dJLTfwwzCf/E9l7+qqGMKzbV7BSb6XM47AWQ7zraqAxcS3wdtMNFdZ1ZkOMQKBwbs3nfnvTPWlZDKxzQ3CYF1vXDcjXuKOfuKON2yB9h3IRDD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781617609; c=relaxed/simple; bh=40Crv9Mhuk9JZ+7KNg17RtxCnHpoo/3vOWNP6MJQHAE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WElJTpfF0Vc9ax9takObnLkLysEjiAd/9EQxQV1lDb1Qp2GfaXDYLJJTElZX7I4nZO3TGtimPIVd2MBOh72IasjJB/GHgIBIgEMD1A5ZoXoR+7jTczHHRwxXYiNjhkUxGeZPxTC8isRalPy1EDw1ec1mP3AaqGG8NYMwifgZ8VY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=j2UgpQx5 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D2424B920DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1781617606; bh=40Crv9Mhuk9JZ+7KNg17RtxCnHpoo/3vOWNP6MJQHAE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=j2UgpQx5rFLajG5kmyZXtJJj8LNzgGMjuxGfDITupGWv8wRZcF8+qpi81RA/4cgzf YQTOyX64ceyoVzWQ5E9KF/H5+A5+YPVDe473ZR04WSBSkeYH0/xbyq+IGW2jv59eqG Dzr51765/hU1yOBZVl1dKjrJHl0pQgtHoeKgT2o0= Received: by simark.ca (Postfix) id DF5B11E024; Tue, 16 Jun 2026 09:46:45 -0400 (EDT) Message-ID: Date: Tue, 16 Jun 2026 09:46:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] Stop using deprecated language script To: Tom de Vries , gdb-patches@sourceware.org References: <20260616092346.3242305-1-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20260616092346.3242305-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/16/26 5:23 AM, Tom de Vries wrote: > In v4.4.0, pre-commit renamed language script to unsupported_script. > > The rename was done to stress that pre-commit doesn't provide an environment > for the script to run in [1]. > > The language script is now a deprecated alias for unsupported_script, and the > plan seems to be to initially produce a deprecation warning, and eventually > remove support for the alias completely. > > Start using the new name: unsupported_script. > > Furthermore, the check-include-guards hook uses language python, and indeed it > uses a python script, but it doesn't really need a virtual environment. It > imports modules fnmatch, re, sys and typing, all of which are available in > python 3.10 and later, which is the environment pre-commit itself requires > (because we require pre-commit v4.5.1 or later, and pre-commit requires python > 3.10 since v4.4.0). So while we're at it, use unsupported_script for this > hook as well, reducing the amount of environments pre-commit has to manage. > > Tested using "pre-commit run --all-files" with python 3.10, as well as 3.13. > > [1] https://github.com/pre-commit/pre-commit/pull/3577 >From reading the pre-commit doc, I didn't understand the difference between "unsupported_script" and "unsupported", did you? Simon