From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ma3LKSsWr2lNlCAAWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 14:49:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=keQUJjAY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A3F711E0DD; Mon, 09 Mar 2026 14:49:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 11C3C1E089 for ; Mon, 09 Mar 2026 14:49:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 910F54B9DB54 for ; Mon, 9 Mar 2026 18:49:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 910F54B9DB54 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=keQUJjAY Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11022085.outbound.protection.outlook.com [40.107.193.85]) by sourceware.org (Postfix) with ESMTPS id 2FDF34B9DB48 for ; Mon, 9 Mar 2026 18:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FDF34B9DB48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2FDF34B9DB48 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.193.85 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773082127; cv=pass; b=rGX4bHl9bPaAgeJPTfAwqnYcqyAoCpPywcL1Uzz320m2tNxGQyYz/WeiwBVuF5fEnXhFATnJuu/6/QZYDAno9yc/duQd5xE6vVGguC1UFIzmf5m+a2DrdZ73KfiLfeLiGS/gHoOVel4bmsd1L6aHOi7HdCOq3ii+tb9W+T7sNak= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773082127; c=relaxed/simple; bh=rkphPL0ommSyrqcwWuA/cD5ct5XCdVf/uk6ltRyQTBk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=a6BnguA8o5wtRfqIR3JWUdpGyX9C5r+HBBpBTkzraZlZFBjDOQmoRTYE7A52kDxvL4YZb7R1PtU2mQk12VEhQrsJoQg/R3lLFh/wiXaxODFKjPv6n7UxiqJ7P6OXRqZ3SoGJtRmn55r3Ylfgao26RCfoW3ubIQjaMT3edgouryE= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FDF34B9DB48 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nhvUd/NvYFBwyWAGX1yjkPDM9kITpMdBVkhBBM4jfIri96uF31825XG1jmXY9iyjS7K06L6reyefaSAf3ql06O3wNe47zhWgaJzAwt26kO70OJIEmYDkA8Smgf9XdAwiJ8vqlGAQ7QteIfnOd63uDTukNdyaTQEitla6lgHuu/+xXrvys+1pNpcJEG1Hqxk47flrTjrrl2ZNhPTtLU3EMgXo7rJpxmDZWgJ3YLMsPE7eIhtgu+yRiy0GTV7hZSGtlg+ywsuOBSwiWjMzVFEL/nZBjjwz5osnDhXYJ7Yna5tWTX7eOSmwKoHTwl6WgqopSquV4HR71J+2JKcxNn8dBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfjbFqn3UeZzxHf7WPFQvIZO7tR7N10Xqk69Ok9xLoE=; b=OQRDoX3SIsJv2pfn1Jiiax+gU04qu82qbPpc1MB8S3hV5hI+NDNajaHC84/Cm55k/R1up6DUVDHt6Ykg2u5GStAVsyU1FQx+7n2Rwb8zSCYTFhifobPF2IK4D3JNhe0mlTlQZU77lsX7cW9mVmkFsjrbTBJA/llW3o/rdTVB9DfB8m2735bdsaxhgabOLuIIGVKKSHw4DlEqfp6IXl56JgUEia6UV46ywt9omFzzQ6aTPnMofMqqWkx/prhVkgFF7n0IaTM/1OAqqiPmPi9piCBEI+7OcnSVUnsgdkquw7Thz5WsuBSIjRvw1EFBljw0ovXVf9elXh0oBNkjDbnpgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfjbFqn3UeZzxHf7WPFQvIZO7tR7N10Xqk69Ok9xLoE=; b=keQUJjAYAcq4TfUzqIWxiZNmYFpFrexy7pivIqE4kLNiI0tcEkuaJBCdvKN6eja94OI+wmhj7AzzxybOBkVJq2bn7qF4kqlv05REU8T/YQkrkSrNQruz78JWx0sjRPp1+VqVrfgzWTbZrFyhR7iN0MdbPNGOIft/cSmq3EnSOwH6Txd404t9tOVtWZiRYk0ct/cg6CjLgbPEYq6pgRA7So1kipO7j+zZzQT8zElHDssWq5wZGvU2ef5IjrUElCOtrZYBlLbpOEna3tJbVPBapYn51hRMv/+EmTueX3Pask6Y6QpHwap+mmOxM+2gJfTfOFBLp2LOytRhL44A8ckGlw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT4PR01MB9925.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.25; Mon, 9 Mar 2026 18:48:36 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9678.024; Mon, 9 Mar 2026 18:48:36 +0000 Message-ID: Date: Mon, 9 Mar 2026 14:48:34 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260217195329.3833518-1-simon.marchi@polymtl.ca> <20260228035425.422765-1-simon.marchi@efficios.com> <20260228035425.422765-8-simon.marchi@efficios.com> <87seafo0xu.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87seafo0xu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0279.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:109::17) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT4PR01MB9925:EE_ X-MS-Office365-Filtering-Correlation-Id: 2487b961-eaaf-48ff-c151-08de7e0c7876 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: SjIHaEZhH3cWgpISeagMmVkuZZZWlkK23uodUd+UFoLcW4QqeQRlrvdWi9OHC40jQZ/TIXzW/5GRyPdaqqZ3ap/gWLj7+pVQeFM6QBNFGtI9G57HW6S4T57UIUoD7BcDk6iiKV0AKqdIejhqVx2WKbhBmLoeNP3qNgoVDBETppVhJEXOJkvlxefRyD+vIGH961wG5nH2Up+YZnR0OwV7iPojLkbdNBp2VLZSNTSw4ylOL5/YYlPz07gjtZTdScIUKLOcPZx+fINs5uctrLJFFjSd8LDXrqk/CxB+uHZS7LTyE9aKDiDQhztj2LmYcgldWYKK4CXK2/C6VV6B6JzAkPPCu6qmN/wkgnnnl1H6HEoDKyKAiJcCdmgCEYC9ulefQaTtBX8m/NqflqQMicai58qXx3sMjKYNP+4AT9jsLZT7YqnPtLiTUpZHu4HJzDQaU9NsymFyy7kz2TmY2CTyPGiJ27wthN/PWrpq8CXgvzJZajAaewKwIT6dVlUVAdYfdzNKCflJRdCTM9HQh/kmhCvKOU8DiNDBreUEvGzZjgDmhbo0bHkhT92NYDsWw9Yi1OEi+x9RO7v0WPusjchPnf3Uf1yUw4mN6ZPa6NlphLNHdWez794/Z3ZiW1panoL0wSST4X+31L1uNM/ETaamDTwGJ368ifGbl2luiIme1dDsgn2SSM5MSJHUfDT2/+rGXkV8ezwHJ103X+hWKy/1MsMn62mC8lEt9MSBWupiy08= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNDNFBDSGV1MW9OSm1WMEFEcEFKRVhmdVdwY2tKcENDNW1nNGNTQnVhbFFw?= =?utf-8?B?N2V1MXZCWGNRcFh6b202dHMzRHp0YXBXSjA2M0NkcGgvWGJkS3AvQVpZRUtE?= =?utf-8?B?WlZ5NEFwVFIwZWJ1cnVOVEhUS2dVSFlyZ1ZaQ3dVaHgyL1kxbDVVdTdoVmtp?= =?utf-8?B?dlRpbG44S3phRG02elovMW8yV1FQU3hCYVJtcklnZk1OeVdmdkUzZ0luMDk4?= =?utf-8?B?TWhzcWU4Wjh5TFFsTkV1bGtZZCtoaXRwY1RGUHo2RzdkVm82NkxLbUwxNC9k?= =?utf-8?B?TE1BdmVjUjEzc0dmdjdUOW5xbU1hamgrMEFoMDd3ZXNQRU8rMFkzSTBpbXFi?= =?utf-8?B?WUQ4OGpORDEzRUMzakhiSGRCb252S3l4SHpwVXYrYSsxZ1gvUTNid3FCTHR3?= =?utf-8?B?cmphay9xd3QyWFZoU09GYi9hQ2VKbWkwNHVmTXdLNFZvS0FPalI2dkJ5bWht?= =?utf-8?B?bFFlN2Y1dVg2NkJaK3hWcGZEYlVBcSs1RVNDZTRjeW1iUDJ0Ry83V3FGQUxu?= =?utf-8?B?NDR2UUlEaWovMUkraTRha2c4QVNqK3RMUnRmcGg2UDRZZ0twTzk2WEVyeTVt?= =?utf-8?B?Z2l4VndqK3hNSmN3UE5UZklSTGgvd0pCR1FoUXBqSTJCRnN6eGdSZ21PWTJ5?= =?utf-8?B?b1BxSStvTit5MGpMeGw5cG1tYXNCd000MHRnUE5pZndYQmNvaEJOdU9UNHJR?= =?utf-8?B?U0JYWmsyZWxybVkyU3B6V3o0d2FPY3Z0K0lqT0h1TzV3SDFRSm56eGpjMjJR?= =?utf-8?B?MTk3VC8yVXhDSnJ1cG1wWGx2eTNsV3BaNlMwV0V3Z1k1dGpJUUI5dDdRUEhS?= =?utf-8?B?Z3RLOXlnZ1BockhjT1pwS2dVWXJYNklDMnk4elgydUV6RXpkN1hicTU0Vi9S?= =?utf-8?B?cldabzdVZ2pYem1kTWtabUQ1UzBVRzlLdm5LeW9WQkNtdFY0ZXU0SGllMFF0?= =?utf-8?B?SncxMlRQcFU2aWVIdCtsRnBxVytvVG82MERON211OHdqd09ISERDTWVqYkhw?= =?utf-8?B?RGhqdU1zTVp3NE84YjljeW13UHdwWlBWRlNvTGRSM2ordGJ6TGZxa0RZNnhB?= =?utf-8?B?WWZUdlZWVURGM1JmT1kwcGcwejNQY1RrK3lOMlp0SldkakpmSXR1ampwMUdt?= =?utf-8?B?cEhhVWRFTms0NmxVdEpjR2FhZ1JzQUMwRkkvUWhIRnE3V0JlckV6RHBxQlBY?= =?utf-8?B?cndFTlZpb3oydlpYQXVzV0RjUDVLblE4c2hRbGxPTDVnRTI3K0U3WHhSQXFa?= =?utf-8?B?akJVSWExTmdXVVZsbXk0UjlIa0tPNkR0VW5OSTkySE00V3owcE52N0NJTUsx?= =?utf-8?B?bHNzeVM4M1IrNzVCcitBelZnOHFtbm1wZ09PZmJONU5WOVZGUTg5K245MHJK?= =?utf-8?B?cmN5NFhNbTQ1dU9wWS9RM2hoVUNEZVJkcXdHRzI1a2lWT2x0UzhzUkVYRGMy?= =?utf-8?B?TW9hTTFpcDFkbHB6ci9PMG9rdHZOOHlYM2xSTmdmOGtvMkhySzYzMHZPVnNH?= =?utf-8?B?VEdlV3VhNTR0MFFKMVA4bjVScDUvWVZ2dnVFMVVrSEs2bGpIc3JLR25tZ3kz?= =?utf-8?B?NUxTSDh6RDg4ejQyY05Ibmo5SlZjcjBBQm4ya1Q4MlBBWGZhUXhsQm5FaGpu?= =?utf-8?B?cEc0N2d4Ui9jMVlrUnhiQUR1K0w0eUsvZm5yMFpZUFd2Q2NtZVJNK3B3d2pq?= =?utf-8?B?Q1l0M01ud1hWeVFJTWhPdE5zSE92b05yMXJiNFdhNTRJTktyTjBxQlFMbDJh?= =?utf-8?B?QmhLc0w3WkVneGZUaG4ybG10dnQ2YUU3YlIzMUl4a0ZaaUVIUm5YMlhzeWE4?= =?utf-8?B?eWZvZFArQzU2NW5TVHhrYndQNTkwb2hzMzhpcUtacGNFMURrY0pXcTY3RXB2?= =?utf-8?B?UVJzekZKdU5yLzdnZEdVRU44TDlQVFgrRVRiQmZUSnNaaTNHZnZKU1hMbHZG?= =?utf-8?B?Sk9QSk51ZEdxd2VlTk5pT2tsMmpkNnZnWlF0Z3FTa2prZmJYVFh3dTAyckdC?= =?utf-8?B?eEFQY1JybEdpUzFFR1U3cFkxR1E1cGVpOEdyZkUxU1kremtaQzFVRklsQm1X?= =?utf-8?B?eEdNSkozL3A0UkdNelN6WTk4ejFKeFY1VWhjcXcxYjVNWkhYdGNISFcyWG5i?= =?utf-8?B?NEVkWGRhelZmQnJSNXdGaUpYR3dVY3hrVW43dmxabmNUbXJkb1JPVHgyM3hK?= =?utf-8?B?ekM3VjJSNGFGTERmYUd0aWY0RFIwOEY4ZUhBaXNJWktieTdtTE1SN1g5YUxI?= =?utf-8?B?amRnUFJNMXVuTjc2Z3pFMGVFU3UxZncvMHZTS21QL3N1V0xGVFNLMmsvQndi?= =?utf-8?B?cmt1azRUclMyZldYbmdEWkRNaWtCOW9Xa2tCOVhvSFhxSDMwanl5QT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2487b961-eaaf-48ff-c151-08de7e0c7876 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2026 18:48:36.1003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vsu0kCzhWXqdgNMM9OkJ4WLyvn/o8i/V6uO1pLm48NYmDrY4YlaYize7lUMZc+OnRK3XTCoi05SlIhRo543Paw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB9925 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/4/26 2:21 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Change the expanded_symbols_functions quick functions type to hold and > Simon> use a list of compunit symtab to search. > > Simon> Right now the sole user of expanded_symbols_functions is JIT. Update it > Simon> to keep a vector of compunits as they are finalized, and pass this > Simon> vector to the expanded_symbols_functions object. > > I think this is a good direction but this patch isn't quite complete. > The issue is that there are still a handful of spots in gdb that loop > over all compunits. But with this change, these spots will skip some > compunits. > > Now, arguably some of these spots aren't really needed in the current > setup. For instance, objfile relocation in practice is probably not > needed by the current expanded-symbols users (though it seems a little > less future-proof to assume this). I don't understand this. If some code wants to iterate on all compunit symtabs of a given objfile, it would use objfile::compunits. Why would changing expanded_symbols_functions affect that? Simon