From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58622 invoked by alias); 10 May 2017 14:46:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58592 invoked by uid 89); 10 May 2017 14:46:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=transfer, Transfer X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 14:46:50 +0000 Received: by simark.ca (Postfix, from userid 33) id AE1711E561; Wed, 10 May 2017 10:46:51 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH v4 00/12] btrace: Turn linked list of function call segments into vector X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 May 2017 14:46:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <1494416867-19612-1-git-send-email-tim.wiederhake@intel.com> References: <1494416867-19612-1-git-send-email-tim.wiederhake@intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00279.txt.bz2 On 2017-05-10 07:47, Tim Wiederhake wrote: > Hi all, > > this series removes the extra list of btrace function call segments in > struct > btrace_thread_info. To achieve this, the doubly linked list of > function call > segments in struct btrace_thread_info is replaced by a std::vector. > > V1 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2017-02/msg00482.html > > V2 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2017-05/msg00168.html > > V3 of this series can be found here: > https://sourceware.org/ml/gdb-patches/2017-05/msg00202.html > > Patches #1, #2 and #7 were LGTM'd by Simon. > > Changes since V3: > * Patch #4: Replaced int with bool. Added comment that > btrace_function::number > is 1-based. > * Patch #5: Simplified btrace_insn_cmp. > * Patch #6: Split line that had an assignment as a side effect. Added > missing > comment. > * Patch #9: Fixed patch title. > * Patch #10: Fixed patch title. Removed double assignment in > ftrace_bridge_gaps. > * Patch #11: Moved comment to patch #6. Replaced "for (const auto& foo: > ..." > with "for (const unsigned int foo: ...". > * Patch #12: Added missing ChangeLog. Put "static" before "const". > Changed > comment of ftrace_find_call_by_number. > > Regards, > Tim > > Tim Wiederhake (12): > btrace: Use std::vector in struct btrace_thread_information. > btrace: Transfer ownership of pointers. > btrace: Add btinfo to instruction interator. > btrace: Use function segment index in call iterator. > btrace: Use function segment index in insn iterator. > btrace: Remove constant arguments. > btrace: Remove struct btrace_thread_info::{begin,end}. > btrace: Replace struct btrace_function::up. > btrace: Remove struct btrace_function::flow. > btrace: Replace struct btrace_function::segment. > btrace: Remove bfun_s vector. > btrace: Store function segments as objects. > > gdb/btrace.c | 850 > +++++++++++++++++++++--------------------- > gdb/btrace.h | 64 ++-- > gdb/python/py-record-btrace.c | 12 +- > gdb/record-btrace.c | 30 +- > 4 files changed, 465 insertions(+), 491 deletions(-) AFAIC, this series is good to go, pending your response on the btrace_function initialization issue in patch #12. Thanks, Simon