From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93956 invoked by alias); 24 Mar 2018 21:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93947 invoked by uid 89); 24 Mar 2018 21:42:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*u:6.1, H*UA:6.1, HContent-Transfer-Encoding:8bit X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Mar 2018 21:42:27 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2OLg0WI153922; Sat, 24 Mar 2018 21:42:23 GMT Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2gwxts0014-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Mar 2018 21:42:23 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2OLerr5008095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Mar 2018 21:40:54 GMT Received: from ubhmp0002.oracle.com (ubhmp0002.oracle.com [156.151.24.55]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2OLer47017613; Sat, 24 Mar 2018 21:40:53 GMT Received: from [10.154.173.157] (/10.154.173.157) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 24 Mar 2018 21:40:53 +0000 Subject: Re: [PATCH PR gdb/18071] TLS variables can't be resolved on aarch64-linux-gnu To: Simon Marchi Cc: gdb-patches@sourceware.org, Yao Qi References: <1509669516-47946-1-git-send-email-weimin.pan@oracle.com> <402e4a8c-eaf9-a31e-9925-3125f8d149f9@simark.ca> <6c9fb8cc-eb2a-86c3-9e34-fac7c97f6b2f@oracle.com> <8c40379beb8ea8756a3b9075ce6bf4c4@simark.ca> <9df4193c-828a-7b27-292f-f2dab84b3efb@oracle.com> <9a6298ed-bde2-1e66-0b87-a7492cf3a903@oracle.com> <50bbde05-c32b-f273-664a-e9ecbe417b6d@oracle.com> <88889d0ddb7b55c57462cc482246c09b@simark.ca> <48a0a2d8-09a6-1159-8192-8d102ff100b3@oracle.com> From: Wei-min Pan Message-ID: Date: Sat, 24 Mar 2018 21:42:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8842 signatures=668695 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=525 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803240248 X-SW-Source: 2018-03/txt/msg00498.txt.bz2 On 3/24/2018 1:44 PM, Simon Marchi wrote: > On 2018-03-24 16:11, Wei-min Pan wrote: >> Big difference is lookup_minimal_symbol_and_objfile(char *name) only >> searches the ordinary hash table for "name" >> while lookup_bound_minimal_symbol(char *name) does both the ordinary >> hash table  and the demangled hash table. > > Am I missing something?  Your patch (the origin of this thread) > changed lookup_minimal_symbol_and_objfile to also search for demangled > minsyms, didn't it? Yes, originally I changed lookup_minimal_symbol_and_objfile to call lookup_bound_minimal_symbol for each objfile and now lookup_bound_minimal_symbol will call lookup_bound_minimal_symbol once. > > Simon