From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6ZxgDBkXbGZlPjUAWB0awg (envelope-from ) for ; Fri, 14 Jun 2024 06:10:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=dE+yk79l; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=dE+yk79l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1D5CA1E0C1; Fri, 14 Jun 2024 06:10:33 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A87BC1E030 for ; Fri, 14 Jun 2024 06:10:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0AD8A3882130 for ; Fri, 14 Jun 2024 10:10:30 +0000 (GMT) Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2046.outbound.protection.outlook.com [40.107.241.46]) by sourceware.org (Postfix) with ESMTPS id 332C13882100 for ; Fri, 14 Jun 2024 10:10:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 332C13882100 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 332C13882100 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.241.46 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1718359808; cv=pass; b=iZeU7wsj88iRSJod1PhJdpJ+prQb8BQwCfBkBRMtvTkvq5Bi4k4jbfrmcUuKXrBuUsaUi9rHH77Py8THU7to0VEp9Z7nWTPTyJFnBT0vHyLyY5AtRUIw9zxwv/ToZU3HysKNSpcIt7IaN0LZmUq8xR+HumDNPxQI6L7ypY9Wt4g= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1718359808; c=relaxed/simple; bh=QhsPm8nFe2C6J85EdklmFCgzfLFNEuBk7qon3qEKLwc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=NK/vSanHdJ56GY630uB6zGnw1unAZTV3IlkJeLd343HVVqYo3g/Q6YqFeZ9NZV5KXrzY277c26wyPOcX1AyLJAX6ECwlxQWfFxzZeWVV8dGNECBeruJOtnYJN3UdmE0J5O7yJS0NWcxo3wVuUSIIf2xcpYQBKlTHjRKnGBGm/Sk= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=c4b5yMTDB2ym9YsjMnhFAk07xNtzxgEyJqFUaf9lz90BynUaofNB1iotXExGi93d7kJPVo+k7Bsg2zyLxQQ/yEgdjZ4EwrvzYU91kNevVZ25lKTda05xCj5sIfxpXpHm8kpa69TTFA3A0hyzcFvqL0gDogczT2eme9zGEY8g2Jjxu20zwY6BNDiW/7byps/+S1qIh9S322iR7XtNuVXzzAyHAlbNsubPhkUpYM/LBKg3Ru4rom+n972AIYRfYEY83nqp+yw679h8D4ji1AxWLpY5mv5uM2shb2yZtCbCNyyQKdR6FhMQCtToTidIvqWEpAzeAYpi1MepkmT+/uplaA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytqf/6B8g2EmrgyOcjXs0OViB6eTPDRg3MabAmKb7jw=; b=NdbQh+k8THW2KHWavdZ8/oi5Li2ZtXSW8O49JivmIjkLYhk9/2qkjbfgwHPBmxdGRc/b8CEdgvDS2eb4II475PMxpDqL+x5CVWu3Gkea4UGQsovDkONQLCi4kSi+K5L28b6EnzgyoiMAJTQi9ZSCitamTl3zkBWa3ws3SLri1XGYXWKYrsUkqcpLd/2heq2x4cpGNpzghvI0/vMqEhNkzl0e9LpH3DO8VafhZ5lFTFGRLRrp1N+fQ7ucWL/ZPSXIGZzra25Uictztr7QSbXX+uonssM1PsnXzx2rJ3/XbEKYIDBceC38ltrAALoISVGfmyidYxvxI0bvLROXksXrGg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytqf/6B8g2EmrgyOcjXs0OViB6eTPDRg3MabAmKb7jw=; b=dE+yk79lCA18nl0gj+n+5vwyV+OE1e7AtpKOMcrqWWOmro2tK4JGgRW9xmo1tk/2SBRbLEU3pNSYLniqtoAbnc91fU8qM2ZVABl5IAT3jCxyNCptMC4yphyrfOz+YX8gQyY6QSfR6u0BAYCwouWscJEUK4JQ/ycG45nZh7i0UXQ= Received: from AM6P195CA0019.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::32) by AS8PR08MB6214.eurprd08.prod.outlook.com (2603:10a6:20b:29f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.25; Fri, 14 Jun 2024 10:10:02 +0000 Received: from AMS1EPF0000003F.eurprd04.prod.outlook.com (2603:10a6:209:81:cafe::36) by AM6P195CA0019.outlook.office365.com (2603:10a6:209:81::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.25 via Frontend Transport; Fri, 14 Jun 2024 10:10:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS1EPF0000003F.mail.protection.outlook.com (10.167.16.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Fri, 14 Jun 2024 10:10:02 +0000 Received: ("Tessian outbound c027d482f440:v332"); Fri, 14 Jun 2024 10:10:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 34fa0148d12dff6b X-CR-MTA-TID: 64aa7808 Received: from dfde341d75ce.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C34834B0-8C19-4E6A-92A3-AA0E8C11FC04.1; Fri, 14 Jun 2024 10:09:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dfde341d75ce.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 14 Jun 2024 10:09:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=me+snJ8Hyq0rH8zwsoWZVFtIhFWfjnliD+jIGts53Oqk4u8LoKpXggEBtvJN4veM99RdFImvYoZeXYzIIdMqpbbrMugzCGQ4xh9wMu8JyYnI1+ShMHuCNCR6xMzxvH90hTQrwYs2yH6UfP/N65uLHkQhS2joxMBN/yC/Qib8Y4u+O9g0in4rLD7+jF/e1/GRgyeNw2ae/yP+oAJcnpYnKcQvkeCi6vrxNZGMeeDS/r3A9GbvDrrhQ7PwJWN1yTA4FAORO5GFZ2gjz5ijvEfF2Fjf1mGomUzs4lV5jOg1Z0USH7VyoRVdEoABLxmmYUnXr11+Gh/nVtC8UdsKU8qCiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytqf/6B8g2EmrgyOcjXs0OViB6eTPDRg3MabAmKb7jw=; b=gVmWAMSalAb1613RsV4ixJ8PNw9umCbXL7lt+aN4BbMUHycKaeyH2YZTqcsM20peXiZ5MUm0yNvWk0V+Dy6+uHBpz9cwReh3Sz7WP3UgjnMh2pEDLqqUoqFY5NFu/uDKtVG37Rq6057zLBp+BPtMJjB9rIh0PeaGbfMpGqmQ5y4kyqeQiqibx1iwElYNQEBPFmfNLr5kmTdG1Dgq4LxKyQTgjNtM9JrHnnej+N21KC+MQY0fFSqK+9QNQOeGWWjYYaOwNBewtznfWVgF4TzZ7IK9/H36NUpArUZgcxYTOKkr7drt98ZQRn3QTH17dV6BuscxtLdCJPG2ojh64BgGNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytqf/6B8g2EmrgyOcjXs0OViB6eTPDRg3MabAmKb7jw=; b=dE+yk79lCA18nl0gj+n+5vwyV+OE1e7AtpKOMcrqWWOmro2tK4JGgRW9xmo1tk/2SBRbLEU3pNSYLniqtoAbnc91fU8qM2ZVABl5IAT3jCxyNCptMC4yphyrfOz+YX8gQyY6QSfR6u0BAYCwouWscJEUK4JQ/ycG45nZh7i0UXQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB9756.eurprd08.prod.outlook.com (2603:10a6:10:45f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 10:09:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::14e2:874a:b20b:78e5%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 10:09:50 +0000 Message-ID: Date: Fri, 14 Jun 2024 11:09:46 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] gdb: Make tagged pointer support configurable. Content-Language: en-US To: "Schimpe, Christina" , "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: "eliz@gnu.org" References: <20240527102423.1361410-1-christina.schimpe@intel.com> <20240527102423.1361410-2-christina.schimpe@intel.com> <360846d7-0eb9-47ae-8d5c-d26120acaaab@arm.com> <6b4c166c-245a-4bbf-897c-9f393605f2d7@arm.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0257.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB9PR08MB9756:EE_|AMS1EPF0000003F:EE_|AS8PR08MB6214:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b340646-1496-4ff7-8fc7-08dc8c5a27f2 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230036|376010|1800799021|366012; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?SXJTdmFpUm5aZUd1UitTMzUvVGlpZlhXa1lmVjh2alhlbXR1ZnQ4NHM4L1Jm?= =?utf-8?B?b2hrclQvZ0FDcGl3blhUamd1RmQ2Y0lVb1o5ZjdTZmh5TlNrWVJpVW52bUNL?= =?utf-8?B?NWR2ejczWTJOUkQzN0Ewb2NZRFRKaDBQa2lzOVR5emdjdHpqMlBTNTFEaXFM?= =?utf-8?B?RFJiT2NHNGs4TDRlLzJPWDQ3eUh1SEJZQlJLWjdabXRheDBWaGp2S0Z2MDhu?= =?utf-8?B?MVQ4UlEzKzFiQkpsOHVMYjg0MWh0Q0dRNkV1RkpVZ0pPdmIwS0tnSEVQbVFO?= =?utf-8?B?ZVBOU1kyczk2WVdVSndOdW9xRTJUV3FRUlFhUEJ1R0V3SXRGaFRISHozYm5R?= =?utf-8?B?T2tnSHVJK2pCcTVSRXVCcnEvSS84aFltK0lGUHNCVktqNjhuajh3TjN3VDFS?= =?utf-8?B?eFg4RWVGdTdYY0JpeWY0YW9JbVBRbUFGbDByaTQyTE04NlpNTllHTjhxMkYw?= =?utf-8?B?QlZhVjZxU0NvaWN5WkFnZDN6Vm5TU0x0Z2VlSEEzMUZiWEpLcW1CcGVMcUp6?= =?utf-8?B?TkFxcUJ1V2NuaitiOGpFZWNYL1V1bDk4UzFHYk80MHdhSWhib3F0RWsrOElX?= =?utf-8?B?L1oxWTl3Rk5mREFRWS9LRlJKSmdZV2xud1dZQ3drMWIxK1FReGxsclQxZmN5?= =?utf-8?B?Q3lFYlpGTnovaXE1bUUwL0xmcmZma2FRNkVTbS8zSnlYVXE3NVlsRmRIT09H?= =?utf-8?B?WUZZYjd2U0JWVDNRVlJOampyaTVQd2o0MUNMZlJNUXpMNXhjYm1Rb1JnL2Vl?= =?utf-8?B?RGdPQWZFV0xOU1BHZEJJUkd6T2FYaHYramhkNEsvTzdVc3NKNHdjNXFGc1dT?= =?utf-8?B?Ym9XVGQydVB6YmdKY2MrMVBYaXpsT3BrVGFSVWtaWTRwMTVJTm45NUZnZDls?= =?utf-8?B?R2Z4T2QwR0xFdCtFZGlqeUQwcE9wcGFiWU1IU0srL0lsdE1ZYXoyeTNJczBk?= =?utf-8?B?aUJDaUEzRXpneHhjKzlWSEw2Ky9ON29QRzU5MDJGMnRvK05jSk5qYnRSR3Fh?= =?utf-8?B?WHNhditSMGgxZEFCLytRNWlkY3dtVWNKekhXWkNvdUxZSjVrNG90WDdacUJJ?= =?utf-8?B?b0ZLSm81Tkc2eXdXQ2VBSXJWNkRWVUVIMVc0ejU1TDVoWXg3a1o2NFFMcnhL?= =?utf-8?B?Y2pldEIra2VDa1MzV1FTQllweWR0K0dnenR1RnRxWFJiL3BTUWFxZHFvb1Q0?= =?utf-8?B?SlhRR2EyNFcvWThkVUtMSFhSUysrelgyM3ltZFhHN3BJc0tlY09yTXN5bHlp?= =?utf-8?B?YWFodkNPY2FhR3pBMG9hMFJYZmhKb0Jwb1kvZVF5QitkUExWbVh1bzBpMkhj?= =?utf-8?B?U29vU0NWelc0Z1NEbFVTMXZVNU5hL3E3bFdNSGxKR1Bvcy9LZTJuNWc3UmNH?= =?utf-8?B?cHVwaWdYRTRtWFRzUTZ5OE8wQjFKeDlrSUZ2Y0ZIdzd3OEdDWkFiZCtYVjF6?= =?utf-8?B?VzU4R2NaSUNvRzV0QXVZR1BXcU53dUlidDRhUDJDeVE0anN6RlZGbHNKTVNa?= =?utf-8?B?MzN6dUxTNys2VWp2dFZMcEFhNk82OStTV1hlRHZKemk1L1JROGk2OGhOeTYr?= =?utf-8?B?WmJWZFdHZzJBQkNVUCtZOTBSM2ZjL3UzdFB2RExtUnF3SW5aYmptMG5LUTR0?= =?utf-8?B?b1AvUk8xT1AwU3BPNHFxVHc1QU1lb0s1RjhJSk1oNVZKVkdXTExyMEl6U0No?= =?utf-8?Q?MiP0V5KKKebm2wyOjAJp?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230036)(376010)(1800799021)(366012); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9756 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c622e163-d4d3-41e5-bec2-08dc8c5a2075 X-Microsoft-Antispam: BCL:0; ARA:13230037|36860700009|376010|82310400023|34020700012|35042699019|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YWZMTEJpUkN6bEdUcTg4NDgzQzRsNHRaZytDNGFsNjA0NjQxNE83RUxDbHZQ?= =?utf-8?B?SVZ3VUZYRTc5UW9Ub01jVXRIWjJzSTJ4eElHbEF0eC8weXBucGpNcWlNODFI?= =?utf-8?B?NUtLVjcvM29iSVVLOEpOaldET2hxWmMwdU9zZ1FPWUs4d2cyQWV4RzFKZHFl?= =?utf-8?B?Q1Y3SjRibEpsNERjK0VnZGJoT2hJVW5CTDFEMlZ2d2hObzdCMlBIYk9IeGEy?= =?utf-8?B?OUJUWVZ1NjFqMkNjQVppV0RlWXZRUXkzdVNrOUU2YndWdENzSmZSVVU3SHBi?= =?utf-8?B?T0lkZTFKN0dxNmFwOXczV2FwQk5IalRwMkpaUERuVzlla3F1TkQ1bVEwRUlr?= =?utf-8?B?aTUvMUJXU2pSdTBFMDV2T1d1QkM0bjllTmpjMXU1cEJlQnpQVk5KSU9QUDJs?= =?utf-8?B?N3hQMGpLcC9jQWMyc1JPYWV4YUdWVU02NXFzNDJ3WDRuS0tYYlkvem4vUkQ1?= =?utf-8?B?UVNPeVhvUUwwTEhCNVlXTDV0cHJTQTdUUE04Q2l4bUU3QmVUckw2SFo4a1M2?= =?utf-8?B?ZktTSUU1Mm1mYTN5UEZISmt6dTU4dDlRMkJXTXpSRkNwZ2FRamkvVFZxVThT?= =?utf-8?B?NllxUTgrcE1KdWNBekZ0V3FudDZvSG1HTWhFS0E4NEthR09CajZTYWZ0YlA4?= =?utf-8?B?WC8vaGFONlhTRkVSYVVackFPUDJrUEdYbXJhYWQ3THBlNDVJU3Z5cTkzMG54?= =?utf-8?B?TDZ3cktSRnZrQlcxKzMvclJjcnF4Z2xxNk9ubUJRMDRWa2Q1dDZFSjQrYXdJ?= =?utf-8?B?Sm9TL2UyNi8zaC8yb1JHTUlUOG8vT1RPdmovMllnK0F4Tk9MdkJUL0Q2RU15?= =?utf-8?B?WHVBaWRPa1NjMXBPdmNlZXpxQXcxaG9xYmhCU1dUcGVUcnlqdUc4MmgrTVp1?= =?utf-8?B?V3J3T3V6VmJhQ1VUTDdNcWExN2FIb3dnTFFVd0E5TTEzaFYwVjkxY2VqdElh?= =?utf-8?B?UFBQRG96d0dYblJqeXZreXpEUlkwR3kxTUUyUjEyT2RFLzRJdlQvcW9iNWIv?= =?utf-8?B?ajZJNUFkanV0dkFrTkpleG9ETEN6ODIwKzNnQk12V0JRdDBrS2dwTFRIVytq?= =?utf-8?B?Wm1aQnU5NUxPbTg4dnVZRnd2OE52cVM3ZElFRitSVXd6WGc3L3FTSnhkM3Zs?= =?utf-8?B?Ni92RDRWRlErbHFrb1NJcGZUbFBidThPVi9PSDZxMGE4a2h1c3NFMlcxalM5?= =?utf-8?B?RDk4U2pmZ3hCb09xWVRmdWpoSDYrZU4vdElkUUxYa2xrQU9pS1BmOEorQXZ6?= =?utf-8?B?UFFMQUhpZklxQUxJRmhPeWtqU2hzWnJUeVNZM1dsVlNXOVNyV3VmZlpqNnV3?= =?utf-8?B?VEJhcDFxUzBGNlEzakZ4RlVQV3BqSjhvZVA3YlZnTlJhOWJlaktyUjA0NldT?= =?utf-8?B?aUh2Q2hxWUMxWFNiOC8xVlFsT0VCQ2V4MFVBRm1jU2VJSjFiL0JpTllFbzI2?= =?utf-8?B?UVBkaGgvb1FRV1NJY3JqdkpGd2ZuREJWNjUzdXEvdVlEZTNJQTJQV1l0T0Fw?= =?utf-8?B?bGZlbEFXVXY5ZEx4YVlPTnQxbE5sOUdJVlFNMVlBS1Rsblh2K3d3MU5QVUc1?= =?utf-8?B?QktaTE1BbzhiZnRCNU1JWS9hWkRkbk5VUDFUbStFMGVqQ2M1MmpkSEdGVFIx?= =?utf-8?B?RXpkWEo2SnEvb1Y1VTdLazBSZE9MVEFLM2sxQ0VMQ2VWdE1tTjlNakNaYkV0?= =?utf-8?B?cjQwMnZIVi9STlBvWVdkbXlaYlpMTVRmM01UY1pPdVZyNEVyUlBmd2EyMDdm?= =?utf-8?B?elIvbkdxNFc2eHhaZnVETGUxNzJ2VmJDbFp5KzVaUmtuWmdNV240Nm50Zm1n?= =?utf-8?Q?41uxtYoGKNxR7Cnw1Xo8KTvHTZMbpeNhLAwg0=3D?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230037)(36860700009)(376010)(82310400023)(34020700012)(35042699019)(1800799021); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 10:10:02.4139 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b340646-1496-4ff7-8fc7-08dc8c5a27f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6214 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 6/14/24 10:38, Schimpe, Christina wrote: > Hi Luis, > > Do you still have concerns on the topic discussed below? > Otherwise, I'd apply Felix latest feedback and push a new version of this series. Nothing that should block progress on this. My concern was mostly the odd situation with the hooks. But I can revisit that if it turns out to be a problem. > > Thanks, > Christina > >> -----Original Message----- >> From: Schimpe, Christina >> Sent: Monday, June 10, 2024 5:06 PM >> To: Luis Machado ; Willgerodt, Felix >> ; gdb-patches@sourceware.org >> Cc: eliz@gnu.org >> Subject: RE: [PATCH v2 1/3] gdb: Make tagged pointer support configurable. >> >> >> >>> -----Original Message----- >>> From: Luis Machado >>> Sent: Monday, June 10, 2024 4:01 PM >>> To: Schimpe, Christina ; Willgerodt, >>> Felix ; gdb-patches@sourceware.org >>> Cc: eliz@gnu.org >>> Subject: Re: [PATCH v2 1/3] gdb: Make tagged pointer support configurable. >>> >>> On 6/3/24 15:13, Schimpe, Christina wrote: >>>> Hi Luis, >>>> >>>>>>>> -/* AArch64 implementation of the remove_non_address_bits >>>>>>>> gdbarch >>>>>>> hook. >>>>>>>> Remove >>>>>>>> - non address bits from a pointer value. */ >>>>>>>> - >>>>>>>> -static CORE_ADDR >>>>>>>> +CORE_ADDR >>>>>>>> aarch64_remove_non_address_bits (struct gdbarch *gdbarch, >>>>> CORE_ADDR >>>>>>>> pointer) >>>>>>> >>>>>>> Shouldn't there still be some sort of comment for this function >>>>>>> in the c >>>>> file? >>>>>>> At least some "see header file"? Though it seems like no function >>>>>>> in >>>>>>> aarch64- tdep.h has any comment, and all comments are in >>>>>>> aarch64-tdep.c. I would also be fine with that for consistency. >>>>>>> Maybe Luis can comment how he prefers it. >>>>>>> >>>>>>> But I am fine with this patch. Let's see if someone else objects this >> split. >>>>>>> >>>>>>> Reviewed-By: Felix Willgerodt >>>>>>> >>>>>>> Thanks, >>>>>>> Felix >>>>>> >>>>>> Ok, let's wait for further comments here. >>>>> >>>>> Sorry, only spotted this now. >>>>> >>>>> The comment on the above function would be a repetition of the hook >>>>> explanation, and the gdbarch hook explanation covers all the >>>>> details we need. But if the comment is being removed due to it >>>>> being in the header, we should point to the header instead. >>>>> >>>>> "See aarch64-tdep.h" should do. >>>> >>>> Ok, I will add that line. >>>> >>>>> There is something odd about this patch though. The aarch64 code is >>>>> being changed to call aarch64_remove_non_address_bits directly, but >>>>> 3 new hooks are being set: >>>>> >>>>> + set_gdbarch_remove_non_address_bits_watchpoint >>>>> + (gdbarch, aarch64_remove_non_address_bits); >>>>> + set_gdbarch_remove_non_address_bits_breakpoint >>>>> + (gdbarch, aarch64_remove_non_address_bits); >>>>> + set_gdbarch_remove_non_address_bits_memory >>>>> + (gdbarch, aarch64_remove_non_address_bits); >>>>> >>>>> But the above hooks (the gdbarch_remove_non_address_bits_memory >> at >>>>> least) never get used in aarch64 code. Is there a reason for that? >>>> >>>> I thought it's wrong to call the >>>> gdbarch_remove_non_address_bits_memory >>> hook in aarch64 code. >>>> The reason is described here: >>>> https://sourceware.org/pipermail/gdb-patches/2024-May/209420.html >>>> >>>> "Also I noticed that the gdbarch function >>> 'gdbarch_remove_non_addr_bits_memory' >>>> should not be used in several functions of aarch64* files (patch 1) >>>> due to the following: >>>> >>>> The function description for 'gdbarch_remove_non_addr_bits_memory' >>> states: >>>> >>>> "Given a pointer for the architecture, this hook removes all the >>>> non-significant bits and sign-extends things as needed. It gets used >>>> to remove non-address bits from any pointer used to access memory. " >>>> >>>> We don't know if the pointer passed to >>> 'gdbarch_remove_non_addr_bits_memory' >>>> by 'gdbarch_tagged_address_p' will be used to access memory. That's >>>> why it's wrong to call this function in 'gdbarch_tagged_address_p'. >>>> >>>> There are several similar wrong calls of >>> 'gdbarch_remove_non_addr_bits_memory' >>>> in the changes of patch 1. I replaced all of them with >>>> 'aarch64_remove_non_address_bits'." >>>> >>> >>> That's fine, but previously the hook was correct for what is was being >>> used for in aarch64. This particular change means we no longer have a >>> hook that >>> aarch64 can use for the same purposes it used before. This part feels a bit >> odd. >>> It feels like the memory-specific one would be appropriate, but it isn't clear. >> >> Hm, I thought it is not a problem to remove the hook in the aarch64 files, as >> it's target specific code. >> >>> Also, from the 1/3 patch submission: >>> >>> "- In contrast to the implementation for ARM's TBI, the Linux kernel >> supports >>> tagged pointers for memory access." >>> >>> Is there a negative impact if we feed the kernel an untagged pointer >>> for a particular memory access? If not, it sounds like it might be >>> simpler (from gdb's >>> perspective) to let gdb always unmask things, no? Of course, there >>> might be a performance impact of checking if a region is tagged. >>> I'm just trying to understand if the additional hooks are really >> needed/useful. >>> >>> Right now it looks as if we could make it work with the existing hook >>> in place, instead of splitting it into 3 different hooks. >> >> I think in case of amd64 there is a negative impact. In contrast to ARM's TBI, >> LAM can be enabled at runtime. So we would have to parse the >> /proc//status file every time when the pointer is used to access >> memory. With the 3 hooks I wanted to avoid this. >> >> I tried to make the purpose more clear by adding the two sentences in the >> commit message for v2: >> >> "This way, one can make sure that addresses are only adjusted when >> necessary. >> In case of LAM, this avoids unnecessary parsing of the /proc//status file >> to get the untag mask." >> >> So yes, it does work with the existing hook, but when it comes to >> performance, I think 3 hooks would be better. >> >> Christina > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928