From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by sourceware.org (Postfix) with ESMTPS id 874CA3844079 for ; Wed, 5 Aug 2020 18:14:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 874CA3844079 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f68.google.com with SMTP id g8so6638868wmk.3 for ; Wed, 05 Aug 2020 11:14:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WHmuUlab01kaVARGWPVvF0tZnlvDROURggW7LSco2vk=; b=YiSu0UhLPmZaPXioRD49Eyg+YrFKu1KZB3PQTRsGdWkfpKqao2JwlFbcbDTUkrz5Ro Np/DBrdpmX1sqQWm658WY5eCXzKtw8AegvzicOHdCOdAdJs/3phe1qs2p33ymDHAUYyn BfyOtDrqioXSk+q3CF+jKVETam/tcGi0cbT71QF4+My8DDFYSO2pdUqziDt506yud9Vn kyNySGCzVdknjzJ+IgVPSBTq3GNYpaWZh5bkIWytSqdLDYM0GofpUvPGBD8PdxH26MVf ZmysIoHVphCNWsmGaFFBu3KY6C6iD11Z9AVGT+6RqctpIWtcjdbxQLvpUXgZTLwaEt5r tSOw== X-Gm-Message-State: AOAM531wOkEh/GLnPWMzfMyXsIuWyah3CB1R6pT74avidH4YphQ4eozd z9ytlXGtIW9eE5J+CJkg5Co= X-Google-Smtp-Source: ABdhPJwr8ELkL5J9h03JT7x/ZVvfQ5ngONA89j3EeoYMCaLF2dOXo7kBrtz0YHj1UsOQa2LOW7WHBQ== X-Received: by 2002:a1c:4c0e:: with SMTP id z14mr4340806wmf.54.1596651269590; Wed, 05 Aug 2020 11:14:29 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id f12sm3597187wmc.46.2020.08.05.11.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2020 11:14:28 -0700 (PDT) Subject: Re: [PATCH 4/4] gdb: change regcache list to be a map To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20200720204101.2849535-1-simon.marchi@efficios.com> <20200720204101.2849535-5-simon.marchi@efficios.com> <5b521483-2f09-3424-943d-40f83b3080af@palves.net> <0ae62fca-0e23-a7bd-fd12-d75e55d2bbb0@simark.ca> Cc: Laurent From: Pedro Alves Message-ID: Date: Wed, 5 Aug 2020 19:14:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <0ae62fca-0e23-a7bd-fd12-d75e55d2bbb0@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 18:14:31 -0000 On 7/30/20 7:17 PM, Simon Marchi wrote: > Just a note, I think your implementation of get_thread_arch_aspace_regcache could > be simplified by using the top map's operator[]. When we look up a regcache, we'll > want to create it if it doesn't exist, which means that if the ptid_regcache_map > doesn't exist for a given target, we'll want to create it. > > I'll do that change, but I wanted to tell you in case you see a problem with it. I think you're right. I don't see a problem offhand. Pedro