From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 4BA923877006 for ; Tue, 17 Mar 2020 17:59:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4BA923877006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584467971; bh=fuPkDfExrlxYCi4cEVC5oIHlSNc5+BV+2VfsAAxSaFs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=AwwKonglTC/42Jgt2V/Ca1l9saztKDO5ghFqPupJoDLqIhZLBQorOHR7OJ0q0Wef/ 2Dmfek3yKsiHSDAM6dmgirKKVLSg0NRyHWVuXOL9AQEA9Sp0RG7VMQwmLmyN7MfTPK kaY98YfX+YvjkvT1ubp6WoU80uppVOTH/tgKB970= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MdvmY-1jpG0i3aP0-00b4Zl; Tue, 17 Mar 2020 18:59:30 +0100 Subject: Re: [PATCH] Rename the read symbol to xread To: Christian Biesinger Cc: gdb-patches References: <20200317124532.22151-1-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Tue, 17 Mar 2020 18:58:21 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nz2S8cg0QAcHZDT27GUIgT8YzXbVBmxwz" X-Provags-ID: V03:K1:lvvLeygssHkTwKBqY3ZPfih53ATZ/GVjOnauPGxDBcsxeT4MYFC t5tVsOVPPK/DUuzVKn95sZK5innDDnr8Pt1BUMFWU2DUw7A37aYbwYY0sy5qaQ/pCPl4QV5 GHqGwbf/WonID0g/aYL+rdF+ft9M+q3kVyByg49fUupJws4IOHLBZoPY52I9faxJlZ6FjWj xzIPJEY7wIXOBDWjg+RSg== X-UI-Out-Filterresults: notjunk:1;V03:K0:xbUubUbyCa8=:NVj5MGXaeCg2dgX6JjMWYd MpOU8N9FPlUVPDWLQLOr6TbQ6Yk2poG6Uw+r8cJrOGfqZ2uimWVl2p4uc/ka4Zwmt9Staj1d1 iVF7uT2Go3brBjEJk0NYUHPGMkDHeKtia9w8V3AZgBhO09CalXI886Vtsu7d5YwN7H5luECtf KXDBNvGeOs4qoevyK9GChPHuQ15+LsNUsCv7G/33hSW0VpstAsfEPuVQzUG+2JVsbmBu7n8eB jdB4qrA6Q4yXYwFC6XnH32SBrd+SEVzoI1Y6yYFumsSNzE2lK45o3xcO3mO5C/yiMf1FeNA0X BZBCEPQl0dS/ilRDol5J1XzNS3fzd0KgXf/P87/ByruTvqhpTmJK8XRmQ6DQV4+J1XmwuoffT UGonBDrgZiXZDBXRxz6qI0xzPpyPqNcqnkxcmGnYKyzyEmeSnMgBHQadTgnXkFkT6M2NFtDia xaRPadgQfi5kQa0+h7tzgGjeH+cFO1pBv39Yiv06LCI9P+yXct68MFEKxvViTgJrTBQsKkT71 cliwv+lxAyfih84Vv2oJs2NZ1sbbMti+Fx01tttrzUV5cPZJoK2/rncpzJjJ0HvBHB9EVg9lg qkMPwzI/+kfUivNfiYOCpoo6vVNv3tCbKDd9zxQ1D1+VMpdSiuoVL4gP/XNqbm0zeJ6rUhfH1 Mlw/d+ozFk7v+/a7Ou3s+1GNs+J+eIkcrLiS+LENlRLJLhW3Z+dbRupxFay9LqnNgylhXrFG/ 6Ikt2t0d+eus9NlQXoCX06U6v4Sv2Z1qejGIej+2JoSY2dbeoowqWNp2covwvKg5nxCWGqonI K1M4digCahAj4BPtpqKNF5Dk6FPbdD4Iota+ooYAbWRg6MZf3dI7duq3CrlphCb2KL4nduD9n DR4pjtzAZfDzqq/P47jhkxsN6MDEXVGwlzdD8NL1+PzVhPLkq6KA+GE48+M6l5o/4GWTLerCo lT0w2H6XFDhOmVzyPJV/r4vQ47Jhw08+yQpyl1whY9oTzcoi0P+l3D68y3ODTHaEKKDgCjsGL 1mcYbaleY1FGhoucIGWRmHHu2rqRnwoiwooTklVYH045BxmPU9B99LvehuO5nMzqflxJMb3RJ uGglp08np0lnzT6nGJbcjToDgzPPUqAFc5SoMqR7Yz4pS2eo89nDqNdHG5bFc4O/sBucJ/uQq 5O9AzFmy9iSKYU4lTwrZP4oWdSXlhU/SSGmXpnzISHoe/GhOE2QS603tbReULBCOfWdOM= X-Spam-Status: No, score=-25.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 17:59:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nz2S8cg0QAcHZDT27GUIgT8YzXbVBmxwz Content-Type: multipart/mixed; boundary="ExSr4huChjw1fMmu2AhO6HLbUxl1F0ZZR"; protected-headers="v1" From: Kamil Rytarowski To: Christian Biesinger Cc: gdb-patches Message-ID: Subject: Re: [PATCH] Rename the read symbol to xread References: <20200317124532.22151-1-n54@gmx.com> In-Reply-To: --ExSr4huChjw1fMmu2AhO6HLbUxl1F0ZZR Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 17.03.2020 18:51, Christian Biesinger wrote: > On Tue, Mar 17, 2020 at 7:46 AM Kamil Rytarowski wrote: >> >> This avoids clashes with macro read in the NetBSD headers. >=20 > Out of curiosity, what does NetBSD define read to? >=20 > I think it would be useful to add a comment saying why this is called x= read. >=20 NetBSD ships with SSP (stack smashing protector) support that conditionally redefines read(2). https://github.com/NetBSD/src/blob/trunk/include/ssp/unistd.h#L39 Is a comment in the commit message enough? > Christian >=20 >> --- >> gdb/user-regs.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/gdb/user-regs.c b/gdb/user-regs.c >> index a232b1eb000..a968a18bc23 100644 >> --- a/gdb/user-regs.c >> +++ b/gdb/user-regs.c >> @@ -41,7 +41,7 @@ >> struct user_reg >> { >> const char *name; >> - struct value *(*read) (struct frame_info * frame, const void *baton= ); >> + struct value *(*xread) (struct frame_info * frame, const void *bato= n); >> const void *baton; >> struct user_reg *next; >> }; >> @@ -60,7 +60,7 @@ struct gdb_user_regs >> >> static void >> append_user_reg (struct gdb_user_regs *regs, const char *name, >> - user_reg_read_ftype *read, const void *baton, >> + user_reg_read_ftype *xread, const void *baton, >> struct user_reg *reg) >> { >> /* The caller is responsible for allocating memory needed to store >> @@ -68,7 +68,7 @@ append_user_reg (struct gdb_user_regs *regs, const c= har *name, >> register list stored in the common heap or a specific obstack. = */ >> gdb_assert (reg !=3D NULL); >> reg->name =3D name; >> - reg->read =3D read; >> + reg->xread =3D xread; >> reg->baton =3D baton; >> reg->next =3D NULL; >> (*regs->last) =3D reg; >> @@ -82,10 +82,10 @@ static struct gdb_user_regs builtin_user_regs =3D = { >> }; >> >> void >> -user_reg_add_builtin (const char *name, user_reg_read_ftype *read, >> +user_reg_add_builtin (const char *name, user_reg_read_ftype *xread, >> const void *baton) >> { >> - append_user_reg (&builtin_user_regs, name, read, baton, >> + append_user_reg (&builtin_user_regs, name, xread, baton, >> XNEW (struct user_reg)); >> } >> >> @@ -103,14 +103,14 @@ user_regs_init (struct gdbarch *gdbarch) >> >> regs->last =3D ®s->first; >> for (reg =3D builtin_user_regs.first; reg !=3D NULL; reg =3D reg->n= ext) >> - append_user_reg (regs, reg->name, reg->read, reg->baton, >> + append_user_reg (regs, reg->name, reg->xread, reg->baton, >> GDBARCH_OBSTACK_ZALLOC (gdbarch, struct user_reg)= ); >> return regs; >> } >> >> void >> user_reg_add (struct gdbarch *gdbarch, const char *name, >> - user_reg_read_ftype *read, const void *baton) >> + user_reg_read_ftype *xread, const void *baton) >> { >> struct gdb_user_regs *regs >> =3D (struct gdb_user_regs *) gdbarch_data (gdbarch, user_regs_dat= a); >> @@ -122,7 +122,7 @@ user_reg_add (struct gdbarch *gdbarch, const char = *name, >> regs =3D (struct gdb_user_regs *) user_regs_init (gdbarch); >> deprecated_set_gdbarch_data (gdbarch, user_regs_data, regs); >> } >> - append_user_reg (regs, name, read, baton, >> + append_user_reg (regs, name, xread, baton, >> GDBARCH_OBSTACK_ZALLOC (gdbarch, struct user_reg));= >> } >> >> @@ -214,7 +214,7 @@ value_of_user_reg (int regnum, struct frame_info *= frame) >> struct user_reg *reg =3D usernum_to_user_reg (gdbarch, regnum - max= regs); >> >> gdb_assert (reg !=3D NULL); >> - return reg->read (frame, reg->baton); >> + return reg->xread (frame, reg->baton); >> } >> >> static void >> -- >> 2.25.0 >> --ExSr4huChjw1fMmu2AhO6HLbUxl1F0ZZR-- --nz2S8cg0QAcHZDT27GUIgT8YzXbVBmxwz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5xD70ACgkQS7MI6bAu dmwenxAAlm+aid58aS05enS1GZTYbEpvsnq4gYXiGt5iMLL1IPCYgf0QUUrbKRFK /q1yXcoh7hkAAscgTorn7MWGkoxOp9pqEdkOtqNt7pfjgFnAIJfeO150HO+HOLyc CV4UtpwfmXPZ/JuBYYxUu/I8JTkSwRihdHPsDb1DqPUne7YsDZmw5d6dz7N+OIsr 2XrV0k4ZNbpW6mZzhG5oA44fbI2l8Ybge/NBvDUjup/ZIaUwQYMAB1lTlv/Tg4zl OLKcgm2uzRBNoGkXd+UV2f+THYZ4OAlQplI8E2lRHf2KpCJw3LSGDX29hBs6Hrnw ZL1/cVPbM9/f1pfoZGq4NjxMLlPnE80FKcOM3O/L2cBFAnMe1RPDGZzUC3xvDsCM pCQlDoZoyliEhez1sSv4gPMJFM0l81iFLxOsLehbm6jp61JewkBnenmu7tYBRS+T PuvM4wTX9dhhdB050rE3aiJ/7wjrvrR9ah1U8/QcVA1KdEchDp49+cQeEMRGKA/W zuRqp0RZe5pYXLOf1QVNrhtLxXfB06sxxUKLvSmaRt8VXNDBbdyN8s+I2m7feCc6 w5uvxti/lpxS7TjCSMkXT0fbv0btip/K1NuA3ym4L6uto0o6tlhaTVjdzgu2igAm GFa+lc+6t0Gqxotjz4uecThC+C7z9Vq3pi4sDFFg6xnQ4MFaje4= =8p3G -----END PGP SIGNATURE----- --nz2S8cg0QAcHZDT27GUIgT8YzXbVBmxwz--