From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id y5DLMv8AqGqwLgwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 10:13:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789395199; bh=VbemN4/Pbk0yE7ttDCig6nrX85lkyodfcOeU4aCgnQw=; h=Date:Subject:From:To:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jNn3hfrKtMLJW7gsVjpP1e7wcIjquYKayo1DOWifkevf8WDbvwKb2oBEIiDX6qBw/ iqkwTOcjD9qHTWwbz0PUcdPnjOIz3nUYIdvskkAJs15phwEpCPeHuVivzTc/FXgCwY jS76wt+WCMJBzkZDS55dXu9NAVwu3iK1t5BB9sgA= Received: by simark.ca (Postfix, from userid 112) id BD5001E066; Mon, 14 Sep 2026 10:13:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Rf6F3Mhc; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1F1721E01F for ; Mon, 14 Sep 2026 10:13:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A1CB94BAE7C1 for ; Mon, 14 Sep 2026 14:13:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1CB94BAE7C1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Rf6F3Mhc Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B39314B99F7E for ; Mon, 14 Sep 2026 14:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B39314B99F7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B39314B99F7E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789395141; cv=none; b=FCjChnoLabTbPvXRru9rQlX9NJgZQkssS5IjC4YcEAQUxK3bcN/UjgOxPj8FjpGVELUOJb2p4a+JwcideeQi4KD5qEH7vgnJ4kD/MIjZIYu22ywPkL7Jb/PwQ9XnsKwE1ApsDSkKTnCvLV88om3XSecAuOS0ly/6NRIi6rIqipE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789395141; c=relaxed/simple; bh=VbemN4/Pbk0yE7ttDCig6nrX85lkyodfcOeU4aCgnQw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=nDE7uZJINrsg5H3Ai2vFdocZYqj9fnuaS+tRENDQ4GGTs0GQlgIJRo4aGk16I8fabn5KId7bLQSqLTviMnmgDG1MfImGTOgtJkFwNWGPeuxnxZ1NGhOhxLFrYl4Z1r1qn2f/cE85SPpwET5kKsQpWEqYbOvE2FJL+Z9epNngbVE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Rf6F3Mhc DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B39314B99F7E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1789395141; bh=VbemN4/Pbk0yE7ttDCig6nrX85lkyodfcOeU4aCgnQw=; h=Date:Subject:From:To:References:In-Reply-To:From; b=Rf6F3MhcVcFyH3FtSa9EvHRdj5j5NaX4qVopa0bqZ5SU/Xfnk+i86p5gDW8k5a6XZ 3ijnc4k98au9l5UdEwxVcoMel2Q0yLRBv39ZVpW5EEWqOyouOzQZd6zFl6D9f+d4SR qLckPSE/XkzY1kWnLnue+2ypU1aYDtRtwwNAjprA= Received: by simark.ca (Postfix) id 5D2C41E01F; Mon, 14 Sep 2026 10:12:21 -0400 (EDT) Message-ID: Date: Mon, 14 Sep 2026 10:12:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix inheritance of finish_breakpoint_object From: Simon Marchi To: Tom Tromey , gdb-patches@sourceware.org References: <20260912142115.3717539-1-tom@tromey.com> Content-Language: fr In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/14/26 9:38 AM, Simon Marchi wrote: > On 9/12/26 10:21 AM, Tom Tromey wrote: >> I noticed that finish_breakpoint_object does not derive from PyObject, >> but instead uses the older C-style inheritance. This patch fixes >> this. > > - Missing > > static_assert (gdb::is_python_allocatable_v); > > as mandated by the comment in python-traits.h > > - The two local variables in bpfinishpy_out_of_scope can be removed, in > favor of just using bpfinish_obj directly. FYI, I have a patch to remove all those no-unnessary casts and local variables, I'll send it after you push this one. Simon