Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Weimin Pan <weimin.pan@oracle.com>
To: <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] gdb: ADI support
Date: Tue, 27 Jun 2017 00:44:00 -0000	[thread overview]
Message-ID: <d5634edc-8498-4592-b5aa-9281d4888389@default> (raw)

Hi Yao,

It doesn't look like the proposed file naming convention for new functionality
is forthcoming. I've therefore added the ADI support to file sparc64-tdep.c and
submitted a revised patch which addresses all but one of your comments. The one
that's left out is to define ADI as a qXfer object for reading from and writing
to the ADI maps file through target layer.

Thanks again for your comments.

----- Original Message -----
From: qiyaoltc@gmail.com
To: weimin.pan@oracle.com
Cc: gdb-patches@sourceware.org
Sent: Wednesday, June 21, 2017 9:47:54 AM GMT -08:00 US/Canada Pacific
Subject: Re: [PATCH v2] gdb: ADI support

On Wed, Jun 21, 2017 at 5:22 PM, Wei-min Pan <weimin.pan@oracle.com> wrote:
>
> Thanks for bringing up and taking care of  this matter. I will create
> sparc64-tdep-adi.c for SPARC
> ADI support.
>

Hold on :), I don't think people agreed on the new
convention yet.  Before the agreement is made,
sparc64-tdep.c is still the right place to add adi stuff.

-- 
Yao (齐尧)


             reply	other threads:[~2017-06-27  0:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  0:44 Weimin Pan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-16 23:37 Weimin Pan
2017-06-20 13:35 ` Yao Qi
2017-06-20 17:50   ` Wei-min Pan
2017-06-21  9:47     ` Yao Qi
2017-06-21 10:11       ` Pedro Alves
2017-06-21 16:22       ` Wei-min Pan
2017-06-21 16:42         ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5634edc-8498-4592-b5aa-9281d4888389@default \
    --to=weimin.pan@oracle.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox