From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27045 invoked by alias); 7 Jun 2017 21:06:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27031 invoked by uid 89); 7 Jun 2017 21:06:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=forks X-HELO: mail-wr0-f173.google.com Received: from mail-wr0-f173.google.com (HELO mail-wr0-f173.google.com) (209.85.128.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Jun 2017 21:06:56 +0000 Received: by mail-wr0-f173.google.com with SMTP id v104so11009938wrb.0 for ; Wed, 07 Jun 2017 14:07:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cI+Of7srZ1XnDN/m2IGhpOZeL4+DVOrVZFusJM3f25k=; b=RV3EkCYJ3ZmNfsKvUjf1ptUYZlWFKxVp1JDyqVlqIrFfVBg9nXk84HwnqOkosHMq49 BLZ/Up3vDbabbKuVAnncsZTyysKhW2duI1/ANPwh+vprsgYQM0vy9pFhD8+BlbFxABJ4 dJcslV0rgAyxHaxsIf14ffgJ6iSRnLPTRxNzeL2CBV+a4diHCzY0TGo5w8a7hoczPADm Krz9Cted52p0ZVOIvrxRxmbNmaJ6nGGW16vBQ4geG7R+iMS4qelh3Kix8JgFVA2aneIo gcz5x3QYkXNcwlZxadf7Dqmi8d8tFMBon6p1/eo95+CnEmt5+JmVQJlHQjPgZWOniLgR Hnng== X-Gm-Message-State: AODbwcAGy5RxpydAhsQM2HkH2fV2oaEY5Qe5jGYqQCfwOy1Pu9IYbk8d lnVqQoHITOd7rPim/l9Ihw== X-Received: by 10.223.134.186 with SMTP id 55mr12679340wrx.159.1496869618334; Wed, 07 Jun 2017 14:06:58 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id r130sm4254538wmg.4.2017.06.07.14.06.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2017 14:06:57 -0700 (PDT) Subject: Re: [PATCH v6 3/4] Share fork_inferior et al with gdbserver To: Sergio Durigan Junior References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-4-sergiodj@redhat.com> <0e95d746-9293-3301-15ed-84d6c4280116@redhat.com> <87poep8zdg.fsf@redhat.com> <87shjbo6ko.fsf@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: Date: Wed, 07 Jun 2017 21:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87shjbo6ko.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00180.txt.bz2 On 06/07/2017 10:01 PM, Sergio Durigan Junior wrote: >> > >> > I tried it against v7, and that works. The think to keep >> > in mind is that these trace_start_error functions >> > are only called from the fork child, so they're very much >> > fork-inferior.c related. > They're actually being used by some -nat.c files on gdb/, and -low.c > files on gdbserver. But as I said, I'm OK with your suggestion. Sure, but that's exactly the code that is related to forking a child, and which runs on the fork child, after it forks, and before it execs. It'd never make sense to call those functions on the fork parent, which is GDB, because they'd cause GDB to exit! Thanks, Pedro Alves