From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LV7/D5cd12GqBgAAWB0awg (envelope-from ) for ; Thu, 06 Jan 2022 11:49:27 -0500 Received: by simark.ca (Postfix, from userid 112) id 3174D1EDEE; Thu, 6 Jan 2022 11:49:27 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_BL_SPAMCOP_NET,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74A8B1E940 for ; Thu, 6 Jan 2022 11:49:26 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1308B385803D for ; Thu, 6 Jan 2022 16:49:26 +0000 (GMT) Received: from aye.elm.relay.mailchannels.net (aye.elm.relay.mailchannels.net [23.83.212.6]) by sourceware.org (Postfix) with ESMTPS id 5CAAE3858410 for ; Thu, 6 Jan 2022 16:49:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CAAE3858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E866D6221D7; Thu, 6 Jan 2022 16:49:12 +0000 (UTC) Received: from pdx1-sub0-mail-a244.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 832996220E9; Thu, 6 Jan 2022 16:49:12 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from pdx1-sub0-mail-a244.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.106.113.9 (trex/6.4.3); Thu, 06 Jan 2022 16:49:12 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Dime-Average: 23f8722e4d484a02_1641487752780_1216429092 X-MC-Loop-Signature: 1641487752780:107903713 X-MC-Ingress-Time: 1641487752780 Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt [2.83.100.144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a244.dreamhost.com (Postfix) with ESMTPSA id 4JVC4760X6z3Z; Thu, 6 Jan 2022 08:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=palves.net; s=palves.net; t=1641487752; bh=ShiJt6JikfSpZES+kfJrJAPHhZc=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=wRC2FcOW+mElI7G1KqoV/Mw9jK4nl9uSyoRg/NQWj+AEapa/DlVNOFM53W6fpbp7u stfttwU4ouKySTpFq9+AcLZssUnp1732nFPyGNYO4XNqjeI1+XY03Lex1foNxWHpeZ E5nh/9oy2ueJ9VTbal0obxIzy/ZKzPbRBiBFy1L8= Message-ID: Date: Thu, 6 Jan 2022 16:49:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp Content-Language: en-US To: Lancelot SIX References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-12-lsix@lancelotsix.com> <757f0aed-decd-ab44-619a-2e0d6df59cf1@palves.net> <20211217225753.jgzdrnq5fwgtx2ln@Plymouth> From: Pedro Alves In-Reply-To: <20211217225753.jgzdrnq5fwgtx2ln@Plymouth> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-17 22:57, Lancelot SIX wrote: >> >> IWBN to get this grouped properly while at it. Would you mind removing the "only:" etc. >> manual prefixes instead, converting that to the with_test_prefix prefix? Like: >> >> with_test_prefix "only" { >> if {[mi_runto_main] == -1} { >> return -1 >> } >> >> - mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values" >> - mi_send_resuming_command "exec-continue" "only: entry_equal: continue" >> + mi_gdb_test "-gdb-set print entry-values only" {\^done} "set print entry-values" >> + mi_send_resuming_command "exec-continue" "entry_equal: continue" >> } >> >> etc? > > Hi, > > Yes. Looking at the file it is posssible to go even one step further > and have a second level of with_test_prefix. This is what I have done > in the revision of this patch (which makes the patch much longer, but I > think it is worth). See below. > > Thanks, > Lancelot. OK.