From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GTPzEeXAhWpIpTAAWB0awg (envelope-from ) for ; Wed, 19 Aug 2026 10:42:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sv95WgJA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g0o6G3vW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Es6gsumn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wAURx6Jg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 43E2D1E0A3; Wed, 19 Aug 2026 10:42:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 829DE1E033 for ; Wed, 19 Aug 2026 10:42:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5219C4B9DB70 for ; Wed, 19 Aug 2026 14:42:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5219C4B9DB70 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sv95WgJA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g0o6G3vW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Es6gsumn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wAURx6Jg Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1C5CD4BA9011 for ; Wed, 19 Aug 2026 14:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C5CD4BA9011 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C5CD4BA9011 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787150540; cv=none; b=pPi3qwVa+F+39CYU13J3U8iKqU74jagjoDjMzzyVrYv6bXZcf8iLlc/yGpdE9liQ6bTGg/GCkK6Gpy85JzSCxwwtucceOof2KpVYOFcub6KFqgSrv/wkD8AN9V3ax8vSHWOnm3E23ZWgT8kaKk4aQAnsOoCZ4Rl7cKuUaEnZYp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787150540; c=relaxed/simple; bh=o7n6t7REOW78vPyoS9jsLSu6B5U8+i10FmDGC64ig1Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=Ts0bGyjFktrLtUKsX5+m77BiHbp4ztZ9sr/Jn9RZNk1ZaeMWm4WQ1buW+M2JlJsqQ+gK6Bd6MQg3t3ZTk69mroO4H7hB1gzxaOVdFY1ke8DZVJ+D3K9uMTlbib39OPnYJ/fVT/fE++H6is8++LYMorf8vZ3t7C9RGO264q90etM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Sv95WgJA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=g0o6G3vW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Es6gsumn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wAURx6Jg DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C5CD4BA9011 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DEFFA84B94 for ; Wed, 19 Aug 2026 14:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787150535; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZlfi1fVrFW8aHcHE6uu372hup0jkt5wvt06tDFt45M=; b=Sv95WgJATBt9BriGWogOZYHwoh04b5udviupZ8y1hP8fqLIrEl5aa82fq0FUrJWRADmt/4 kTUmp1zj3sEuJrJGin5ztPjmIoTZpR8/rFFTqTcbJuX665ER7OHwNcrwBw+gtnxtkNorIs fLhOeiummGzRoSEe30tP2yfTeuZhgv0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787150535; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZlfi1fVrFW8aHcHE6uu372hup0jkt5wvt06tDFt45M=; b=g0o6G3vWX0hcPJpFbBUn6478NUx01SkjH92240/AOEbC1zz+91PMDRUEhIj6M1WBZUwijx Keayg8JFMrGvL6Cw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787150530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZlfi1fVrFW8aHcHE6uu372hup0jkt5wvt06tDFt45M=; b=Es6gsumn8ELMj7FfDcUNMzEM6bFnB2z9GE3hZeEQGNRYHwiFVzkkGPu6KmaKD8BWCswYq0 uw6/bOtAqi3+LFeKqqpcgsfzMnUpVD/FwSUxjiJVUTjBXAMksjABiqsoP0BKqisk5WNYwu ftEbCLBpShclx6W9CW4KqQZ/bKSXeLE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787150530; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AZlfi1fVrFW8aHcHE6uu372hup0jkt5wvt06tDFt45M=; b=wAURx6JgzSCFZLByi/8xc2qbQjQTqipDlWLnKwlMn8kiEYLADyNxnsTNiqWcwU8e4H4I3Y aS2097vKQop9AFAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE959362E for ; Wed, 19 Aug 2026 14:42:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KIUYMcLAhWpuFQAAD6G6ig (envelope-from ) for ; Wed, 19 Aug 2026 14:42:10 +0000 Message-ID: Date: Wed, 19 Aug 2026 16:42:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Fix gdb.tui/list-before.exp on ppc64-linux From: Tom de Vries To: gdb-patches@sourceware.org References: <20260801122832.3152974-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260801122832.3152974-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, gdb.tui:url, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/1/26 2:28 PM, Tom de Vries wrote: > On ppc64-linux, with test-case gdb.tui/list-before.exp I run into: > ... > (gdb) tui enable^M > ... > (gdb) Screen Dump (size 80 columns x 24 rows, cursor at column 6, row 16): > 0 +------------------------------------------------------------------------------+ > 1 | | > 2 | | > 3 | | > 4 | | > 5 | | > 6 | | > 7 | [ No Source Available ] | > 8 | | > 9 | | > 10 | | > 11 | | > 12 | | > 13 | | > 14 +------------------------------------------------------------------------------+ > 15 exec No process (src) In: L?? PC: ?? > 16 (gdb) > 17 > 18 > 19 > 20 > 21 > 22 > 23 > FAIL: $exp: initial source listing > ... > > The problem is in tui_get_begin_asm_address, where we look up the minimal > symbol for main, and use its address. > > With the v1 ABI, we don't get the address of main in the .text section: > ... > 00000000000008b4 <.main>: > 8b4: fb e1 ff f8 std r31,-8(r1) > 8b8: f8 21 ff c1 stdu r1,-64(r1) > 8bc: 7c 3f 0b 78 mr r31,r1 > ... > but the address of the descriptor of main in the .opd section: > ... > 000000000001fee8
: > 1fee8: 00 00 00 00 .long 0x0 > 1feec: 00 00 08 b4 .long 0x8b4 > 1fef0: 00 00 00 00 .long 0x0 > 1fef4: 00 02 7f 00 .long 0x27f00 > ... > > Fix this by using gdbarch_convert_from_func_ptr_addr, similar to how that's > used in create_internal_breakpoint. > I'm pushing this shortly. Thanks, - Tom > Tested on ppc64-linux and x86_64-linux. > --- > gdb/tui/tui-disasm.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c > index 5c68312a91b..68a5c425934 100644 > --- a/gdb/tui/tui-disasm.c > +++ b/gdb/tui/tui-disasm.c > @@ -409,7 +409,11 @@ tui_get_begin_asm_address (struct gdbarch **gdbarch_p, CORE_ADDR *addr_p) > bound_minimal_symbol main_symbol > = lookup_minimal_symbol (current_program_space, main_name ()); > if (main_symbol.minsym != nullptr) > - addr = main_symbol.value_address (); > + { > + addr = main_symbol.value_address (); > + addr = gdbarch_convert_from_func_ptr_addr > + (gdbarch, addr, current_inferior ()->top_target ()); > + } > } > } > else /* The target is executing. */ > > base-commit: 5b805c95e9399e35f7bc895ec5b67aabdbc6ce41