From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c6JIEcu0rV8WWwAAWB0awg (envelope-from ) for ; Thu, 12 Nov 2020 17:18:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 3A3611F08B; Thu, 12 Nov 2020 17:18:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D8CB1E58D for ; Thu, 12 Nov 2020 17:18:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7395B3858005; Thu, 12 Nov 2020 22:18:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7395B3858005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1605219529; bh=K9up4ub4YhXEReql7+YoKTYz6rVZ+noGYVBHbX2UW+s=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YQ6uq8b0bHnaZo9Ztfww8xzAlWVATmx+VQYVRBDfoSs80MckHkSmISQH1KF4xRSTC GdgG7DV7US67uek9kXJEX/WSUCO/Fr+OBATt0YTcgGSWAUHDP0Cv6UCYCtgYsqbtsr amsIbMO/qoTeVLer+Tr0c15fF8CIADfFzKxsP0QA= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 6396B3858005 for ; Thu, 12 Nov 2020 22:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6396B3858005 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-y7PQBG5iOFiB4Q0D02TYgA-1; Thu, 12 Nov 2020 17:18:44 -0500 X-MC-Unique: y7PQBG5iOFiB4Q0D02TYgA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 848A51074657; Thu, 12 Nov 2020 22:18:43 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-189.phx2.redhat.com [10.3.113.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 333C55578C; Thu, 12 Nov 2020 22:18:43 +0000 (UTC) Subject: Re: [PATCH 2/2] Exclude debuginfo files from "outside of ELF segments" warning To: Tom Tromey , Keith Seitz via Gdb-patches References: <20201112205327.2733425-1-keiths@redhat.com> <20201112205327.2733425-2-keiths@redhat.com> <87imaab66o.fsf@tromey.com> Message-ID: Date: Thu, 12 Nov 2020 14:18:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87imaab66o.fsf@tromey.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Keith Seitz via Gdb-patches Reply-To: Keith Seitz Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 11/12/20 1:45 PM, Tom Tromey wrote: > I didn't know about is_debuginfo_file, so I took a quick look, and it > says: > > /* Determine if a bfd is a debuginfo file. Unfortunately there > is no defined method for detecting such files, so we have to > use heuristics instead. */ > > I wonder if gdb should just use its own idea here, though -- like if the > objfile has a backlink, it is a separate debug file. Yeah, I debated that, too, but ultimately, I thought it best to do what BFD does. Camaraderie? :-) > I'm ok with this patch though. I'll wait a day or two and see if anyone else chimes in. I appreciate the speedy review! Keith