From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110339 invoked by alias); 7 Jul 2018 03:51:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110319 invoked by uid 89); 7 Jul 2018 03:51:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=stabs X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 03:51:08 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D76121E059; Fri, 6 Jul 2018 23:51:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530935466; bh=uhnso+eCxyCu9U4c4djuJKC7/LEYijdUW0HcjhDfPBg=; h=Subject:To:References:From:Date:In-Reply-To:From; b=KLlEq0iaKKyBe6VRE+lfPpb9PMcolHjBkoKKLHhGqsqjowhp1D6P5Khh7eshec51x Grd36FhOoJC9E3dfw0iDs+dfJWHKjjRY81ZukvS8nNcYB6E/6psrlaGZzVABp5BB7D qUe52Kmel7o/0E7ISfREoEUACW4icSS6Vv0hPdP0= Subject: Re: [RFA 04/42] Move last_source file to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-5-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sat, 07 Jul 2018 03:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00164.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > @@ -140,6 +147,12 @@ struct buildsym_compunit > /* The subfile of the main source file. */ > struct subfile *main_subfile = nullptr; > > + /* Name of source file whose symbol data we are now processing. This > + comes from a symbol of type N_SO for stabs. For Dwarf it comes I think it's spelled DWARF (all caps)? > + from the DW_AT_name attribute of a DW_TAG_compile_unit DIE. */ > + > + gdb::unique_xmalloc_ptr m_last_source_file; Nit: remove the empty line between the comment and the field. Should this new field be private? Otherwise, LGTM. Simon