From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kLnBHHENWGP3kRAAWB0awg (envelope-from ) for ; Tue, 25 Oct 2022 12:23:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 73BC51E11A; Tue, 25 Oct 2022 12:23:13 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=aP2LR2mD; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 088221E0D3 for ; Tue, 25 Oct 2022 12:23:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A613D3856DDA for ; Tue, 25 Oct 2022 16:23:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A613D3856DDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666714992; bh=kesZMdobDdZb7ln7NheSStsQ92IHLgynDMxAULWjpUk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=aP2LR2mDyPYXSD6pEHMErapGTKEdXpu7apYGrFcPFVCxqxO9ccmWKoRdFj7HOdZUP 2xWvOO6Gr9eN1oHUKEHdcBr6vNZ4CsRBsXvHvPi/1b+qMBal//YHeQiCcbw/nJsDgS k9JoronsMUDc/AXttZBUDML+w0Agl6aLizbmiP1k= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id D36C7385AE75 for ; Tue, 25 Oct 2022 16:22:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D36C7385AE75 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CAB521FEA; Tue, 25 Oct 2022 16:22:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0131F134CA; Tue, 25 Oct 2022 16:22:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O6meOkYNWGMfGgAAMHmgww (envelope-from ); Tue, 25 Oct 2022 16:22:30 +0000 Message-ID: Date: Tue, 25 Oct 2022 18:22:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4 2/2] gdb/reverse: Fix stepping over recursive functions Content-Language: en-US To: Simon Marchi , Bruno Larsen , gdb-patches@sourceware.org References: <20221005103832.3163424-1-blarsen@redhat.com> <20221005103832.3163424-3-blarsen@redhat.com> <95cc9197-e54a-f6ea-8092-d6d0063c58a3@simark.ca> In-Reply-To: <95cc9197-e54a-f6ea-8092-d6d0063c58a3@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/25/22 16:55, Simon Marchi via Gdb-patches wrote: > On 10/5/22 06:38, Bruno Larsen via Gdb-patches wrote: >> Currently, when using GDB to do reverse debugging, if we try to use the >> command "reverse next" to skip a recursive function, instead of skipping >> all of the recursive calls and stopping in the previous line, we stop at >> the second to last recursive call, and need to manually step backwards >> until we leave the first call. This is well documented in PR gdb/16678. >> >> This bug happens because when GDB notices that a reverse step has >> entered into a function, GDB will add a step_resume_breakpoint at the >> start of the function, then single step out of the prologue once that >> breakpoint is hit. The problem was happening because GDB wouldn't give >> that step_resume_breakpoint a frame-id, so the first time the breakpoint >> was hit, the inferior would be stopped. This is fixed by giving the >> current frame-id to the breakpoint. >> >> This commit also changes gdb.reverse/step-reverse.c to contain a >> recursive function and attempt to both, skip it altogether, and to skip >> the second call from inside the first call, as this setup broke a >> previous version of the patch. >> --- >> gdb/infrun.c | 2 +- >> gdb/testsuite/gdb.reverse/step-precsave.exp | 6 ++- >> gdb/testsuite/gdb.reverse/step-reverse.c | 19 ++++++- >> gdb/testsuite/gdb.reverse/step-reverse.exp | 55 +++++++++++++++++++-- >> 4 files changed, 74 insertions(+), 8 deletions(-) > > Hi Bruno, > > I see these failures since this commit: > > $ make check TESTS="gdb.reverse/step-reverse.exp" RUNTESTFLAGS="--target_board=native-gdbserver" > FAIL: gdb.reverse/step-reverse.exp: reverse next over recursion again > FAIL: gdb.reverse/step-reverse.exp: enter recursive function > FAIL: gdb.reverse/step-reverse.exp: step over recursion inside the recursion > On aarch64, I ran into another regression due to this commit (test-case gdb.reverse/solib-precsave.exp), filed as https://sourceware.org/bugzilla/show_bug.cgi?id=29721 . Thanks, - Tom