From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mTepGJs8amnVSQYAWB0awg (envelope-from ) for ; Fri, 16 Jan 2026 08:26:51 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qI0+VWBt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ea6q1Yld; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p4ZUAM4V; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QfwziBsO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5DEDD1E0DD; Fri, 16 Jan 2026 08:26:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BDFF71E070 for ; Fri, 16 Jan 2026 08:26:50 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 36DBC4BA2E3D for ; Fri, 16 Jan 2026 13:26:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36DBC4BA2E3D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qI0+VWBt; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ea6q1Yld; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=p4ZUAM4V; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QfwziBsO Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 228264BA2E22 for ; Fri, 16 Jan 2026 13:25:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 228264BA2E22 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 228264BA2E22 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768569959; cv=none; b=ATmNN8kpk8U7zjaZlFAYK65P2znYVbDVW6PbnSutzH6KlAEodPjEvkkiMQzsNa8Np7teg5Y+pAceRlyKbLoFpJAQKbSOlPXOP5vh1s+9Ibs7wQJ4VGssr+vjNw50fKkKKH9BYxv0LTCJGVYntmf10gk/S3ODx24sxezH3TyfNzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768569959; c=relaxed/simple; bh=Sc7Mm9tRX/T0CYImA9Tiq3o5qJnSvKxvFw0wZW26uM8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=GV+Rx3J5dMQfaqwegOZPUzOUwb3P6MDvkpZknaqheBqhsgVLaJAXvJcD2bnx4C6spkH45byWfut3k+OTWacj1sVSIqtRr6TA9XrQip3NGvRiwkV9TwazHkk2jW7nBYLdQoDDLijmX311DoGAK8UZLPrWCdPjBP2wNCcEESjIUok= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 228264BA2E22 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E644C5BE19; Fri, 16 Jan 2026 13:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768569958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Yrocr5gOra0FDiom4Fzuc9vpIgqUFF9jDOjxroYzVk=; b=qI0+VWBtNhgisJAhVVK0nU+UTXNb+axADU/BBa9eEZ8bA1JngnO5HYvcSlFlJ4kYAtcewL bKQgo5t0pTvpQJZQMzKw3tXQoExebhSGfsGwMqYtrcafpWH9ZdkSokVr8sVsOQc9WtQIy+ KwOjfRuxbvb1LPleFl0iJi1NJdB2uZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768569958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Yrocr5gOra0FDiom4Fzuc9vpIgqUFF9jDOjxroYzVk=; b=Ea6q1YldXKFNrhqd31uAMeRk0c43f29WwjR0eL64ULx+NTI/NaofiUn1TV1ZdvbgBPdgZs WaM6JuRUKC+OskAA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=p4ZUAM4V; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QfwziBsO DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1768569957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Yrocr5gOra0FDiom4Fzuc9vpIgqUFF9jDOjxroYzVk=; b=p4ZUAM4VDWGldtdPEK6XKRgsd14DMc4QbZ0JOK5oVIU1izyLlK4vSs/nAKFH/+xtCt5yrk IVjgSrH+yBwEBSwPa4zbDl8qTITm1DbrMtwP9feaesWJaglx1NejfTW7aDmLyND+ZmbGhe CHAiVCUuTwC2osi+Ve38RD6nsV5nBAA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1768569957; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Yrocr5gOra0FDiom4Fzuc9vpIgqUFF9jDOjxroYzVk=; b=QfwziBsOwtDKITY8z+1je8lB8P0Ti3DNEk7Yq1VLOKAMJ7v24G3+mKNmp4ZVXiw83gsglh JYIrry+PN5tAIbBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CC1883EA63; Fri, 16 Jan 2026 13:25:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mZOYMGU8amkFLAAAD6G6ig (envelope-from ); Fri, 16 Jan 2026 13:25:57 +0000 Message-ID: Date: Fri, 16 Jan 2026 14:25:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Fix crash with debuginfod query From: Tom de Vries To: Andrew Burgess , gdb-patches@sourceware.org References: <20260114172833.1824823-1-tdevries@suse.de> <87pl7bt6nz.fsf@redhat.com> <5dbfe8e2-5f2b-40a3-80ca-09098df913df@suse.de> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: E644C5BE19 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/15/26 3:26 PM, Tom de Vries wrote: > On 1/15/26 2:13 PM, Tom de Vries wrote: >> Ok, I'll see if I can implement this approach in a more polished >> fashion.  Please let me know if you prefer to work on it your self. > > FYI, sofar I got this, passes all TUI test-cases. > I've submittted a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-January/224103.html ). Thanks, - Tom > Thanks, > - Tom > > ... > diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c > index 272f5134d85..9280ce2a0fa 100644 > --- a/gdb/tui/tui-layout.c > +++ b/gdb/tui/tui-layout.c > @@ -268,6 +268,23 @@ tui_remove_some_windows () >    tui_apply_current_layout (true); >  } > > +extern bool defer_rerender; > +bool defer_rerender = false; > + > +static std::vector> deferred_rerender; > + > +extern void do_deferred_rerender (); > + > +void > +do_deferred_rerender () > +{ > +  for (auto f: deferred_rerender) > +    { > +      f (); > +    } > +  deferred_rerender.clear (); > +} > + >  void >  tui_win_info::resize (int height_, int width_, >                int origin_x_, int origin_y_) > @@ -296,7 +313,13 @@ tui_win_info::resize (int height_, int width_, >    if (handle == nullptr) >      make_window (); > > -  rerender (); > +  if (defer_rerender) > +    deferred_rerender.push_back ([this] () > +      { > +    rerender (); > +      }); > +  else > +    rerender (); >  } > > > > diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c > index fb94823f0fe..21e8838fa44 100644 > --- a/gdb/tui/tui.c > +++ b/gdb/tui/tui.c > @@ -393,6 +393,9 @@ gdb_getenv_term (void) >    return ""; >  } > > +extern bool defer_rerender; > +extern void do_deferred_rerender (); > + >  /* Enter in the tui mode (curses). >     When in normal mode, it installs the tui hooks in gdb, redirects >     the gdb output, configures the readline to work in tui mode. > @@ -493,6 +496,7 @@ tui_enable (void) >        def_prog_mode (); > >        tui_show_frame_info (deprecated_safe_get_selected_frame ()); > +      defer_rerender = true; >        tui_set_initial_layout (); >        tui_set_win_focus_to (tui_src_win ()); >        keypad (tui_cmd_win ()->handle.get (), TRUE); > @@ -516,6 +520,9 @@ tui_enable (void) > >    tui_setup_io (1); > > +  do_deferred_rerender (); > +  defer_rerender = false; > + >    /* Resize windows before anything might display/refresh a >       window.  */ >    if (tui_win_resized ()) > >