From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DM4CIbxczWLpRREAWB0awg (envelope-from ) for ; Tue, 12 Jul 2022 07:36:28 -0400 Received: by simark.ca (Postfix, from userid 112) id 7B3491E5EA; Tue, 12 Jul 2022 07:36:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A0CB1E222 for ; Tue, 12 Jul 2022 07:36:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F116385828D for ; Tue, 12 Jul 2022 11:36:26 +0000 (GMT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 9ED84385842B for ; Tue, 12 Jul 2022 11:36:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9ED84385842B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id d16so10738483wrv.10 for ; Tue, 12 Jul 2022 04:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KqRzrQeR9iMwztbV17i+W/5Sc0w9EuMAC/lKda67K3Y=; b=LcMaeYlve8JIafBKCo6y3Zma5W56Lc46FfLIzoXYose7tmPy2jafFd8Fe5fh9hq86A A6CHIWX+XtqhcpxOh0MMhFA54GzHhsAakkvN/GDc2kEbM82AH5+ds78nfgBSQbdXmUhq AkNIQuNeQHq0H/iIKmPd7hPhsZQnVaMfzzUPyTuNueY86t7L+uyWPgyxSLFLejqpvoz0 43vXX18Ppc60bUvEZK2m9ckYOv2ppKrwahoppU26WcK5a70j3sR7tOdgejI896WJol2E nb92xQWX6rosheI3Bt2UUJn0Mu8LIgSezEaOjI8Ktx5FipmH0V1IzK485Og+1hJvuoDD u+yA== X-Gm-Message-State: AJIora+HJSEukXirGch+FSiKYDaYmbcbuo0KU3W8EgraYSXfmU+ZZOIB YcXqK3s5hxRJmYkBm2AXdvK/kjPl/SI= X-Google-Smtp-Source: AGRyM1tVDPXKz9Aj7+NgcEH/KFFJeJcADa+orBLMy5/DvE3wbTeKabqECQ2BZEDBMz9myvr44cyGwQ== X-Received: by 2002:a5d:59a9:0:b0:21d:7ee2:8f90 with SMTP id p9-20020a5d59a9000000b0021d7ee28f90mr21716538wrr.598.1657625773481; Tue, 12 Jul 2022 04:36:13 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id n6-20020adfe786000000b0021b9504cc83sm8103249wrm.31.2022.07.12.04.36.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 04:36:12 -0700 (PDT) Subject: Re: [PATCH][gdb/build] Fix build with gcc 4.8.5 To: Tom de Vries , gdb-patches@sourceware.org References: <20220712113125.GA14559@delia.home> From: Pedro Alves Message-ID: Date: Tue, 12 Jul 2022 12:36:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220712113125.GA14559@delia.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-07-12 12:31 p.m., Tom de Vries wrote: > Hi, > > When building gdb with gcc 4.8.5, we run into problems due to unconditionally > using: > ... > gdb_static_assert (std::is_trivially_copyable::value); > ... > in gdbsupport/packed.h. > > Fix this by guarding the usage with HAVE_IS_TRIVIALLY_COPYABLE. > > Tested by doing a full gdb build with gcc 4.8.5. > > Any comments? This is OK, thanks.