From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36928 invoked by alias); 26 Nov 2016 16:39:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36918 invoked by uid 89); 26 Nov 2016 16:39:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, discarded, Hx-languages-length:1521, whoever X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Nov 2016 16:39:12 +0000 Received: by simark.ca (Postfix, from userid 33) id 7718B1E86E; Sat, 26 Nov 2016 11:39:10 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH 17/22] Simplify ui-out level code X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 26 Nov 2016 16:39:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <2905e1fc-fd7a-59f9-950e-70e0a0ad096e@redhat.com> References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-17-simon.marchi@polymtl.ca> <2905e1fc-fd7a-59f9-950e-70e0a0ad096e@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00896.txt.bz2 On 2016-11-24 13:42, Pedro Alves wrote: > On 11/24/2016 03:27 PM, Simon Marchi wrote: >> /* Discard the current level, return the discarded level's index. > > "return the..." is stale. Indeed, both for push_level and pop_level. >> specified after table_body and inside a list.")); >> /* NOTE: cagney/2001-12-08: There was a check here to ensure >> - that this code was only executed when uiout->level was >> + that this code was only executed when uiout->level () was >> greater than zero. That no longer applies - this code is run >> before each table row tuple is started and at that point the >> level is zero. */ > > This is talking about level zero. Should we just delete the whole > comment? Yes, I think so. I don't like this kind of comment very much, since they are not so relevant after some time. After 15 years, I think we can assume whoever needed to see it has seen it. I removed it locally. >> @@ -906,11 +897,9 @@ ui_out_new (const struct ui_out_impl *impl, void >> *data, >> uiout->flags = flags; >> uiout->table.flag = 0; >> uiout->table.body_flag = 0; >> - uiout->level = 0; >> >> - /* Create uiout->level 0, the default level. */ >> - std::unique_ptr level (new ui_out_level >> (ui_out_type_tuple)); >> - uiout->levels.push_back (std::move (level)); >> + /* Create uiout->level () 0, the default level. */ >> + push_level (uiout, ui_out_type_tuple); > > level 0 again? Changed to: /* Create the ui-out level #1, the default level. */