From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gLADJhSvY2eU3iEAWB0awg (envelope-from ) for ; Thu, 19 Dec 2024 00:28:52 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nd1vP7Nc; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 984041E097; Thu, 19 Dec 2024 00:28:52 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C5761E05C for ; Thu, 19 Dec 2024 00:28:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC6313858D39 for ; Thu, 19 Dec 2024 05:28:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC6313858D39 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nd1vP7Nc Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id E67633858D20 for ; Thu, 19 Dec 2024 05:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E67633858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E67633858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734586100; cv=none; b=XXhBBesh25bKe3BuEcQsOAFoMk5ey5qNb8fMzK3Cfn2Ak39x+7DJ04uvJunDQdSNNA3Vqb/a7EX8bLjxn33YfL9cQmMD9d9fFqhepvv40np1hsTRbV7UDmbehraU1yLa0/CboiMiRKLvZ0O3B9Tb5gGxgFjqxvIhDCD5Ptr5sLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734586100; c=relaxed/simple; bh=Jocao+Nz2VmO1+X1/0HzkXolg1btDQOYDA6QfDJJNP8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=neXuHzXQK+QvxERfwueJMMZQdFo6gO2IAV3t1Ks2DPIRY8T42vZfqD7/fVmxbetehKzaGk7rjWgYjF1b4dp5X9xgIFuNW58rInuIHDJsrmeMux0xZgNfD1MczXAffuF6r/O2QDv8/FtRCojDnhafbP+own2Kw+TzWht4wd/WeqQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E67633858D20 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-6dcf63155b0so2368656d6.1 for ; Wed, 18 Dec 2024 21:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734586099; x=1735190899; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=QfjcA0pFRsoxBQlHOUA8XYc3PCbuduWDRZHe7nhsLPA=; b=nd1vP7Ncb554shVM01CCKlLDLXRHX7rplZDgCWmSnQ4uW96cBrUbU5wGKz/FLIi0yA jFg+i/GE34XyzLHivK5/+EXpkNw5L34HTPRPqWbopSj5Sq01enqAaHNCTGgKSBvR05zr 9Mi1zWrdLjmltYWNFDb4IQiDVmpCZA5GXIUawpmaKVh4UAlJHEiGZjMOlrmXAOR/kNuc wxcwpDzCb/fRxllkYuq4nErQNy5Gh2a/+ouOd45Fc3P9TZzch7gwkIAiSwVLaqJhLJtZ sLLmhvGU1PimoYaYa/Uw8HN4+k1c2u/I2Bex+9vi2oC8Fp/cav15bhGxYzWETddSN3v5 +hPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734586099; x=1735190899; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QfjcA0pFRsoxBQlHOUA8XYc3PCbuduWDRZHe7nhsLPA=; b=CF9uLXFVlAFtbNtowaxagB+xLYUZZyLCkHD6nZ6C7S5hRXibAVwG31G0WV/gPRf5ZB C5N1rEy8Ezlj6RTZqloySql7zynV9SwOiQ5uMJyoeaclItrzCdDhCFMBHl24NxBWgG6W JvY40pt94CJtMXm4U6ZNrPzINwdFY4FGq/S2ufA/adBQ93xrACasG0ZP57guOMn/TBoW 0vpjqa88YcvRGkUe7wF/0eDWbD/B4ffNyKnlO8iQ0q7FxpdYp0ZXHpw6YCndIhoQoypE J975yFn9qhnIiGeaEMVs0MWOY5sEb6Y8J+xbF8LTMHaTK0T/K9hMDgQohRDJux62GgY6 oXgg== X-Gm-Message-State: AOJu0Yz+QoOVycX56h9SxsUUydSZgxOQXm8YSwjWUCFjweAL2xLbeNSh 5QRTGY5RZimU+1YLGD/iyugeRWofYC5tTQvTFpeCS3/0Qf4v7lneV/Ivq7o= X-Gm-Gg: ASbGncupM/vyUcCe+/RER+VWL+c2EPbonCu+YwzSyjmVwwQDXIl38ZAqy2/DhesxqwQ QHRkM8/Caq/U4GHnaxZAkzCh9lk+OAY1QtiTibITbr+hAjOIGWUuMaS1VslEhvyvEkPz028YiW2 7P69jIndZc/kTdcXD3vFpLiRos/fCHd8u/iFygsQaI56zncOchFZ4AjAiSPcM/A7GFm4GbcSjc0 HK0cCi0I5tJ+G0NEOBnDg1xv3aJyjJu+bfiJSKL5LwBYfHb7wM/LCVJ6JWsaZmbJQTNvbL7krCA v1KotnOlgUeGuBaGrmyOUsOxnTo= X-Google-Smtp-Source: AGHT+IF8j8S0Fp6llyj0Yv1yuLSowrhBU+TgTh8hjcY7HC/VCdxmHsfc6H75rCWnCbB8MdL+apG4gQ== X-Received: by 2002:a05:6214:1d21:b0:6d8:9d81:2107 with SMTP id 6a1803df08f44-6dd091e3d57mr92563646d6.20.1734586098846; Wed, 18 Dec 2024 21:28:18 -0800 (PST) Received: from localhost (dynamic-acs-24-144-188-205.zoominternet.net. [24.144.188.205]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac4cc3c7sm22128785a.111.2024.12.18.21.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 21:28:18 -0800 (PST) Date: Thu, 19 Dec 2024 00:28:20 -0500 From: Flavio Cruz To: gdb-patches Cc: Tom Tromey Subject: [PATCH v2] Hurd: remove VLA usage. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Compilation will fail with -Werror=vla, which seems to be the default. Note that we don't need to allocate num_threads + 1 since the matching algorithm works only on the num_threads as returned by task_threads. --- gdb/gnu-nat.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c index a8a4da1c..be6fa879 100644 --- a/gdb/gnu-nat.c +++ b/gdb/gnu-nat.c @@ -1016,15 +1016,13 @@ gnu_nat_target::inf_validate_procs (struct inf *inf) { /* Make things normally linear. */ mach_msg_type_number_t search_start = 0; - /* Which thread in PROCS corresponds to each task thread, & the task. */ - struct proc *matched[num_threads + 1]; + /* Which thread in PROCS corresponds to each task thread. */ + std::vector matched (num_threads, nullptr); /* The last thread in INF->threads, so we can add to the end. */ struct proc *last = 0; /* The current thread we're considering. */ struct proc *thread = inf->threads; - memset (matched, 0, sizeof (matched)); - while (thread) { mach_msg_type_number_t left; -- 2.45.2