From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5qNhMiX3wmd/0QEAWB0awg (envelope-from ) for ; Sat, 01 Mar 2025 07:01:41 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=heytings.org header.i=@heytings.org header.a=rsa-sha256 header.s=20220101 header.b=MIOD2YLH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BED071E105; Sat, 1 Mar 2025 07:01:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 286701E08E for ; Sat, 1 Mar 2025 07:01:41 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8454385841D for ; Sat, 1 Mar 2025 12:01:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B8454385841D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=heytings.org header.i=@heytings.org header.a=rsa-sha256 header.s=20220101 header.b=MIOD2YLH Received: from heytings.org (heytings.org [95.142.160.155]) by sourceware.org (Postfix) with ESMTPS id 46393385843D for ; Sat, 1 Mar 2025 12:00:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 46393385843D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=heytings.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=heytings.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 46393385843D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=95.142.160.155 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740830456; cv=none; b=AKQCC/r6hkBJg8Rm7u5j9d2RA4ieVKQBQlBXlfzQjensj3g3OOCLYPY2c/rL9m9ywbU7v/hosm/JA+98NXyiD9SHbjKmkPBtDk6aGfu224d06v6ISgksnT8p214sxjfwuHqzLzMkMdh045GcEhRvZiuDKi3ebErYJpaES5NYeF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740830456; c=relaxed/simple; bh=8w599LSgZ4mulZx74iyLtQrkTgokITUB3i9vrv3msa8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=tzQPPUHX2X49VxRWG+U51gWJm3QIdbYykbII6oYK6IUrAF+2LY46AtniCd9CFga2iJN8VSXdgMvs1LUtAJxOJz7TV/E6+zVt94nnBl8Ic+RDetmVMh37tU1wA7Wo6K05XuT70ImWQDImejNCC3fs//+3Dzk6mPfjb5CLSUXZdKM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 46393385843D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1740830455; bh=e7K/NpBepMZ064xp8qg96Nrm737mLC6d8+Ji+zb0PO0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=MIOD2YLHPmpbscjWbGjS5NcPMPYJQ8z2N5DvV5/jMTOh+lW9RYtCjuKJTVvOa4EZT RwyjGfQ+GKel6sX2ltQNCPL1081txt0ADrS5Ylqv1JQyle7YQ0s+wo+MTmolMz0wzH Or1xZioJxb3V7ZOR+Na9O/XeGb8sBnMAzxqid2RsqKMz2AYsLXpP6nVnmnMYSLHrv3 dil63EHqSFGZh6Wr7WX9XwIXss28JO6LjdPEUqfEs0RE+JzY8No4Vq3voqgCNegweT b1qd3Isd40T8QAF0UvUg5Z7htlNGD3zcqRXFcHgvr0EvEuOObwj0Fpwi7VoS5IlWor Nfd0K4ohZQrqA== Date: Sat, 01 Mar 2025 12:00:54 +0000 From: Gregory Heytings To: gdb-patches@sourceware.org cc: Eli Zaretskii Subject: Re: [PATCH] gdb: add load-libthread-db-quietly option In-Reply-To: <865xktq8gw.fsf@gnu.org> Message-ID: References: <865xktq8gw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="SyrV3vqWtC" X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --SyrV3vqWtC Content-Type: text/plain; charset=us-ascii; format=flowed Thanks for the review! Updated patch attached. >> In line with the Unix tradition in which no messages are displayed when >> no error happens, I suggest the attached patch, with which users could >> "set load-libthread-db-quietly off" in their .gdbinit file. > > You mean, "on", right? Because "off" is the default. > Correct. > > There should be a NEWS entry about this new knob. > Now done. > > This description seems to be backwards, no? The option, when ON, causes > the messages NOT to be displayed, right? So I suggest > > Turns on or off quiet loading of @code{libthread_db}. When @code{on}, > @value{GDBN} loads @code{libthread_db} quietly, without any messages. > The default is @code{off}. > Also correct. --SyrV3vqWtC Content-Type: text/x-diff; name=gdb-add-load-libthread-db-quietly-option.patch Content-Transfer-Encoding: base64 Content-ID: Content-Disposition: attachment; filename=gdb-add-load-libthread-db-quietly-option.patch RnJvbSAzNzEzYmY1OWQ0ZDRlZjQzZTUyOGE4YjYwOTVhOWJkY2EyZmVkNzM0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTYXQsIDEgTWFy IDIwMjUgMTE6NTY6NDIgKzAwMDANClN1YmplY3Q6IFtQQVRDSF0gZ2RiOiBh ZGQgbG9hZC1saWJ0aHJlYWQtZGItcXVpZXRseSBvcHRpb24NCg0KU2V0dGlu ZyB0aGF0IG9wdGlvbiBkaXNhYmxlcyB0aGUgIlRocmVhZCBkZWJ1Z2dpbmcg dXNpbmcgbGlidGhyZWFkX2RiDQplbmFibGVkIiBhbmQgIlVzaW5nIGhvc3Qg bGlidGhyZWFkX2RiIGxpYnJhcnkuLi4iIG1lc3NhZ2VzLg0KLS0tDQogZ2Ri L05FV1MgICAgICAgICAgICAgIHwgIDMgKysrDQogZ2RiL2RvYy9nZGIudGV4 aW5mbyAgIHwgIDggKysrKysrKysNCiBnZGIvbGludXgtdGhyZWFkLWRiLmMg fCAyOSArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQ0KIDMgZmlsZXMg Y2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCg0K ZGlmZiAtLWdpdCBhL2dkYi9ORVdTIGIvZ2RiL05FV1MNCmluZGV4IGY1ZGJm NWMzMzUwLi40ZTEwZDU4NjQyZiAxMDA2NDQNCi0tLSBhL2dkYi9ORVdTDQor KysgYi9nZGIvTkVXUw0KQEAgLTQwLDYgKzQwLDkgQEAgc2hvdyByaXNjdiBu dW1lcmljLXJlZ2lzdGVyLW5hbWVzDQogICAoZS5nICd4MScpIG9yIHRoZWly IGFiaSBuYW1lcyAoZS5nLiAncmEnKS4NCiAgIERlZmF1bHRzIHRvICdvZmYn LCBtYXRjaGluZyB0aGUgb2xkIGJlaGF2aW91ciAoYWJpIG5hbWVzKS4NCiAN CitzZXQgbG9hZC1saWJ0aHJlYWQtZGItcXVpZXRseSBvbnxvZmYNCisgIENv bnRyb2xzIHdoZXRoZXIgR0RCIGRpc3BsYXlzIG1lc3NhZ2VzIHdoZW4gbG9h ZGluZyBsaWJ0aHJlYWRfZGIuDQorDQogKiBQeXRob24gQVBJDQogDQogICAq KiBOZXcgY2xhc3MgZ2RiLkNvbG9yIGZvciBkZWFsaW5nIHdpdGggY29sb3Jz Lg0KZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9j L2dkYi50ZXhpbmZvDQppbmRleCAyOWMwMTE4ZGRhMi4uNGI3NTJhMTVjNDIg MTAwNjQ0DQotLS0gYS9nZGIvZG9jL2dkYi50ZXhpbmZvDQorKysgYi9nZGIv ZG9jL2dkYi50ZXhpbmZvDQpAQCAtNDA3Myw2ICs0MDczLDE0IEBAIG9ubHkg b24gc29tZSBwbGF0Zm9ybXMuDQogQGl0ZW0gc2hvdyBsaWJ0aHJlYWQtZGIt c2VhcmNoLXBhdGggDQogRGlzcGxheSBjdXJyZW50IGxpYnRocmVhZF9kYiBz ZWFyY2ggcGF0aC4NCiANCitAa2luZGV4IHNldCBsb2FkLWxpYnRocmVhZC1k Yi1xdWlldGx5DQorQGtpbmRleCBzaG93IGxvYWQtbGlidGhyZWFkLWRiLXF1 aWV0bHkNCitAaXRlbSBzZXQgbG9hZC1saWJ0aHJlYWQtZGItcXVpZXRseQ0K K0BpdGVteCBzaG93IGxvYWQtbGlidGhyZWFkLWRiLXF1aWV0bHkNCitUdXJu cyBvbiBvciBvZmYgcXVpZXQgbG9hZGluZyBvZiBAY29kZXtsaWJ0aHJlYWRf ZGJ9LiAgV2hlbg0KK0Bjb2Rle29ufSwgQHZhbHVle0dEQk59IGxvYWRzIEBj b2Rle2xpYnRocmVhZF9kYn0gcXVpZXRseSwgd2l0aG91dA0KK2FueSBtZXNz YWdlcy4gIFRoZSBkZWZhdWx0IGlzIEBjb2Rle29mZn0uDQorDQogQGtpbmRl eCBzZXQgZGVidWcgbGlidGhyZWFkLWRiDQogQGtpbmRleCBzaG93IGRlYnVn IGxpYnRocmVhZC1kYg0KIEBjaW5kZXggZGVidWdnaW5nIEBjb2Rle2xpYnRo cmVhZF9kYn0NCmRpZmYgLS1naXQgYS9nZGIvbGludXgtdGhyZWFkLWRiLmMg Yi9nZGIvbGludXgtdGhyZWFkLWRiLmMNCmluZGV4IDlkODQxODdhOWFkLi5k MDQyZDUxYzVmZCAxMDA2NDQNCi0tLSBhL2dkYi9saW51eC10aHJlYWQtZGIu Yw0KKysrIGIvZ2RiL2xpbnV4LXRocmVhZC1kYi5jDQpAQCAtMTIwLDYgKzEy MCw5IEBAIHN0YXRpYyBib29sIGF1dG9fbG9hZF90aHJlYWRfZGIgPSB0cnVl Ow0KICAgIGJ5IHRoZSAibWFpbnRlbmFuY2Ugc2V0IGNoZWNrLWxpYnRocmVh ZC1kYiIgY29tbWFuZC4gICovDQogc3RhdGljIGJvb2wgY2hlY2tfdGhyZWFk X2RiX29uX2xvYWQgPSBmYWxzZTsNCiANCisvKiBTZXQgdG8gdHJ1ZSBpZiBs b2FkaW5nIGxpYnRocmVhZF9kYiBoYXBwZW5zIHF1aWV0bHkuICAqLw0KK3N0 YXRpYyBib29sIGxvYWRfbGlidGhyZWFkX2RiX3F1aWV0ID0gZmFsc2U7DQor DQogLyogInNob3ciIGNvbW1hbmQgZm9yIHRoZSBhdXRvX2xvYWRfdGhyZWFk X2RiIGNvbmZpZ3VyYXRpb24gdmFyaWFibGUuICAqLw0KIA0KIHN0YXRpYyB2 b2lkDQpAQCAtMTUwLDYgKzE1MywxNSBAQCBzaG93X2xpYnRocmVhZF9kYl9k ZWJ1ZyAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIGludCBmcm9tX3R0eSwNCiAg IGdkYl9wcmludGYgKGZpbGUsIF8oImxpYnRocmVhZC1kYiBkZWJ1Z2dpbmcg aXMgJXMuXG4iKSwgdmFsdWUpOw0KIH0NCiANCisvKiAic2hvdyIgY29tbWFu ZCBmb3IgdGhlIGxvYWRfbGlidGhyZWFkX2RiX3F1aWV0IGNvbmZpZ3VyYXRp b24gdmFyaWFibGUuICAqLw0KKw0KK3N0YXRpYyB2b2lkDQorc2hvd19sb2Fk X2xpYnRocmVhZF9kYl9xdWlldCAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIGlu dCBmcm9tX3R0eSwNCisJCQkgICAgICBzdHJ1Y3QgY21kX2xpc3RfZWxlbWVu dCAqYywgY29uc3QgY2hhciogdmFsdWUpDQorew0KKyAgZ2RiX3ByaW50ZiAo ZmlsZSwgXygiTG9hZGluZyBsaWJ0aHJlYWRfZGIgcXVpZXRseSBpcyAlcy5c biIpLCB2YWx1ZSk7DQorfQ0KKw0KIC8qIElmIHdlJ3JlIHJ1bm5pbmcgb24g R05VL0xpbnV4LCB3ZSBtdXN0IGV4cGxpY2l0bHkgYXR0YWNoIHRvIGFueSBu ZXcNCiAgICB0aHJlYWRzLiAgKi8NCiANCkBAIC05MzYsNyArOTQ4LDggQEAg dHJ5X3RocmVhZF9kYl9sb2FkXzEgKHN0cnVjdCB0aHJlYWRfZGJfaW5mbyAq aW5mbykNCiAgICAgICByZXR1cm4gZmFsc2U7DQogICAgIH0NCiANCi0gIGdk Yl9wcmludGYgKF8oIltUaHJlYWQgZGVidWdnaW5nIHVzaW5nIGxpYnRocmVh ZF9kYiBlbmFibGVkXVxuIikpOw0KKyAgaWYgKCFsb2FkX2xpYnRocmVhZF9k Yl9xdWlldCkNCisgICAgZ2RiX3ByaW50ZiAoXygiW1RocmVhZCBkZWJ1Z2dp bmcgdXNpbmcgbGlidGhyZWFkX2RiIGVuYWJsZWRdXG4iKSk7DQogDQogICBp ZiAoIWxpYnRocmVhZF9kYl9zZWFyY2hfcGF0aC5lbXB0eSAoKSB8fCBsaWJ0 aHJlYWRfZGJfZGVidWcpDQogICAgIHsNCkBAIC05NDYsOCArOTU5LDkgQEAg dHJ5X3RocmVhZF9kYl9sb2FkXzEgKHN0cnVjdCB0aHJlYWRfZGJfaW5mbyAq aW5mbykNCiAgICAgICBpZiAobGlicmFyeSA9PSBOVUxMKQ0KIAlsaWJyYXJ5 ID0gTElCVEhSRUFEX0RCX1NPOw0KIA0KLSAgICAgIGdkYl9wcmludGYgKF8o IlVzaW5nIGhvc3QgbGlidGhyZWFkX2RiIGxpYnJhcnkgXCIlcHNcIi5cbiIp LA0KLQkJICBzdHlsZWRfc3RyaW5nIChmaWxlX25hbWVfc3R5bGUuc3R5bGUg KCksIGxpYnJhcnkpKTsNCisgICAgICBpZiAoIWxvYWRfbGlidGhyZWFkX2Ri X3F1aWV0KQ0KKwlnZGJfcHJpbnRmIChfKCJVc2luZyBob3N0IGxpYnRocmVh ZF9kYiBsaWJyYXJ5IFwiJXBzXCIuXG4iKSwNCisJCSAgICBzdHlsZWRfc3Ry aW5nIChmaWxlX25hbWVfc3R5bGUuc3R5bGUgKCksIGxpYnJhcnkpKTsNCiAg ICAgfQ0KIA0KICAgLyogVGhlIHRocmVhZCBsaWJyYXJ5IHdhcyBkZXRlY3Rl ZC4gIEFjdGl2YXRlIHRoZSB0aHJlYWRfZGIgdGFyZ2V0DQpAQCAtMjA1MCw2 ICsyMDY0LDE1IEBAIGFzIHRoZXkgYXJlIGxvYWRlZC4iKSwNCiAJCQkgICAm bWFpbnRlbmFuY2Vfc2V0X2NtZGxpc3QsDQogCQkJICAgJm1haW50ZW5hbmNl X3Nob3dfY21kbGlzdCk7DQogDQorICBhZGRfc2V0c2hvd19ib29sZWFuX2Nt ZCAoImxvYWQtbGlidGhyZWFkLWRiLXF1aWV0bHkiLCBjbGFzc19zdXBwb3J0 LA0KKwkJCSAgICZsb2FkX2xpYnRocmVhZF9kYl9xdWlldCwgXygiXA0KK1Nl dCB3aGV0aGVyIEdEQiBzaG91bGQgbG9hZCBsaWJ0aHJlYWRfZGIgcXVpZXRs eS4iKSwgXygiXA0KK1Nob3cgd2hldGhlciBHREIgc2hvdWxkIHN0YXJ0IGxv YWQgbGlidGhyZWFkX2RiIHF1aWV0bHkuIiksIF8oIlwNCitJZiBlbmFibGVk LCBHREIgd2lsbCBsb2FkIGxpYnRocmVhZF9kYiB3aXRob3V0IHByaW50aW5n IG1lc3NhZ2VzLiIpLA0KKwkJCSAgIE5VTEwsDQorCQkJICAgc2hvd19sb2Fk X2xpYnRocmVhZF9kYl9xdWlldCwNCisJCQkgICAmc2V0bGlzdCwgJnNob3ds aXN0KTsNCisNCiAgIC8qIEFkZCBvdXJzZWx2ZXMgdG8gb2JqZmlsZSBldmVu dCBjaGFpbi4gICovDQogICBnZGI6Om9ic2VydmVyczo6bmV3X29iamZpbGUu YXR0YWNoICh0aHJlYWRfZGJfbmV3X29iamZpbGUsICJsaW51eC10aHJlYWQt ZGIiKTsNCiANCi0tIA0KMi4zOS4yDQoNCg== --SyrV3vqWtC--