From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WIvgHV8hgGBFNwAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 08:58:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 6AE2A1F104; Wed, 21 Apr 2021 08:58:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E22271E813 for ; Wed, 21 Apr 2021 08:58:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B2D73AAB4B5; Wed, 21 Apr 2021 12:58:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B2D73AAB4B5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619009884; bh=gHTBWRi3gl2BvJ+CNlvMyeHJKYoKcOA9DSPKmaM+v7g=; h=To:Subject:Date:In-Reply-To:References:In-Reply-To:References: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help: List-Subscribe:From:Reply-To:From; b=ivlE99TOkahXqjLKdU1CaJKdRQGukhA5ZGuVH2WLspPktrnVl32cHKKpVVN33J/LP /rr2vJ9VYpETStEQBoAiyMiMVzXupQkVFIXAvstw5gknRYtk2N0f/f7r/SD1ZG0iN0 cnMXksAWmUv+SHfBWm54M3nRQPn/iN6xmlg/jrM4= Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id A415239B7030 for ; Wed, 21 Apr 2021 12:57:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A415239B7030 IronPort-SDR: Oankc5aH+VoTt+26kcVJIHfvvAvwuU+wpQ4ySYCZKoi9gGSzm8aDDRYzAmnrxpCs/PGNgUpCkF kf9mexp16CXQ== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="216331629" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="216331629" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 05:57:51 -0700 IronPort-SDR: C77uYrUt3uADDycjsjSj16yjKqXjLTbgmmvKkaE9z6i1ukIox2dVr2XfP821MEtyQnwMzlaNJE F3RIuYP8qMXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="602890234" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by orsmga005.jf.intel.com with ESMTP; 21 Apr 2021 05:57:50 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 13LCvnq2011357; Wed, 21 Apr 2021 13:57:49 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 13LCvnWe031949; Wed, 21 Apr 2021 14:57:49 +0200 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 13LCvnj0031945; Wed, 21 Apr 2021 14:57:49 +0200 To: gdb-patches@sourceware.org Subject: [PATCH 4/6] gdb/continuations: do minor cleanup Date: Wed, 21 Apr 2021 14:57:29 +0200 Message-Id: X-Mailer: git-send-email 1.7.0.7 In-Reply-To: References: In-Reply-To: References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Inferior continuations are no longer used by the until and finish command. It is used only by the attach command and the remote target upon detecting new inferiors. Update the comment accordingly. Also update another comment about non-existent thread continuations and remove an unused #include. gdb/ChangeLog: 2021-04-21 Tankut Baris Aktemur * continuations.h: Update the general comment. * inferior.h (class inferior) : Update the comment. * interps.c: Do not include "continuations.h". --- gdb/continuations.h | 4 ++-- gdb/inferior.h | 3 +-- gdb/interps.c | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gdb/continuations.h b/gdb/continuations.h index 7ebe82af1c5..39130c65f0f 100644 --- a/gdb/continuations.h +++ b/gdb/continuations.h @@ -25,8 +25,8 @@ struct inferior; /* To continue the execution commands when running gdb asynchronously. A continuation structure contains a pointer to a function to be called to finish the command, once the target has stopped. Such mechanism is - used by the finish and until commands, and in the remote protocol - when opening an extended-remote connection. */ + used by the attach command and the remote target when a new inferior + is detected. */ /* Prototype of the continuation callback functions. ARG is the continuation argument registered in the corresponding diff --git a/gdb/inferior.h b/gdb/inferior.h index 66fc180ce53..9ca510e4e6e 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -509,8 +509,7 @@ class inferior : public refcounted_object bool detaching = false; /* What is left to do for an execution command after any thread of - this inferior stops. For continuations associated with a - specific thread, see `struct thread_info'. */ + this inferior stops. */ continuation *continuations = NULL; /* True if setup_inferior wasn't called for this inferior yet. diff --git a/gdb/interps.c b/gdb/interps.c index d15a36a4266..ec19822b571 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -37,7 +37,6 @@ #include "interps.h" #include "completer.h" #include "top.h" /* For command_loop. */ -#include "continuations.h" #include "main.h" /* Each UI has its own independent set of interpreters. */ -- 2.17.1