From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111641 invoked by alias); 6 May 2016 11:53:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109357 invoked by uid 89); 6 May 2016 11:53:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 May 2016 11:53:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB46AC070457; Fri, 6 May 2016 11:53:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u46Brc7G019002; Fri, 6 May 2016 07:53:39 -0400 Subject: Re: [PATCH v2 08/25] Make input_fd be per UI To: Yao Qi References: <1458573675-15478-1-git-send-email-palves@redhat.com> <1458573675-15478-9-git-send-email-palves@redhat.com> <86oaa6vo9o.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 06 May 2016 11:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <86oaa6vo9o.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00095.txt.bz2 On 03/22/2016 09:46 AM, Yao Qi wrote: > Pedro Alves writes: > >> @@ -498,6 +504,10 @@ target_terminal_inferior (void) >> void >> target_terminal_ours (void) >> { >> + struct ui *ui = current_ui; >> + >> + add_file_handler (ui->input_fd, stdin_event_handler, ui); >> + >> if (terminal_state == terminal_is_ours) >> return; > > We should call add_file_handler after the terminal_state check above. > We actually shouldn't, because terminal_state only refers to the state of gdb's main tty state, while we still want to add/remove the _current_ UI's input_fd from the event loop. I've added comments in v3. Note that I'm gradually bubbling up these input_fd calls from the targets backends towards common code. At some point I'd like to migrate them somewhere even higher, maybe merged with async_disable_stdin / async_enable_stdin, now that since the ctrl-c rework series we only call target_terminal_ours when we really need input. But that'll be yet another set of cleaning-up-all-over-the-tree that I'd much rather not do along with this series. Thanks, Pedro Alves